Re: [asterisk-dev] [Code Review] 3999: chan_iax2: Jitterbuffer causes crash in Asterisk 13 on account of format changes

2014-09-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3999/#review13329 --- /branches/13/channels/chan_iax2.c

Re: [asterisk-dev] [Code Review] 3988: res_pjsip: Don't require a password when doing userpass authentication

2014-09-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3988/#review1 --- Ship it! Ship It! - Joshua Colp On Sept. 15, 2014, 7:27

Re: [asterisk-dev] [Code Review] 3994: Bridges User Documentation Update

2014-09-18 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3994/#review13334 --- Ship it! Ship It! - Matt Jordan On Sept. 15, 2014, 10:46

Re: [asterisk-dev] [Code Review] 3994: Bridges User Documentation Update

2014-09-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3994/ --- (Updated Sept. 18, 2014, 8:20 a.m.) Status -- This change has been

Re: [asterisk-dev] Git Migration

2014-09-18 Thread Matthew Jordan
On Wed, Sep 17, 2014 at 11:21 AM, Paul Belanger paul.belan...@polybeacon.com wrote: On Tue, Sep 16, 2014 at 6:01 PM, Russell Bryant russ...@russellbryant.net wrote: On Tue, Sep 16, 2014 at 3:48 PM, Matthew Jordan mjor...@digium.com wrote: snip Just to echo everything Russell typed, I

Re: [asterisk-dev] [Code Review] 3993: config: bug: Fix SEGV in ast_category_insert when a matching category isn't found

2014-09-18 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3993/ --- (Updated Sept. 18, 2014, 9:37 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3972: Only install dahdi_span_config_hook if DAHDI is enabled

2014-09-18 Thread David Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3972/ --- (Updated Sept. 18, 2014, 10 a.m.) Status -- This change has been

Re: [asterisk-dev] Git Migration

2014-09-18 Thread Samuel Galarneau
On Tue, Sep 16, 2014 at 5:01 PM, Russell Bryant russ...@russellbryant.net wrote: On Tue, Sep 16, 2014 at 3:48 PM, Matthew Jordan mjor...@digium.com wrote: And there was much rejoicing \o/ But seriously, we all know that a lot of people have wanted to move to Git for some time. For the

Re: [asterisk-dev] [Code Review] 3999: chan_iax2: Jitterbuffer causes crash in Asterisk 13 on account of format changes

2014-09-18 Thread Jonathan Rose
On Sept. 18, 2014, 8:12 a.m., Joshua Colp wrote: /branches/13/channels/chan_iax2.c, line 4126 https://reviewboard.asterisk.org/r/3999/diff/1/?file=67373#file67373line4126 Despite it not changing behavior I'd still use 20 here to match 12. Alright, fixed that. The only difference in

Re: [asterisk-dev] [Code Review] 3999: chan_iax2: Jitterbuffer causes crash in Asterisk 13 on account of format changes

2014-09-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3999/#review13337 --- Ship it! Ship It! - Joshua Colp On Sept. 16, 2014, 9:28

Re: [asterisk-dev] [Code Review] 3995: res_pjsip_endpoint_identifier_ip: Can't parse identify with match value containing CIDR

2014-09-18 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3995/ --- (Updated Sept. 18, 2014, 11:44 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

2014-09-18 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/#review13339 --- /branches/12/main/stasis_channels.c

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

2014-09-18 Thread Jonathan Rose
On Sept. 18, 2014, 12:22 p.m., Matt Jordan wrote: /branches/12/main/stasis_channels.c, line 383 https://reviewboard.asterisk.org/r/3990/diff/3/?file=67394#file67394line383 This will terminate the dial masquerade datastore on the first dial completion message. Say I'm

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

2014-09-18 Thread Jonathan Rose
On Sept. 18, 2014, 12:22 p.m., Matt Jordan wrote: /branches/12/main/stasis_channels.c, line 383 https://reviewboard.asterisk.org/r/3990/diff/3/?file=67394#file67394line383 This will terminate the dial masquerade datastore on the first dial completion message. Say I'm

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

2014-09-18 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/ --- (Updated Sept. 18, 2014, 1:21 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

2014-09-18 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/#review13342 --- /branches/12/main/stasis_channels.c

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

2014-09-18 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/ --- (Updated Sept. 18, 2014, 1:25 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 4000: res_pjsip_sdp_rtp.c: Fix native formats containing formats that were not negotiated.

2014-09-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4000/ --- Review request for Asterisk Developers. Bugs: AFS-162

Re: [asterisk-dev] [Code Review] 3989: utils: Create ast_strsep function that ignores separators inside quotes.

2014-09-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3989/#review13343 --- Ship it! Ship It! - opticron On Sept. 15, 2014, 2:43 p.m.,

Re: [asterisk-dev] [Code Review] 3967: Subscriptoin state test events for review 3966

2014-09-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3967/ --- (Updated Sept. 18, 2014, 1:31 p.m.) Status -- This change has been

Re: [asterisk-dev] Git Migration

2014-09-18 Thread Russell Bryant
On Thu, Sep 18, 2014 at 12:29 PM, Russell Bryant russ...@russellbryant.net wrote: On Thu, Sep 18, 2014 at 11:31 AM, Samuel Galarneau sgalarn...@digium.com wrote: On Tue, Sep 16, 2014 at 5:01 PM, Russell Bryant russ...@russellbryant.net wrote: On Tue, Sep 16, 2014 at 3:48 PM, Matthew

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

2014-09-18 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/#review13344 --- Ship it! Ship It! - Matt Jordan On Sept. 18, 2014, 1:25

Re: [asterisk-dev] Git Migration

2014-09-18 Thread Samuel Galarneau
A couple more comments about the magic happening here ... First, git review knows where to push based on a file checked in to the repo: $ cat .gitreview [gerrit] host=review.openstack.org port=29418 project=openstack/nova.git git review also sets up a local commit hook that adds a

[asterisk-dev] Asterisk 11.6-cert6, 11.12.1, 12.5.1 Now Available (Security Release)

2014-09-18 Thread Asterisk Development Team
The Asterisk Development Team has announced security releases for Certified Asterisk 11.6 and Asterisk 11 and 12. The available security releases are released as versions 11.6-cert6, 11.12.1, and 12.5.1. These releases are available for immediate download at

[asterisk-dev] AST-2014-009: Remote crash based on malformed SIP subscription requests

2014-09-18 Thread Asterisk Security Team
Asterisk Project Security Advisory - AST-2014-009 ProductAsterisk SummaryRemote crash based on malformed SIP subscription requests

[asterisk-dev] AST-2014-010: Remote crash when handling out of call message in certain dialplan configurations

2014-09-18 Thread Asterisk Security Team
Asterisk Project Security Advisory - AST-2014-010 ProductAsterisk SummaryRemote crash when handling out of call message in certain dialplan configurations

Re: [asterisk-dev] [Code Review] 3989: utils: Create ast_strsep function that ignores separators inside quotes.

2014-09-18 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3989/ --- (Updated Sept. 18, 2014, 2:21 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3988: res_pjsip: Don't require a password when doing userpass authentication

2014-09-18 Thread Sean Bright
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3988/ --- (Updated Sept. 18, 2014, 2:29 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3966: Testsuite: RLS batched notification tests

2014-09-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3966/ --- (Updated Sept. 18, 2014, 2:31 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

2014-09-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/#review13345 --- /branches/12/main/stasis_channels.c

Re: [asterisk-dev] [Code Review] 3992: res_pjsip_sdp_rtp: Add optimistic SRTP support.

2014-09-18 Thread Mark Michelson
On Sept. 15, 2014, 4:14 p.m., opticron wrote: This change appears to render the media_use_received_transport configuration option non-functional since it removes all checks relating to it. Joshua Colp wrote: It'll still work, the difference is on received it is always done and

Re: [asterisk-dev] [Code Review] 3970: res_phoneprov: Refactor phoneprov to allow pluggable config providers.

2014-09-18 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3970/ --- (Updated Sept. 18, 2014, 2:42 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

2014-09-18 Thread Jonathan Rose
On Sept. 18, 2014, 3:10 p.m., rmudgett wrote: /branches/12/main/stasis_channels.c, line 1257 https://reviewboard.asterisk.org/r/3990/diff/5/?file=67398#file67398line1257 dial_masquerade() is called with several locks held: the global channels lock, old_chan, and new_chan.

Re: [asterisk-dev] Git Migration

2014-09-18 Thread Russell Bryant
On Thu, Sep 18, 2014 at 3:01 PM, Samuel Galarneau sgalarn...@digium.com wrote: A couple more comments about the magic happening here ... First, git review knows where to push based on a file checked in to the repo: $ cat .gitreview [gerrit] host=review.openstack.org port=29418

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

2014-09-18 Thread rmudgett
On Sept. 18, 2014, 3:10 p.m., rmudgett wrote: /branches/12/main/stasis_channels.c, lines 381-394 https://reviewboard.asterisk.org/r/3990/diff/5/?file=67398#file67398line381 Why is the caller channel lock held for the ast_channel_publish_dial_forward() call? A dead

[asterisk-dev] [Code Review] 4001: PJSIP: Prevent T38 framehook being put on wrong channel

2014-09-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4001/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3976: New module: res_pjsip_phoneprov_provider provides the integration between res_pjsip and res_phoneprov.

2014-09-18 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3976/ --- (Updated Sept. 18, 2014, 3:21 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4001: PJSIP: Prevent T38 framehook being put on wrong channel

2014-09-18 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4001/#review13350 --- Ship it! Ship It! - Matt Jordan On Sept. 18, 2014, 4:19

Re: [asterisk-dev] [Code Review] 4000: res_pjsip_sdp_rtp.c: Fix native formats containing formats that were not negotiated.

2014-09-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4000/#review13351 --- /branches/13/res/res_pjsip_sdp_rtp.c

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

2014-09-18 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/ --- (Updated Sept. 18, 2014, 4:48 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-18 Thread Mark Michelson
On Sept. 11, 2014, 3:16 p.m., Joshua Colp wrote: /branches/13/res/res_pjsip.c, lines 2488-2501 https://reviewboard.asterisk.org/r/3954/diff/4/?file=67305#file67305line2488 Looking at the pjproject code why wouldn't the following return values cover these cases for when the

Re: [asterisk-dev] [Code Review] 3970: res_phoneprov: Refactor phoneprov to allow pluggable config providers.

2014-09-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3970/#review13348 --- A once over pass thourgh of the patch. You should go through

Re: [asterisk-dev] [Code Review] 3980: cel_odbc: Add microseconds precision in the eventtime column

2014-09-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3980/#review13353 --- Ship it! Ship It! - Mark Michelson On Sept. 5, 2014, 7:54

Re: [asterisk-dev] [Code Review] 3673: RLS: Nominal list tests

2014-09-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3673/ --- (Updated Sept. 18, 2014, 10:32 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4000: res_pjsip_sdp_rtp.c: Fix native formats containing formats that were not negotiated.

2014-09-18 Thread rmudgett
On Sept. 18, 2014, 4:35 p.m., Mark Michelson wrote: /branches/13/res/res_pjsip_sdp_rtp.c, line 259 https://reviewboard.asterisk.org/r/4000/diff/1/?file=67396#file67396line259 Since joint only has formats of type media_type, would specifying media_type instead of

Re: [asterisk-dev] [Code Review] 4000: res_pjsip_sdp_rtp.c: Fix native formats containing formats that were not negotiated.

2014-09-18 Thread Mark Michelson
On Sept. 18, 2014, 9:35 p.m., Mark Michelson wrote: /branches/13/res/res_pjsip_sdp_rtp.c, line 259 https://reviewboard.asterisk.org/r/4000/diff/1/?file=67396#file67396line259 Since joint only has formats of type media_type, would specifying media_type instead of

Re: [asterisk-dev] [Code Review] 4000: res_pjsip_sdp_rtp.c: Fix native formats containing formats that were not negotiated.

2014-09-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4000/#review13356 --- Ship it! Ship It! - Mark Michelson On Sept. 18, 2014, 6:26

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

2014-09-18 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/ --- (Updated Sept. 18, 2014, 5:50 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

2014-09-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/#review13358 --- Ship it! Ship It! - rmudgett On Sept. 18, 2014, 5:50 p.m.,

Re: [asterisk-dev] [Code Review] 3976: New module: res_pjsip_phoneprov_provider provides the integration between res_pjsip and res_phoneprov.

2014-09-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3976/#review13359 --- branches/12/res/res_pjsip_phoneprov_provider.c

Re: [asterisk-dev] [Code Review] 3970: res_phoneprov: Refactor phoneprov to allow pluggable config providers.

2014-09-18 Thread George Joseph
On Sept. 18, 2014, 4:11 p.m., rmudgett wrote: branches/12/res/res_phoneprov.c, lines 128-129 https://reviewboard.asterisk.org/r/3970/diff/4/?file=67281#file67281line128 This is an interesting way of doing the standard ao2 container callback functions. Did you fix the

Re: [asterisk-dev] [Code Review] 3970: res_phoneprov: Refactor phoneprov to allow pluggable config providers.

2014-09-18 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3970/ --- (Updated Sept. 18, 2014, 6:01 p.m.) Review request for Asterisk

Re: [asterisk-dev] Git Migration

2014-09-18 Thread Paul Belanger
On Thu, Sep 18, 2014 at 5:12 PM, Russell Bryant russ...@russellbryant.net wrote: On Thu, Sep 18, 2014 at 3:01 PM, Samuel Galarneau sgalarn...@digium.com wrote: A couple more comments about the magic happening here ... First, git review knows where to push based on a file checked in to the

Re: [asterisk-dev] [Code Review] 3976: New module: res_pjsip_phoneprov_provider provides the integration between res_pjsip and res_phoneprov.

2014-09-18 Thread George Joseph
On Sept. 18, 2014, 5:32 p.m., rmudgett wrote: branches/12/res/res_pjsip_phoneprov_provider.c, lines 71-75 https://reviewboard.asterisk.org/r/3976/diff/3/?file=67405#file67405line71 Concerned about the parameter names chosen. All uppercase parameter names is a bit unusual.

Re: [asterisk-dev] [Code Review] 3976: New module: res_pjsip_phoneprov_provider provides the integration between res_pjsip and res_phoneprov.

2014-09-18 Thread George Joseph
On Sept. 18, 2014, 5:32 p.m., rmudgett wrote: branches/12/res/res_pjsip_phoneprov_provider.c, line 174 https://reviewboard.asterisk.org/r/3976/diff/3/?file=67405#file67405line174 Another case where the if test burried in AST_VAR_LIST_INSERT_TAIL() is redundant. true but here I'm

Re: [asterisk-dev] [Code Review] 3976: New module: res_pjsip_phoneprov_provider provides the integration between res_pjsip and res_phoneprov.

2014-09-18 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3976/ --- (Updated Sept. 18, 2014, 6:55 p.m.) Review request for Asterisk