Re: [asterisk-dev] [Code Review] 4212: res_pjsip_endpoint_identified_ip: Add 'show identify' and 'show identifies' cli commands

2014-12-01 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4212/#review13849 --- Ship it! Ship It! - Joshua Colp On Nov. 24, 2014, 7:35

Re: [asterisk-dev] [Code Review] 4193: Stasis: allow for subscriptions to dictate message delivery on a threadpool for certain situations

2014-12-01 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4193/#review13850 --- Ship it! Ship It! - Joshua Colp On Nov. 24, 2014, 6:07

Re: [asterisk-dev] [Code Review] 4215: sorcery: Add additional observer capabilities.

2014-12-01 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4215/#review13851 --- branches/12/include/asterisk/config.h

Re: [asterisk-dev] [Code Review] 4216: res_pjsip: Direct Media calls within private network sometimes get one way audio

2014-12-01 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4216/#review13852 --- Does chan_sip also have this problem? I'd assume so (just

Re: [asterisk-dev] [Code Review] 4204: Failure showing codecs via 'core show channeltype tech'

2014-12-01 Thread Brad Latus
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4204/ --- (Updated Dec. 1, 2014, 7:07 a.m.) Status -- This change has been

Re: [asterisk-dev] FW: Asterisk Developers Mailing List

2014-12-01 Thread Matthew Jordan
On Fri, Nov 28, 2014 at 8:04 AM, Leif Madsen lmad...@thinkingphones.com wrote: Yea, that link looks legit. /sarcasm That does not look legit at all. Looks like the sender was a legitimate subscriber; it's possible his account was compromised. I've removed him from the list for the time

Re: [asterisk-dev] [Code Review] 4201: app_record: prevent stripping 1/4 second audio when channel is hung up to end recording.

2014-12-01 Thread Ben Smithurst
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4201/ --- (Updated Dec. 1, 2014, 7:39 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4211: Speed up loopback switches by avoiding unneeded lookups

2014-12-01 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4211/#review13853 --- Ship it! Ship It! - Joshua Colp On Nov. 24, 2014, 1:15

Re: [asterisk-dev] pjsip vs ca path

2014-12-01 Thread Mark Michelson
On 11/25/2014 02:46 PM, James Cloos wrote: Now that 13 has hit sid, I've started converting to pjsip. Chan_sip supports one's preference of a ca path or ca file, but res_pjsip does not. At least not on the 13 branch. Is that intentional, or an oversight? If not intentional, will a patch to

Re: [asterisk-dev] pjsip vs ca path

2014-12-01 Thread Olle E. Johansson
On 01 Dec 2014, at 16:21, Mark Michelson mmichel...@digium.com wrote: On 11/25/2014 02:46 PM, James Cloos wrote: Now that 13 has hit sid, I've started converting to pjsip. Chan_sip supports one's preference of a ca path or ca file, but res_pjsip does not. At least not on the 13 branch.

[asterisk-dev] [Code Review] 4217: config: Create ast_variable_find_in_list().

2014-12-01 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4217/ --- Review request for Asterisk Developers and Joshua Colp. Repository:

[asterisk-dev] [Code Review] 4218: res_pjsip_refer: Remove framehook when transfer is marked as completed as a result of joining a bridge

2014-12-01 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4218/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4217: config: Create ast_variable_find_in_list().

2014-12-01 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4217/#review13855 --- Ship it! Ship It! - Joshua Colp On Dec. 1, 2014, 4:19

Re: [asterisk-dev] [Code Review] 4218: res_pjsip_refer: Remove framehook when transfer is marked as completed as a result of joining a bridge

2014-12-01 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4218/#review13854 --- Ship it! Ship It! - Matt Jordan On Dec. 1, 2014, 10:24

Re: [asterisk-dev] pjsip vs ca path

2014-12-01 Thread Mark Michelson
On 12/01/2014 09:24 AM, Olle E. Johansson wrote: On 01 Dec 2014, at 16:21, Mark Michelson mmichel...@digium.com wrote: On 11/25/2014 02:46 PM, James Cloos wrote: Now that 13 has hit sid, I've started converting to pjsip. Chan_sip supports one's preference of a ca path or ca file, but

Re: [asterisk-dev] [Code Review] 4093: Codec Format Is Not Included in the SDP Media Attributes When SLIN48 Codec Is Used

2014-12-01 Thread Frankie Chin
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4093/ --- (Updated Dec. 1, 2014, 12:51 p.m.) Status -- This change has been

Re: [asterisk-dev] pjsip vs ca path

2014-12-01 Thread James Cloos
MM == Mark Michelson mmichel...@digium.com writes: MM For res_pjsip, we're using the mechanisms that PJSIP exposes in its MM TLS transport. Since a CA path option is not exposed, the option to MM provide one in pjsip.conf does not exist. If you want to provide a MM patch, that's totally fine,

Re: [asterisk-dev] pjsip vs ca path

2014-12-01 Thread Matthew Jordan
On Mon, Dec 1, 2014 at 2:58 PM, James Cloos cl...@jhcloos.com wrote: MM == Mark Michelson mmichel...@digium.com writes: MM For res_pjsip, we're using the mechanisms that PJSIP exposes in its MM TLS transport. Since a CA path option is not exposed, the option to MM provide one in pjsip.conf

Re: [asterisk-dev] pjsip vs ca path

2014-12-01 Thread James Cloos
MJ == Matthew Jordan mjor...@digium.com writes: MJ In order to keep the contributor license agreement stuff sane, the MJ Asterisk bug tracker please. I thought I remembered that. MJ And thanks! Sounds like a useful contribution. https://issues.asterisk.org/jira/browse/ASTERISK-24575 -JimC

Re: [asterisk-dev] [Code Review] 4050: Add ability for Channel Drivers to provide Presence State information

2014-12-01 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4050/#review13858 --- /trunk/main/channel.c

Re: [asterisk-dev] [Code Review] 4215: sorcery: Add additional observer capabilities.

2014-12-01 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4215/ --- (Updated Dec. 1, 2014, 4:50 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4212: res_pjsip_endpoint_identified_ip: Add 'show identify' and 'show identifies' cli commands

2014-12-01 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4212/ --- (Updated Dec. 1, 2014, 5:55 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4217: config: Create ast_variable_find_in_list().

2014-12-01 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4217/ --- (Updated Dec. 1, 2014, 6:35 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

2014-12-01 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4190/ --- (Updated Dec. 1, 2014, 5:40 p.m.) Review request for Asterisk Developers,