Re: [asterisk-dev] [Code Review] 4476: new res_pjsip module to identify endpoint for an incoming call with a trunk that has outbound registration.

2015-03-11 Thread Dmitriy Serov
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4476/ --- (Updated March 11, 2015, 4:30 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 4477: app_confbridge: file playback blocks dtmf

2015-03-11 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4477/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24864

[asterisk-dev] [Code Review] 4466: logger: Replace 'struct ast_callid' with unsigned int's.

2015-03-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4466/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24833

Re: [asterisk-dev] [Code Review] 4477: app_confbridge: file playback blocks dtmf

2015-03-11 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4477/#review14643 --- branches/11/apps/app_confbridge.c

Re: [asterisk-dev] [Code Review] 4170: testsuite: Delete bridges on completion for a bunch of rest_api tests

2015-03-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4170/ --- (Updated March 11, 2015, 3:13 p.m.) Status -- This change has been

Re: [asterisk-dev] AstriDevCon Follow Up - Asterisk and Kamailio - smoother integration

2015-03-11 Thread Olle E. Johansson
So far most of authorization between Kamailio and Asterisk relies on IP addresses, but those need to be provisioned one by one in both sides. The new module is practically adding a custom header with a hash over parts of the message or other environment attributes (eg., IP address) and a

Re: [asterisk-dev] AstriDevCon Follow Up - Asterisk and Kamailio - smoother integration

2015-03-11 Thread Matthew Jordan
On Wed, Mar 11, 2015 at 3:31 PM, Olle E. Johansson o...@edvina.net wrote: So far most of authorization between Kamailio and Asterisk relies on IP addresses, but those need to be provisioned one by one in both sides. The new module is practically adding a custom header with a hash over parts

Re: [asterisk-dev] [Code Review] 4468: Various: bugfixes discovered through use of chaos

2015-03-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4468/#review14645 --- Ship it! Ship It! - Corey Farrell On March 10, 2015, 11:27

Re: [asterisk-dev] [Code Review] 4475: audiohooks: Update internal sample rate on reads to prevent miscalculation of expected samples

2015-03-11 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4475/#review14640 --- Ship it! Ship It! - Joshua Colp On March 11, 2015, 5:30

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-11 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4474/#review14641 --- /trunk/include/asterisk/dns_recurring.h

Re: [asterisk-dev] AstriDevCon Follow Up - Asterisk and Kamailio - smoother integration

2015-03-11 Thread Matthew Jordan
On Tue, Mar 10, 2015 at 10:43 AM, Daniel-Constantin Mierla mico...@gmail.com wrote: Good to see the discussion had more people and wider approach on different levels, covering pure agnostic signaling up to specific application constraints. While being somehow silent, I worked to make a

[asterisk-dev] [Code Review] 4475: audiohooks: Update internal sample rate on reads to prevent miscalculation of expected samples

2015-03-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4475/ --- Review request for Asterisk Developers and Joshua Colp. Repository:

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-03-11 Thread Matt Jordan
On Feb. 20, 2015, 11:03 a.m., Corey Farrell wrote: /branches/11/include/asterisk/utils.h, lines 946-948 https://reviewboard.asterisk.org/r/4370/diff/2/?file=71539#file71539line946 I feel that configure should create a #define for the type of nested procedure supported. This

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-03-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4370/#review14653 --- Ship it! Ship It! - Corey Farrell On Feb. 20, 2015, 9:35

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-03-11 Thread Corey Farrell
On Feb. 21, 2015, 1:24 p.m., Corey Farrell wrote: /branches/11/configure.ac, line 1065 https://reviewboard.asterisk.org/r/4370/diff/3/?file=71557#file71557line1065 I missed this before / thought Josh pointed it out. This one should be AC_MSG_ERROR as well. Matt Jordan wrote:

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-03-11 Thread Matt Jordan
On Feb. 21, 2015, 12:24 p.m., Corey Farrell wrote: /branches/11/configure.ac, line 1065 https://reviewboard.asterisk.org/r/4370/diff/3/?file=71557#file71557line1065 I missed this before / thought Josh pointed it out. This one should be AC_MSG_ERROR as well. Matt Jordan wrote:

Re: [asterisk-dev] [Code Review] 4466: logger: Replace 'struct ast_callid' with unsigned int's.

2015-03-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4466/ --- (Updated March 11, 2015, 6:36 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

2015-03-11 Thread Ed Hynan
On March 10, 2015, 1:26 p.m., Ed Hynan wrote: /trunk/res/res_timing_kqueue.c, line 240 https://reviewboard.asterisk.org/r/4465/diff/1/?file=71888#file71888line240 Portability: at least EVFILT_USER and NOTE_TRIGGER are not defined on all kqueue(2) systems. Justin T. Gibbs

[asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-11 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4474/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24834

[asterisk-dev] [Code Review] 4478: testsuite: Fix reference leaks and shutdown timeouts in more tests

2015-03-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4478/ --- Review request for Asterisk Developers. Repository: testsuite

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-03-11 Thread Matt Jordan
On Feb. 21, 2015, 12:24 p.m., Corey Farrell wrote: /branches/11/configure.ac, line 1065 https://reviewboard.asterisk.org/r/4370/diff/3/?file=71557#file71557line1065 I missed this before / thought Josh pointed it out. This one should be AC_MSG_ERROR as well. Matt Jordan wrote:

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-03-11 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4370/#review14655 --- Ship it! Ship It! - Diederik de Groot On Feb. 21, 2015,

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-03-11 Thread Diederik de Groot
On Feb. 21, 2015, 7:24 p.m., Corey Farrell wrote: /branches/11/configure.ac, line 1065 https://reviewboard.asterisk.org/r/4370/diff/3/?file=71557#file71557line1065 I missed this before / thought Josh pointed it out. This one should be AC_MSG_ERROR as well. Matt Jordan wrote:

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-03-11 Thread Diederik de Groot
On March 12, 2015, 2:27 a.m., Diederik de Groot wrote: Ship It! Have you made a plan for addressing the warnings generated by clang's static analysis ? There are quite a number of them, some of which seem to be quite helpfull in pointing out some sore points, not sure if they uncover any