Re: [asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-12 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4467/ --- (Updated March 10, 2015, 2:45 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4438: add auto-dtmf mode for pjsip

2015-03-12 Thread yaron nahum
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4438/ --- (Updated March 12, 2015, 7:52 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-12 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4467/ --- (Updated March 11, 2015, 10:19 a.m.) Status -- This change has been

[asterisk-dev] Openais not supported in asterisk11.16

2015-03-12 Thread HKC323
Question : I want to get Device state from Different Asterisk Server Using Corosync and Openais . corosync-1.4.7 openais-1.1.4 nss nns-devel has been installed. i have refered [url]https://wiki.asterisk.org/wiki/display/AST/Distributed+Device+State +with+AIS[/url] i have configure Corosync ,

Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

2015-03-12 Thread Justin T. Gibbs
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4465/ --- (Updated March 13, 2015, 2:07 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

2015-03-12 Thread Justin T. Gibbs
On March 10, 2015, 1:26 p.m., Ed Hynan wrote: /trunk/res/res_timing_kqueue.c, line 240 https://reviewboard.asterisk.org/r/4465/diff/1/?file=71888#file71888line240 Portability: at least EVFILT_USER and NOTE_TRIGGER are not defined on all kqueue(2) systems. Justin T. Gibbs

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-03-12 Thread Diederik de Groot
On March 12, 2015, 2:27 a.m., Diederik de Groot wrote: Ship It! Diederik de Groot wrote: Have you made a plan for addressing the warnings generated by clang's static analysis ? There are quite a number of them, some of which seem to be quite helpfull in pointing out some sore

Re: [asterisk-dev] [Code Review] 4438: add auto-dtmf mode for pjsip

2015-03-12 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4438/#review14667 --- Ship it! My last few comments here are completely nit-picky

Re: [asterisk-dev] [Code Review] 4472: chan_pjsip/res_pjsip_callerid: Make Party ID handling simpler and consistent.

2015-03-12 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4472/#review14664 --- Ship it! Ship It! - Mark Michelson On March 10, 2015,

[asterisk-dev] [Code Review] 4483: Separate QoS settings for trunk packets

2015-03-12 Thread Y Ateya
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4483/ --- Review request for Asterisk Developers and mattjordan. Bugs:

Re: [asterisk-dev] [Code Review] 3488: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality.

2015-03-12 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3488/ --- (Updated March 12, 2015, 9:19 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 4484: testsuite: Fix HEP tests that fail after fixing pjsip.conf type=global default application.

2015-03-12 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4484/ --- Review request for Asterisk Developers. Repository: testsuite

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-12 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4474/#review14660 --- /trunk/main/dns_core.c

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-12 Thread Joshua Colp
On March 12, 2015, 5:57 p.m., Mark Michelson wrote: /trunk/main/dns_core.c, lines 285-290 https://reviewboard.asterisk.org/r/4474/diff/1/?file=71973#file71973line285 I was taking another look at this review and realized that there is nothing here to ensure that we do not wait

Re: [asterisk-dev] [Code Review] 4478: testsuite: Fix reference leaks and shutdown timeouts in more tests

2015-03-12 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4478/#review14662 --- Ship it! Regarding the remaining leak on the local optimize

Re: [asterisk-dev] [Code Review] 4475: audiohooks: Update internal sample rate on reads to prevent miscalculation of expected samples

2015-03-12 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4475/ --- (Updated March 12, 2015, 7:57 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add rpid_immediate option to prevent unnecessary 180 Ringing messages.

2015-03-12 Thread rmudgett
On March 12, 2015, 3:41 p.m., Matt Jordan wrote: 1. For this to go into Asterisk 13, tests will need to be provided that cover the new parameter. (Really, those tests should be written regardless) 2. The CHANGES file will need to get updated with the new option. Actually I'd prefer that

Re: [asterisk-dev] [Code Review] 4484: testsuite: Fix HEP tests that fail after fixing pjsip.conf type=global default application.

2015-03-12 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4484/#review14672 --- Ship it! Ship It! - Mark Michelson On March 12, 2015, 8:24

Re: [asterisk-dev] Openais not supported in asterisk11.16

2015-03-12 Thread Matthew Jordan
On Thu, Mar 12, 2015 at 5:51 AM, HKC323 hkc...@gmail.com wrote: Question : I want to get Device state from Different Asterisk Server Using Corosync and Openais . corosync-1.4.7 openais-1.1.4 nss nns-devel has been installed. i have refered

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-03-12 Thread Matt Jordan
On March 11, 2015, 8:27 p.m., Diederik de Groot wrote: Ship It! Diederik de Groot wrote: Have you made a plan for addressing the warnings generated by clang's static analysis ? There are quite a number of them, some of which seem to be quite helpfull in pointing out some sore

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-03-12 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4370/ --- (Updated March 12, 2015, 7:27 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4473: chan_pjsip: Add rpid_immediate option to prevent unnecessary 180 Ringing messages.

2015-03-12 Thread gareth
On March 12, 2015, 8:41 p.m., Matt Jordan wrote: 1. For this to go into Asterisk 13, tests will need to be provided that cover the new parameter. (Really, those tests should be written regardless) 2. The CHANGES file will need to get updated with the new option. rmudgett wrote:

Re: [asterisk-dev] [Code Review] 4466: logger: Replace 'struct ast_callid' with unsigned int's.

2015-03-12 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4466/ --- (Updated March 12, 2015, 8:12 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4438: add auto-dtmf mode for pjsip

2015-03-12 Thread yaron nahum
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4438/ --- (Updated March 12, 2015, 7:29 a.m.) Review request for Asterisk