Re: [asterisk-dev] [Code Review] 4577: res_pjsip_t38: T38 fax fails when using authentication with PJSIP sender

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4577/#review15038 --- /certified/branches/13.1/include/asterisk/res_pjsip_session.h

[asterisk-dev] Change in testsuite[master]: Add a test for PJSIP t38 with authentication based on normal...

Matt Jordan has posted comments on this change. Change subject: Add a test for PJSIP t38 with authentication based on normal t38 test .. Patch Set 1: (1 comment) https://gerrit.asterisk.org/#/c/22/1/tests/fax/pjsip/t38_with_a

[asterisk-dev] Change in testsuite[master]: non_stasis_bridge_to_stasis_bridge: Update regex for ami events

Corey Farrell has posted comments on this change. Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events .. Patch Set 2: Code-Review-1 (2 comments) Couple nit-picks about a comment / commit message. O

[asterisk-dev] Change in testsuite[master]: non_stasis_bridge_to_stasis_bridge: Update regex for ami events

Ashley Sanders has posted comments on this change. Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/25 To unsubscribe,

[asterisk-dev] Change in testsuite[master]: Add a test for PJSIP t38 with authentication based on normal...

Ashley Sanders has posted comments on this change. Change subject: Add a test for PJSIP t38 with authentication based on normal t38 test .. Patch Set 1: Code-Review-1 (5 comments) Very close. I think just fix the pylint error

[asterisk-dev] Change in testsuite[master]: Memory Debugging Improvements

Matt Jordan has posted comments on this change. Change subject: Memory Debugging Improvements .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.asterisk.org/15 To unsubscribe, visit https://gerrit.asterisk.org/settin

[asterisk-dev] Change in testsuite[master]: Memory Debugging Improvements

Matt Jordan has submitted this change and it was merged. Change subject: Memory Debugging Improvements .. Memory Debugging Improvements * Enable XML output from valgrind. * Display and save a summary of valgrind errors and leak

[asterisk-dev] Change in testsuite[master]: Memory Debugging Improvements

Matt Jordan has posted comments on this change. Change subject: Memory Debugging Improvements .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.asterisk.org/15 To unsubscribe, visit https://gerrit.asterisk.org/set

[asterisk-dev] Change in testsuite[master]: Memory Debugging Improvements

Ashley Sanders has posted comments on this change. Change subject: Memory Debugging Improvements .. Patch Set 4: Code-Review+1 >From what I can tell, everything looks good to me. -- To view, visit https://gerrit.asterisk.org/

Re: [asterisk-dev] [Code Review] 4577: res_pjsip_t38: T38 fax fails when using authentication with PJSIP sender

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4577/#review15036 --- /certified/branches/13.1/include/asterisk/res_pjsip_session.h

Re: [asterisk-dev] [Code Review] 4577: res_pjsip_t38: T38 fax fails when using authentication with PJSIP sender

> On April 2, 2015, 6:13 p.m., Kevin Harwell wrote: > > It is probably always the case that framehooks should not be attached > > twice. If this is true then it might be better to add a check in > > 'ast_framehook_attach' that first makes sure the hook is not already in the > > list. If so don

Re: [asterisk-dev] [Code Review] 4577: res_pjsip_t38: T38 fax fails when using authentication with PJSIP sender

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4577/#review15034 --- It is probably always the case that framehooks should not be at

[asterisk-dev] Change in testsuite[master]: non_stasis_bridge_to_stasis_bridge: Update regex for ami events

John Bigelow has posted comments on this change. Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events .. Patch Set 2: (1 comment) https://gerrit.asterisk.org/#/c/25/2/tests/rest_api/external_interact

Re: [asterisk-dev] [Code Review] 4536: iax2_poke_noanswer expiration timer too short

> On April 1, 2015, 1:07 a.m., Matt Jordan wrote: > > trunk/channels/chan_iax2.c, line 12370 > > > > > > The usage of max_retries here feels arbitrary. I'm not against this > > being controlled more dynamically b

[asterisk-dev] Change in testsuite[master]: non_stasis_bridge_to_stasis_bridge: Update regex for ami events

Kevin Harwell has uploaded a new patch set (#2). Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events .. non_stasis_bridge_to_stasis_bridge: Update regex for ami events Due to a bug in Asterisk, in som

[asterisk-dev] Change in testsuite[master]: non_stasis_bridge_to_stasis_bridge: Update regex for ami events

Kevin Harwell has uploaded a new change for review. https://gerrit.asterisk.org/25 Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events .. non_stasis_bridge_to_stasis_bridge: Update regex for ami eve

Re: [asterisk-dev] Test Asterisk Git Repo

On Thu, Apr 2, 2015 at 1:44 PM, Matthew Jordan wrote: > Hey everyone - > > I've made a test Asterisk repo on gerrit.asterisk.org (TEST-Asterisk). > This repo is *not* in sync with SVN, and it will be deleted before we > officially move Asterisk over. It is, however, a place where people > can chec

Re: [asterisk-dev] Asterisk to Git Migration Update

On Tue, Mar 31, 2015 at 7:54 PM, Matthew Jordan wrote: > On Tue, Mar 31, 2015 at 1:48 PM, Russell Bryant > wrote: > Yeah, I think I'd rather just bite the bullet and get the repo set up > "right" with as few weird things lingering around as possible. The > only potential issue is requiring lib

[asterisk-dev] Change in testsuite[master]: Add a test for PJSIP t38 with authentication based on normal...

Matt Jordan has posted comments on this change. Change subject: Add a test for PJSIP t38 with authentication based on normal t38 test .. Patch Set 1: (15 comments) https://gerrit.asterisk.org/#/c/22/1//COMMIT_MSG Commit Messa

[asterisk-dev] Change in testsuite[master]: Add a test for PJSIP t38 with authentication based on normal...

Jonathan Rose has uploaded a new change for review. https://gerrit.asterisk.org/22 Change subject: Add a test for PJSIP t38 with authentication based on normal t38 test .. Add a test for PJSIP t38 with authentication based on

Re: [asterisk-dev] [Code Review] 4490: astdb: Allow clustering of the Asterisk Database between multiple Asterisk servers

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4490/#review15032 --- /trunk/funcs/func_db.c

[asterisk-dev] [Code Review] 4575: bridge.c: Hangup attended transfer target after it has been swapped out

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4575/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24782 https://i

[asterisk-dev] [Code Review] 4577: res_pjsip_t38: T38 fax fails when using authentication with PJSIP sender

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4577/ --- Review request for Asterisk Developers and Joshua Colp. Bugs: ASTERISK-249

Re: [asterisk-dev] Trying to improve "file convert" command

On Thu, 2 Apr 2015, Pavel Troller wrote: I'm disappointed with functionality of the "file convert" command. Its results are very poor, at least in ast11. It looks that the conversion is performed through something like slin8 or even alaw/ulaw. There is a huge difference between listening to for

[asterisk-dev] Test Asterisk Git Repo

Hey everyone - I've made a test Asterisk repo on gerrit.asterisk.org (TEST-Asterisk). This repo is *not* in sync with SVN, and it will be deleted before we officially move Asterisk over. It is, however, a place where people can check the following: * That the tags look okay * That the relevant mai

[asterisk-dev] Trying to improve "file convert" command

Hi! I'm disappointed with functionality of the "file convert" command. Its results are very poor, at least in ast11. It looks that the conversion is performed through something like slin8 or even alaw/ulaw. There is a huge difference between listening to for example MP3Player() using a G.722 code

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 1: (3 comments) https://gerrit.asterisk.org/#/c/18/1/tests/rest_api/applications/stas

Re: [asterisk-dev] [Code Review] 4542: DNS: Add NAPTR support and tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4542/#review15031 --- Ship it! Ship It! - Kevin Harwell On April 1, 2015, 9:51 a.

Re: [asterisk-dev] [Code Review] 4574: pjsip: resolve compatibility problem with ast_sip_session struct

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4574/ --- (Updated April 2, 2015, 9:56 a.m.) Status -- This change has been mar

[asterisk-dev] [Code Review] 4576: testsuite: Add PJSIP test for new auto_dtmf option.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4576/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24706 https://i

Re: [asterisk-dev] running pjsip testsuite

On Thu, Apr 2, 2015 at 3:25 AM, Yaron Nachum wrote: > Hi everyone, > I ran the test manually. Just setup a single endpoint and using AMI I > originanted a call to an extension which dials to another extension and send > DTMF sequence using SendDTMF application. > > When I setup the endpoint with

[asterisk-dev] Change in testsuite[master]: Rewrite sip_attended_transfer test to stop failing.

Matt Jordan has posted comments on this change. Change subject: Rewrite sip_attended_transfer test to stop failing. .. Patch Set 3: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/19 To unsubscribe, visi

[asterisk-dev] Change in testsuite[master]: Rewrite sip_attended_transfer test to stop failing.

Matt Jordan has submitted this change and it was merged. Change subject: Rewrite sip_attended_transfer test to stop failing. .. Rewrite sip_attended_transfer test to stop failing. The sip_attended_transfer test has been bouncin

[asterisk-dev] Change in testsuite[master]: Memory Debugging Improvements

Matt Jordan has posted comments on this change. Change subject: Memory Debugging Improvements .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/15 To unsubscribe, visit https://gerrit.asterisk.org/set

Re: [asterisk-dev] [Code Review] 4557: Tell menuselect that MALLOC_DEBUG conflicts with DEBUG_CHAOS.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4557/ --- (Updated April 2, 2015, 5:32 a.m.) Status -- This change has been mar

[asterisk-dev] Change in testsuite[master]: Memory Debugging Improvements

Hello Ashley Sanders, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/15 to look at the new patch set (#4). Change subject: Memory Debugging Improvements .. Memory Debugging Improvements * En

Re: [asterisk-dev] running pjsip testsuite

Hi everyone, I ran the test manually. Just setup a single endpoint and using AMI I originanted a call to an extension which dials to another extension and send DTMF sequence using SendDTMF application. When I setup the endpoint with rfc4733 the dtmf is identified, but when I setup the endpoint wi