isk.org/r/4374/diff/
Testing
---
Thanks,
Ashley Sanders
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
-------
On Jan. 28, 2015, 8:13 p.m., Ashley Sanders wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4374/
>
Ashley
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4374/#review14339
---
On Jan. 28, 2015, 8:13 p.m., Ashley S
I appreciate your finding this. Thank you.
- Ashley
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4374/#review14351
--------
isk.org/r/4374/diff/
Testing
---
Thanks,
Ashley Sanders
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
isk.org/r/4374/diff/
Testing
---
Thanks,
Ashley Sanders
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
> On Jan. 27, 2015, 7:51 p.m., rmudgett wrote:
> > ./branches/13/main/http.c, line 384
> > <https://reviewboard.asterisk.org/r/4374/diff/2/?file=71124#file71124line384>
> >
> > Does this need to be skipped if http_server_name is empty?
>
> Ashley Sand
> want to switch to using an ast_str for this and use ast_str_set_va()
> > instead of the snprintf() when filling the string.
>
> Ashley Sanders wrote:
> You are correct, this is a small amount. From the previous review, you
> advised to take the larger of the error/auth
horized";
> >
> > char status_title[16] always reserves 16 bytes and copies the string
> > into the array then nuls any extra array characters.
>
> Ashley Sanders wrote:
> "Unauthorized" + a null terminating character = 13 characters, which i
horized";
> >
> > char status_title[16] always reserves 16 bytes and copies the string
> > into the array then nuls any extra array characters.
>
> Ashley Sanders wrote:
> "Unauthorized" + a null terminating character = 13 characters, which is
isk.org/r/4374/diff/
Testing
---
Thanks,
Ashley Sanders
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
t1/http.conf
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4377/diff/
Testing
---
Thanks,
Ashley Sanders
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSU
> On Jan. 27, 2015, 9:01 p.m., Ashley Sanders wrote:
> > /branches/13/res/res_pjsip_outbound_registration.c, line 1543
> > <https://reviewboard.asterisk.org/r/4381/diff/1/?file=71121#file71121line1543>
> >
> > Since there are no other attributes being initia
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4381/#review14337
---
Ship it!
Ship It!
- Ashley Sanders
On Jan. 27, 2015, 10:10
-------
On Jan. 27, 2015, 6:16 p.m., Ashley Sanders wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4374/
>
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4374/#review14324
-----------
On Jan. 27, 2015, 6:16 p.m., Ashley Sanders wrote:
>
> ---
--
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4374/#review14325
---
On Jan. 27, 2015, 6:16 p.m., Ashley Sanders wrote:
>
> -
tps://reviewboard.asterisk.org/r/4381/#comment24835>
Since there are no other attributes being initialized, does this line need
a comma?
- Ashley Sanders
On Jan. 27, 2015, 6:46 p.m., rmudgett wrote:
>
> ---
> This is a
ests/http_server/servername/configs/ast3/http.conf
PRE-CREATION
./asterisk/trunk/tests/http_server/servername/configs/ast2/http.conf
PRE-CREATION
./asterisk/trunk/tests/http_server/servername/configs/ast1/http.conf
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4377/diff/
T
./branches/13/configs/samples/http.conf.sample 431112
Diff: https://reviewboard.asterisk.org/r/4374/diff/
Testing
---
Thanks,
Ashley Sanders
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev
gt; Server:
> >
> > Is it intended for this to reset to the default "Asterisk/"?
> >
> > An alternate method is to check the set value at the end of the
> > function for an empty string and set the global value to
> > &quo
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4377/#review14306
---
On Jan. 26, 2015, 9:27 p.m., Ashley Sanders wrote:
>
> ---
> This is an automatically generate
> On Jan. 26, 2015, 5:44 p.m., rmudgett wrote:
> > ./branches/13/main/http.c, lines 567-568
> > <https://reviewboard.asterisk.org/r/4374/diff/1/?file=71085#file71085line567>
> >
> > Why are the allocation sizes passed in?
>
> Ashley Sanders wrote:
PRE-CREATION
./asterisk/trunk/tests/http_server/servername/configs/ast1/http.conf
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4377/diff/
Testing
---
Thanks,
Ashley Sanders
--
_
-- Bandwidth and Colocatio
wprefix) - 1);
I digress. Noted and fixed.
- Ashley
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4374/#review14289
-------
On Jan.
gt; Server:
> >
> > Is it intended for this to reset to the default "Asterisk/"?
> >
> > An alternate method is to check the set value at the end of the
> > function for an empty string and set the global value to
> > &quo
debug logs back trace the source? That would have had to happen before this
change, also.
- Ashley
-----------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4374/#review14289
--
terisk.org/r/4374/#review14289
---
On Jan. 26, 2015, 2:03 p.m., Ashley Sanders wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
erisk source. You can find the
review for the Testsuite at: https://reviewboard.asterisk.org/r/4377/
Diffs
-
./branches/13/main/http.c 431112
./branches/13/configs/samples/http.conf.sample 431112
Diff: https://reviewboard.asterisk.org/r/4374/diff/
Testing
---
EATION
Diff: https://reviewboard.asterisk.org/r/4377/diff/
Testing
---
Thanks,
Ashley Sanders
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update op
n a subsequent review.
Diffs
-
./branches/13/main/http.c 431112
./branches/13/configs/samples/http.conf.sample 431112
Diff: https://reviewboard.asterisk.org/r/4374/diff/
Testing
---
Thanks,
Ashley Sanders
--
___
-CREATION
Diff: https://reviewboard.asterisk.org/r/4348/diff/
Testing
---
Thanks,
Ashley Sanders
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or
---
Thanks,
Ashley Sanders
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
test suite at:
https://reviewboard.asterisk.org/r/4348
Diffs (updated)
-
./branches/13/res/ari/resource_bridges.c 430414
Diff: https://reviewboard.asterisk.org/r/4349/diff/
Testing
---
Thanks,
Ashley Sanders
://reviewboard.asterisk.org/r/4348
Diffs
-
./branches/13/res/ari/resource_bridges.c 430163
./branches/13/main/strings.c 430163
./branches/13/include/asterisk/strings.h 430163
Diff: https://reviewboard.asterisk.org/r/4349/diff/
Testing
---
Thanks,
Ashley Sanders
./asterisk/trunk/tests/rest_api/bridges/error/error.py PRE-CREATION
./asterisk/trunk/tests/rest_api/bridges/error/configs/ast1/extensions.conf
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4348/diff/
Testing
---
Thanks,
Ashley Sanders
101 - 136 of 136 matches
Mail list logo
