[asterisk-dev] [Code Review] 4464: testsuite: Increase timeout for Asterisk shutdown

2015-03-09 Thread Corey Farrell
- /asterisk/trunk/lib/python/asterisk/asterisk.py 6482 Diff: https://reviewboard.asterisk.org/r/4464/diff/ Testing --- No more shutdown timeouts from tests capable of graceful shutdown. Thanks, Corey Farrell -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4108: Weak Proxy Objects

2015-03-04 Thread Corey Farrell
with REF_DEBUG enabled under valgrind. No reference leaks or improper memory access. Though this does not test for races, I don't know of an automated way to do that. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 4108: Weak Proxy Objects

2015-03-04 Thread Corey Farrell
be a problem if the object were required to be immediately weakened after creation. Corey Farrell wrote: I've transfered the actual creation of weak proxy objects from ao2_weaken to ao2_alloc (with an option). I've changed my mind. Creation of ao2_weakproxy objects requires it's own

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-02-21 Thread Corey Farrell
On Feb. 20, 2015, 12:03 p.m., Corey Farrell wrote: /branches/11/include/asterisk/utils.h, lines 946-948 https://reviewboard.asterisk.org/r/4370/diff/2/?file=71539#file71539line946 I feel that configure should create a #define for the type of nested procedure supported

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-02-21 Thread Corey Farrell
/4370/#comment25074 I missed this before / thought Josh pointed it out. This one should be AC_MSG_ERROR as well. /branches/11/configure.ac https://reviewboard.asterisk.org/r/4370/#comment25073 These lines are unneeded as we've failed. - Corey Farrell On Feb. 20, 2015, 9:35 p.m

Re: [asterisk-dev] [Code Review] 4436: asterisk/lock.h: Fix syntax errors for non-gcc OSX with 64-bit integers

2015-02-20 Thread Corey Farrell
/ parenthesis. Diffs - /branches/11/include/asterisk/lock.h 431994 Diff: https://reviewboard.asterisk.org/r/4436/diff/ Testing --- Looked at the source. I don't know what compiler would match the #if conditions. Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 4435: Reverse #if statement in asterisk.c to fix code folding

2015-02-20 Thread Corey Farrell
to parse. Diffs - /trunk/main/asterisk.c 431991 Diff: https://reviewboard.asterisk.org/r/4435/diff/ Testing --- Some testsuite runs. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 4428: Allow graceful shutdown to unload modules that register bucket scheme's or codec's.

2015-02-20 Thread Corey Farrell
/diff/ Testing --- Build, basic startup/shutdown test. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-02-20 Thread Corey Farrell
://reviewboard.asterisk.org/r/4370/#comment25068 #error? - Corey Farrell On Feb. 19, 2015, 11:09 p.m., Matt Jordan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4370

[asterisk-dev] [Code Review] 4435: Reverse #if statement in asterisk.c to fix code folding

2015-02-19 Thread Corey Farrell
. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 4436: asterisk/lock.h: Fix syntax errors for non-gcc OSX with 64-bit integers

2015-02-19 Thread Corey Farrell
--- Looked at the source. I don't know what compiler would match the #if conditions. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

Re: [asterisk-dev] [Code Review] 4435: Reverse #if statement in asterisk.c to fix code folding

2015-02-19 Thread Corey Farrell
., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4435/ --- (Updated Feb. 19, 2015, 4:43 p.m.) Review

Re: [asterisk-dev] [Code Review] 4425: Create function to work around reference leaks caused by shutdown with pending scheduled events

2015-02-18 Thread Corey Farrell
, tests/feature_blonde_transfer Only tests/callparking still has 1 leaked reference (it was more). Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 4428: Allow graceful shutdown to unload modules that register bucket scheme's or codec's.

2015-02-17 Thread Corey Farrell
--- On Feb. 16, 2015, 1:58 p.m., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4428

[asterisk-dev] [Code Review] 4428: Allow graceful shutdown to unload modules that register bucket scheme's or codec's.

2015-02-16 Thread Corey Farrell
- /branches/13/main/loader.c 431876 /branches/13/main/codec.c 431876 /branches/13/main/bucket.c 431876 Diff: https://reviewboard.asterisk.org/r/4428/diff/ Testing --- Build, basic startup/shutdown test. Thanks, Corey Farrell

[asterisk-dev] [Code Review] 4425: Create function to work around reference leaks caused by shutdown with pending scheduled events

2015-02-15 Thread Corey Farrell
: tests/apps/directed_pickup/pickup_chan, tests/callparking, tests/channels/iax2/acl_call, tests/channels/iax2/basic-call, tests/feature_attended_transfer, tests/feature_blonde_transfer Only tests/callparking still has 1 leaked reference (it was more). Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 4425: Create function to work around reference leaks caused by shutdown with pending scheduled events

2015-02-15 Thread Corey Farrell
/callparking still has 1 leaked reference (it was more). Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4411: testsuite: fix a number of tests where Asterisk does not shutdown gracefully

2015-02-11 Thread Corey Farrell
of Asterisk timed out, causing reference leaks to be reported. These tests now shutdown gracefully and have no reference leaks. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 4410: testsuite: Fix output of minversion/maxversion of tests that cannot run

2015-02-11 Thread Corey Farrell
for tests that cannot run. Diffs - /asterisk/trunk/runtests.py 6377 Diff: https://reviewboard.asterisk.org/r/4410/diff/ Testing --- Verified correct output for a test that cannot run due to minversion. Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 4411: testsuite: fix a number of tests where Asterisk does not shutdown gracefully

2015-02-11 Thread Corey Farrell
p.m., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4411/ --- (Updated Feb. 9, 2015, 12:50 p.m

Re: [asterisk-dev] [Code Review] 4141: Enable REF_DEBUG for ast_module_ref / ast_module_unref

2015-02-11 Thread Corey Farrell
to bridge_builtin_features.c is omitted the test fails due to that one reference leak. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

[asterisk-dev] [Code Review] 4411: testsuite: fix a number of tests where Asterisk does not shutdown gracefully

2015-02-09 Thread Corey Farrell
, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 4410: testsuite: Fix output of minversion/maxversion of tests that cannot run

2015-02-08 Thread Corey Farrell
--- Verified correct output for a test that cannot run due to minversion. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 4141: Enable REF_DEBUG for ast_module_ref / ast_module_unref

2015-02-05 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4141/#review13861 --- On Nov. 2, 2014, 2:13 a.m., Corey Farrell wrote

Re: [asterisk-dev] [Code Review] 4141: Enable REF_DEBUG for ast_module_ref / ast_module_unref

2015-02-05 Thread Corey Farrell
to bridge_builtin_features.c is omitted the test fails due to that one reference leak. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 4108: Weak References

2015-02-04 Thread Corey Farrell
that this cannot race, since any potential for a race would be due to very exact timing. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

Re: [asterisk-dev] [Code Review] 4108: Weak References

2015-02-04 Thread Corey Farrell
/4108/#review13933 --- On Oct. 26, 2014, 7:10 a.m., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4108

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-29 Thread Corey Farrell
On Jan. 28, 2015, 7:21 a.m., Corey Farrell wrote: If we assume that there are always unknown security vulnerabilities, I think it is worth completely removing Server: Asterisk/version. Another option would be trimming to major version only - Server: Asterisk/13. Otherwise any

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-28 Thread Corey Farrell
will agree with this but feel that it needs to be considered. - Corey Farrell On Jan. 27, 2015, 7:16 p.m., Ashley Sanders wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4374

Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention caused by ast_string_fields_copy

2014-11-19 Thread Corey Farrell
. To reply, visit: https://reviewboard.asterisk.org/r/4186/#review13806 --- On Nov. 18, 2014, 1:36 p.m., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply

Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention caused by ast_string_fields_copy

2014-11-19 Thread Corey Farrell
://reviewboard.asterisk.org/r/4186/diff/ Testing --- Full testsuite against 12. I had 17 failures, but that is normal on my system. I re-ran the 17 tests without this patch, they still failed. Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

2014-11-18 Thread Corey Farrell
like to see this committed ASAP so further improvements can be made against it. - Corey Farrell On Oct. 16, 2014, 5:23 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention and another issue exposed by the fix

2014-11-18 Thread Corey Farrell
. Diffs - /branches/12/include/asterisk/stringfields.h 427735 Diff: https://reviewboard.asterisk.org/r/4186/diff/ Testing --- Full testsuite against 12. I had 17 failures, but that is normal on my system. I re-ran the 17 tests without this patch, they still failed. Thanks, Corey

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

2014-11-18 Thread Corey Farrell
On Nov. 18, 2014, 9:18 a.m., Corey Farrell wrote: Please discard my findings, they are minor. I'd like to see this committed ASAP so further improvements can be made against it. Scott Griepentrog wrote: I like your idea of adding an option to pass valgrind options, but it needs

Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention and another issue exposed by the fix

2014-11-18 Thread Corey Farrell
--- On Nov. 18, 2014, 9:25 a.m., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4186

Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention caused by ast_string_fields_copy

2014-11-18 Thread Corey Farrell
://reviewboard.asterisk.org/r/4186/diff/ Testing --- Full testsuite against 12. I had 17 failures, but that is normal on my system. I re-ran the 17 tests without this patch, they still failed. Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention caused by ast_string_fields_copy

2014-11-18 Thread Corey Farrell
testsuite against 12. I had 17 failures, but that is normal on my system. I re-ran the 17 tests without this patch, they still failed. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 4194: ast_str: Fix improper member access to struct ast_str members.

2014-11-18 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4194/#review13809 --- Ship it! Ship It! - Corey Farrell On Nov. 18, 2014, 3:03

Re: [asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention and another issue exposed by the fix

2014-11-17 Thread Corey Farrell
/diff/ Testing (updated) --- Full testsuite against 12. I had 17 failures, but that is normal on my system. I re-ran the 17 tests without this patch, they still failed. Thanks, Corey Farrell -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4160: chan_sip: Fix theoretical leak of p-refer

2014-11-17 Thread Corey Farrell
427685 Diff: https://reviewboard.asterisk.org/r/4160/diff/ Testing --- tests/channels/SIP against 11 Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing

Re: [asterisk-dev] [Code Review] 4182: core: avoid rasterisk crash due to long identifier

2014-11-17 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4182/#review13789 --- Ship it! Ship It! - Corey Farrell On Nov. 14, 2014, 6:03

[asterisk-dev] [Code Review] 4186: stringfields: Fix regression from fix for unintentional memory retention and another issue exposed by the fix

2014-11-15 Thread Corey Farrell
far I've only verified this change with the unit test brought to my attention by Richard. I'll be running the full testsuite ASAP, but wanted to allow this code to be seen now. Thanks, Corey Farrell -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4166: testsuite: tests/bridge/bridge_action leaves a channel open

2014-11-15 Thread Corey Farrell
. Diffs - /asterisk/trunk/tests/bridge/bridge_action/bridge_action.py 5920 Diff: https://reviewboard.asterisk.org/r/4166/diff/ Testing --- Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 4166: testsuite: tests/bridge/bridge_action leaves a channel open

2014-11-15 Thread Corey Farrell
On Nov. 13, 2014, 11:30 a.m., Mark Michelson wrote: With the fix being made to the leaked bridge in Asterisk, is this change still required? Does hanging up self.channels[1] not result in self.channels[3] and the bridge being destroyed as expected? Corey Farrell wrote: Still

Re: [asterisk-dev] [Code Review] 4182: core: avoid rasterisk crash due to long identifier

2014-11-14 Thread Corey Farrell
/r/4182/#comment24262 Does this actually initialize 256 bytes of '\0', or just initialize the first byte? /branches/13/main/asterisk.c https://reviewboard.asterisk.org/r/4182/#comment24261 Space around '-'. Also why was the return removed? - Corey Farrell On Nov. 14, 2014

Re: [asterisk-dev] [Code Review] 4170: testsuite: Delete bridges on completion for a bunch of rest_api tests

2014-11-13 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4170/#review13743 --- On Nov. 11, 2014, 5:41 p.m., Corey Farrell wrote: --- This is an automatically

Re: [asterisk-dev] [Code Review] 4182: core: avoid rasterisk crash due to long identifier

2014-11-13 Thread Corey Farrell
before read() when it's actually uninitialized data. I don't have a specific problem with increasing the buffer from 80 to 256, but I think we need to fix the parser so it doesn't crash if given 256 or more bytes. I think this issue applies to 11+. - Corey Farrell On Nov. 13, 2014, 3:31 p.m

Re: [asterisk-dev] [Code Review] 4166: testsuite: tests/bridge/bridge_action leaves a channel open

2014-11-13 Thread Corey Farrell
, visit: https://reviewboard.asterisk.org/r/4166/#review13745 --- On Nov. 11, 2014, 3:37 p.m., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [asterisk-dev] [Code Review] 4166: testsuite: tests/bridge/bridge_action leaves a channel open

2014-11-13 Thread Corey Farrell
On Nov. 13, 2014, 11:30 a.m., Mark Michelson wrote: With the fix being made to the leaked bridge in Asterisk, is this change still required? Does hanging up self.channels[1] not result in self.channels[3] and the bridge being destroyed as expected? Corey Farrell wrote: Still

Re: [asterisk-dev] [Code Review] 4151: Fix compiler error when using ./configure --enable-dev-mode --enable-coverage

2014-11-12 Thread Corey Farrell
with these options now works in Linux Mint 17 (gcc 4.8.2-19ubuntu1). Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options

Re: [asterisk-dev] [Code Review] 4160: chan_sip: Fix theoretical leak of p-refer

2014-11-12 Thread Corey Farrell
://reviewboard.asterisk.org/r/4160/diff/ Testing (updated) --- tests/channels/SIP against 11 Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 4159: chan_sip: Add missing braces on if, else, while and for

2014-11-11 Thread Corey Farrell
/ Testing --- Compiled, visually inspected. Ran all of tests/channel/SIP in testsuite. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

Re: [asterisk-dev] [Code Review] 4160: chan_sip: Fix theoretical leak of p-refer

2014-11-11 Thread Corey Farrell
, 2014, 1:25 a.m., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4160/ --- (Updated Nov. 10, 2014, 1:25 a.m

[asterisk-dev] [Code Review] 4166: testsuite: tests/bridge/bridge_action leaves a channel open

2014-11-11 Thread Corey Farrell
Diff: https://reviewboard.asterisk.org/r/4166/diff/ Testing --- Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options

[asterisk-dev] [Code Review] 4170: testsuite: Delete bridges on completion for a bunch of rest_api tests

2014-11-11 Thread Corey Farrell
/tests/rest_api/applications/subscribe-bridge/subscribe_bridge.py 5920 Diff: https://reviewboard.asterisk.org/r/4170/diff/ Testing --- Against 13 Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 4151: Fix compiler error when using ./configure --enable-dev-mode --enable-coverage

2014-11-09 Thread Corey Farrell
to svn:ignore for the following folders: apps/confbridge/ codecs/ilbc/ codecs/speex/ tests/ - Corey Farrell On Nov. 8, 2014, 1:29 p.m., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https

[asterisk-dev] [Code Review] 4159: chan_sip: Add missing braces on if, else, while and for

2014-11-09 Thread Corey Farrell
. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 4160: chan_sip: Fix theoretical leak of p-refer

2014-11-09 Thread Corey Farrell
this fix low risk. The change is slightly different in 12+, as p-refer-refer_call only exists in 11. Diffs - /branches/11/channels/chan_sip.c 427666 Diff: https://reviewboard.asterisk.org/r/4160/diff/ Testing --- Compiled, visual inspection. Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 4151: Fix compiler error when using ./configure --enable-dev-mode --enable-coverage

2014-11-08 Thread Corey Farrell
On Nov. 6, 2014, 6:04 a.m., wdoekes wrote: Isn't the better fix to disable coverage for the shadow compilation? Corey Farrell wrote: Probably. I have updated code but I won't have time to test until this weekend. I'll update the review once I've had a chance to do some builds

Re: [asterisk-dev] [Code Review] 4152: chan_console: Fix reference leaks to pvt

2014-11-08 Thread Corey Farrell
/diff/ Testing --- No. Visually inspected changes, they are straight forward. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

Re: [asterisk-dev] [Code Review] 4151: Fix compiler error when using ./configure --enable-dev-mode --enable-coverage

2014-11-08 Thread Corey Farrell
/diff/ Testing --- Build with these options now works in Linux Mint 17 (gcc 4.8.2-19ubuntu1). Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 4153: manager: HTTP connections leak references

2014-11-08 Thread Corey Farrell
). Diffs - /branches/11/main/manager.c 427380 Diff: https://reviewboard.asterisk.org/r/4153/diff/ Testing --- tests/manager/config/basic against 13. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

2014-11-06 Thread Corey Farrell
/lab_stringfields_leak.c to verify that old pools are now freed. Full testsuite against Asterisk 13. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 4150: res_hep: fix major leak that occurs when config is missing or enabled=no

2014-11-06 Thread Corey Farrell
- /branches/13/res/res_hep.c 427298 Diff: https://reviewboard.asterisk.org/r/4150/diff/ Testing --- Tested by Zane Conkle. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

[asterisk-dev] [Code Review] 4151: Fix compiler error when using ./configure --enable-dev-mode --enable-coverage

2014-11-06 Thread Corey Farrell
4.8.2-19ubuntu1). Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

[asterisk-dev] [Code Review] 4152: chan_console: Fix reference leaks to pvt

2014-11-06 Thread Corey Farrell
/queue_baseline/run_1/ast1/var/log/asterisk/refs.txt Diffs - /branches/11/channels/chan_console.c 427380 Diff: https://reviewboard.asterisk.org/r/4152/diff/ Testing --- No. Visually inspected changes, they are straight forward. Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 4152: chan_console: Fix reference leaks to pvt

2014-11-06 Thread Corey Farrell
, they are straight forward. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4151: Fix compiler error when using ./configure --enable-dev-mode --enable-coverage

2014-11-06 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4151/#review13701 --- On Nov. 6, 2014, 5:06 a.m., Corey Farrell wrote

[asterisk-dev] [Code Review] 4153: manager: HTTP connections leak references

2014-11-06 Thread Corey Farrell
/basic against 13. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] [Code Review] 4149: main/file.c: fix possible extra ast_module_unref to format modules

2014-11-06 Thread Corey Farrell
. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix audio failure caused by certain masquerade's

2014-11-05 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3603/#review13685 --- On Oct. 30, 2014, 8:06 p.m., Corey Farrell wrote

Re: [asterisk-dev] [Code Review] 4140: res_http_websockets: Module reference decrease below zero

2014-11-04 Thread Corey Farrell
the echo protocol, but ast_websocket_remove_protocol is used to remove it. This causes an extra call to ast_module_unref. Diffs - /branches/12/res/res_http_websocket.c 426831 Diff: https://reviewboard.asterisk.org/r/4140/diff/ Testing --- Found/tested with r4141. Thanks, Corey

Re: [asterisk-dev] [Code Review] 4143: testsuite: Close HTTP connections when test is complete to prevent reported leaks in tests/phoneprov/res_phoneprov and tests/manager/config

2014-11-04 Thread Corey Farrell
it but that test is disabled per ASTERISK-19565. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

[asterisk-dev] [Code Review] 4149: main/file.c: fix possible extra ast_module_unref to format modules

2014-11-04 Thread Corey Farrell
/file.c 427255 Diff: https://reviewboard.asterisk.org/r/4149/diff/ Testing --- Verified the issue and fix with tests/apps/voicemail/play_message + r4141. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided

[asterisk-dev] [Code Review] 4150: res_hep: fix major leak that occurs when config is missing or enabled=no

2014-11-04 Thread Corey Farrell
://issues.asterisk.org/jira/browse/ASTERISK-24491 Repository: Asterisk Description --- Add missing unref to hepv3_send_packet. Diffs - /branches/13/res/res_hep.c 427298 Diff: https://reviewboard.asterisk.org/r/4150/diff/ Testing --- Tested by Zane Conkle. Thanks, Corey

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

2014-11-03 Thread Corey Farrell
Asterisk 13. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

2014-11-03 Thread Corey Farrell
generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4114/#review13628 --- On Nov. 3, 2014, 8:29 a.m., Corey Farrell wrote: --- This is an automatically generated e

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

2014-11-03 Thread Corey Farrell
Asterisk 13. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

2014-11-03 Thread Corey Farrell
Asterisk 13. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

2014-11-03 Thread Corey Farrell
generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4114/#review13658 --- On Nov. 3, 2014, 12:55 p.m., Corey Farrell wrote: --- This is an automatically generated e

[asterisk-dev] [Code Review] 4141: Enable REF_DEBUG for ast_module_ref / ast_module_unref

2014-11-02 Thread Corey Farrell
Diff: https://reviewboard.asterisk.org/r/4141/diff/ Testing --- Using tests/manager/originate with REF_DEBUG enabled. When the change to bridge_builtin_features.c is omitted the test fails due to that one reference leak. Thanks, Corey Farrell

[asterisk-dev] [Code Review] 4140: res_http_websockets: Module reference decrease below zero

2014-11-02 Thread Corey Farrell
- /branches/12/res/res_http_websocket.c 426831 Diff: https://reviewboard.asterisk.org/r/4140/diff/ Testing --- Found/tested with r4141. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api

[asterisk-dev] Fwd: [asterisk-commits] mjordan: branch 12 r426995 - /branches/12/res/res_stasis.c

2014-11-02 Thread Corey Farrell
If it's possible for apps_registry to be NULL then it's possible for the condition to race. Maybe we need to use AO2_GLOBAL_OBJ_STATIC? Could this issue apply to the other global containers in this module (app_controls, app_bridges, app_bridges_moh, app_bridges_playback)? -- Forwarded

Re: [asterisk-dev] [Code Review] 4128: func_jitterbuffer: fix frame leaks

2014-11-02 Thread Corey Farrell
--- tests/funcs/func_jitterbuffer against 13 no longer leaks. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4138: main/app.c, app_voicemail: Fix ast_writestream leaks

2014-11-02 Thread Corey Farrell
, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 4142: func_talkdetect: Fix stasis message leak in audiohook callback

2014-11-02 Thread Corey Farrell
no longer leaks - tested against 13. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

[asterisk-dev] [Code Review] 4143: testsuite: Close HTTP connections when test is complete to prevent reported leaks in tests/phoneprov/res_phoneprov and tests/manager/config

2014-11-02 Thread Corey Farrell
/ Testing --- Against 13, tests passed with no leaks reported. Verified no other active test uses syncami. Only tests/channels/SIP/nat_supertest used it but that test is disabled per ASTERISK-19565. Thanks, Corey Farrell

[asterisk-dev] [Code Review] 4144: testsuite: Sort tests by name after loading

2014-11-02 Thread Corey Farrell
/r/4144/diff/ Testing --- Yes Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 4138: main/app.c, app_voicemail: Fix ast_writestream leaks

2014-10-31 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4138/#review13647 --- On Oct. 31, 2014, 1:26 a.m., Corey Farrell wrote

Re: [asterisk-dev] [Code Review] 4138: main/app.c, app_voicemail: Fix ast_writestream leaks

2014-10-31 Thread Corey Farrell
ast_writestream is slightly over 64k. Diffs (updated) - /branches/11/main/app.c 426569 /branches/11/apps/app_voicemail.c 426569 Diff: https://reviewboard.asterisk.org/r/4138/diff/ Testing --- tests/apps/voicemail/check_voicemail_forward_with_prepend/ no longer leaks. Thanks, Corey

Re: [asterisk-dev] [Code Review] 4128: func_jitterbuffer: fix frame leaks

2014-10-31 Thread Corey Farrell
/func_jitterbuffer.c. Diffs (updated) - /branches/11/main/abstract_jb.c 426593 /branches/11/funcs/func_jitterbuffer.c 426593 Diff: https://reviewboard.asterisk.org/r/4128/diff/ Testing --- tests/funcs/func_jitterbuffer against 13 no longer leaks. Thanks, Corey Farrell

Re: [asterisk-dev] [Code Review] 4122: testsuite: Fix freeze on tests/pbx/dialplan_reload

2014-10-31 Thread Corey Farrell
from 300 to 30, use reset_timeout instead. Diffs - /asterisk/trunk/tests/pbx/dialplan_reload/run-test 5803 Diff: https://reviewboard.asterisk.org/r/4122/diff/ Testing --- Yes Thanks, Corey Farrell

[asterisk-dev] Fwd: [asterisk-commits] mjordan: testsuite/asterisk/trunk r5811 - in /asterisk/trunk/tests/fax/pjsip:...

2014-10-30 Thread Corey Farrell
I'm confused about how this can be? Unless I'm missing something a module dependency doesn't effect how the test runs, just if it runs. If chan_sip is not required then shouldn't we remove sip.conf from each of these tests config dirs? -- Forwarded message -- From: SVN commits to

Re: [asterisk-dev] [Code Review] 4124: audiohooks: Clean references to formats

2014-10-30 Thread Corey Farrell
].format in ast_audiohook_detach_list. Diffs - /branches/13/main/audiohook.c 426528 Diff: https://reviewboard.asterisk.org/r/4124/diff/ Testing --- Yes Thanks, Corey Farrell -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 4121: testsuite: Close ARI websocket connections before stopping reactor

2014-10-30 Thread Corey Farrell
/trunk/lib/python/asterisk/ari.py 5796 Diff: https://reviewboard.asterisk.org/r/4121/diff/ Testing --- Using r4038 Thanks, Corey Farrell -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk

Re: [asterisk-dev] [Code Review] 4125: app_queue: fix a couple leaks to struct call_queue in set_member_value

2014-10-30 Thread Corey Farrell
/ Testing --- All tests/queues/set_penalty no longer leaks any references (verifies first added queue_unref). I'm unsure if the second added queue_unref has been tested, but seems like it is needed. Thanks, Corey Farrell

[asterisk-dev] [Code Review] 4128: func_jitterbuffer: fix frame leaks

2014-10-30 Thread Corey Farrell
- /branches/11/funcs/func_jitterbuffer.c 426593 Diff: https://reviewboard.asterisk.org/r/4128/diff/ Testing --- tests/funcs/func_jitterbuffer against 13 no longer leaks. Thanks, Corey Farrell -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix audio failure caused by certain masquerade's

2014-10-30 Thread Corey Farrell
/func_jitterbuffer.c 426593 Diff: https://reviewboard.asterisk.org/r/3603/diff/ Testing (updated) --- Verified the scenario outlined in ASTERISK-22409 no longer experiences audio quality loss. Thanks, Corey Farrell

[asterisk-dev] func_jitterbuffer handling of masquerades

2014-10-30 Thread Corey Farrell
Hello everyone, Review 3063 [1] is posted to address audio quality failure experienced when certain masquerades occur on a channel with func_jitterbuffer active. The goal of this change is to address situations where a masquerade occurs due to Local channel optimization, and one or both of the

Re: [asterisk-dev] [Code Review] 4128: func_jitterbuffer: fix frame leaks

2014-10-30 Thread Corey Farrell
/func_jitterbuffer. - Corey --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4128/#review13639 --- On Oct. 30, 2014, 8:06 p.m., Corey Farrell

<    1   2   3   4   5   6   7   >