Re: [asterisk-dev] [Code Review] 4613: clang compiler warning: clang compilation

2015-04-20 Thread Diederik de Groot
managing the clang fixup patches much easier. Diederik de Groot wrote: Hi Matt, Thanks for the heads up. Will make the move to Git + Gerrit. From what i read on the mailinglist posts i though you were still experimenting. I guess I missed the final move announcement

Re: [asterisk-dev] [Code Review] 4613: clang compiler warning: clang compilation

2015-04-20 Thread Diederik de Groot
--- On April 20, 2015, 12:38 p.m., Diederik de Groot wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4613

Re: [asterisk-dev] [Code Review] 4613: clang compiler warning: clang compilation

2015-04-20 Thread Diederik de Groot
-]: pbx.c:11319 int pbx_builtin_background(struct ast_channel *, const char *): ast_streamfile failed on Message/ast_msg_queue for demo-congrats Repeated Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 4613: clang compiler warning: clang compilation

2015-04-20 Thread Diederik de Groot
(struct ast_channel *, const char *): ast_streamfile failed on Message/ast_msg_queue for demo-congrats Repeated Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 4547: clang compiler warning: braces-around-scalar-initializer

2015-04-18 Thread Diederik de Groot
.c 433444 /branches/13/channels/chan_dahdi.c 433444 /branches/13/channels/chan_console.c 433444 /branches/13/channels/chan_alsa.c 433444 /branches/13/apps/app_dictate.c 433444 Diff: https://reviewboard.asterisk.org/r/4547/diff/ Testing --- Thanks, Diederik de Groot

[asterisk-dev] [Code Review] 4613: clang compiler warning: clang compilation

2015-04-18 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4613/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4546: clang compiler warning: -Warray-bounds

2015-04-18 Thread Diederik de Groot
helpfull in finding corner-case bugs. clang compiler warning:-Warray-bounds Diffs - /branches/13/configure.ac 433444 Diff: https://reviewboard.asterisk.org/r/4546/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4543: clang compiler warning: RAII-clang reentrancy / Updating variable from inside a _block

2015-04-18 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4543/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 4550: clang compiler warning: --dev-mode and -Wparentheses-equality

2015-04-18 Thread Diederik de Groot
/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] [Code Review] 4613: clang compiler warning: clang compilation

2015-04-18 Thread Diederik de Groot
char *): ast_streamfile failed on Message/ast_msg_queue for demo-congrats Repeated Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-04-18 Thread Diederik de Groot
/2015/03/28/83f2f382-9ef2-41cf-8e7a-c188c014c17e__make.report Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-04-11 Thread Diederik de Groot
(except /main/stdtime) https://reviewboard.asterisk.org/media/uploaded/files/2015/03/29/4a17471b-4952-43cd-b015-92d00da2338b__tests.xml Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 4550: clang compiler warning: --dev-mode and -Wparentheses-equality

2015-04-09 Thread Diederik de Groot
to help avoid. It appears that the warning is intended to get rid of extra parentheses where they are unnecessary. The problem is that I don't see anything wrong with having them there, especially in macro definitions. Diederik de Groot wrote: Ok you know that to prevent an unintendet

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-04-09 Thread Diederik de Groot
: https://reviewboard.asterisk.org/r/4533/diff/ Testing --- Compiles without warning Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 4547: clang compiler warning: braces-around-scalar-initializer

2015-04-09 Thread Diederik de Groot
stretch. :-( Interestingly, when compiling with clang 3.4, I don't get this warning issued. What version are you compiling with? And what do you think about simply ignoring this warning? Diederik de Groot wrote: Using struct ast_frame f = { 0, }; is perfectly

Re: [asterisk-dev] [Code Review] 4543: clang compiler warning: RAII-clang reentrancy / Updating variable from inside a _block

2015-04-09 Thread Diederik de Groot
On March 29, 2015, 5:01 a.m., Diederik de Groot wrote: /branches/13/configure.ac, line 389 https://reviewboard.asterisk.org/r/4543/diff/6/?file=73280#file73280line389 move the raii compiler checks to their own m4 file and called the checking function a little earlier

Re: [asterisk-dev] [Code Review] 4541: clang compiler warning: -Wpointer-bool-conversion

2015-04-08 Thread Diederik de Groot
/branches/13/apps/app_queue.c 433444 /branches/13/apps/app_minivm.c 433444 Diff: https://reviewboard.asterisk.org/r/4541/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 4541: clang compiler warning: -Wpointer-bool-conversion

2015-04-07 Thread Diederik de Groot
On April 7, 2015, 3:05 a.m., rmudgett wrote: /branches/13/apps/app_minivm.c, line 1842 https://reviewboard.asterisk.org/r/4541/diff/3/?file=73407#file73407line1842 Missing the ! if (!ast_strlen_zero()) Diederik de Groot wrote: Thanks again for checking my stuff

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-04-07 Thread Diederik de Groot
, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4541: clang compiler warning: -Wpointer-bool-conversion

2015-04-07 Thread Diederik de Groot
433444 /branches/13/apps/app_minivm.c 433444 Diff: https://reviewboard.asterisk.org/r/4541/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 4541: clang compiler warning: -Wpointer-bool-conversion

2015-04-07 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4541/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-04-07 Thread Diederik de Groot
the compiler without changing the binary value. Diederik de Groot wrote: CurlOption is a positive enum though. So the warning about it not being allowed to be negative remains, won't it ? BTW: I made a typo while changing this one I was meaning to set it to: #define

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-04-07 Thread Diederik de Groot
/branches/13/include/asterisk/app.h 433444 /branches/13/funcs/func_curl.c 433444 /branches/13/channels/pjsip/dialplan_functions.c 433444 /branches/13/channels/chan_skinny.c 433444 Diff: https://reviewboard.asterisk.org/r/4533/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4540: clang compiler warning: -Wformat

2015-04-06 Thread Diederik de Groot
instead of %hu Diffs - /branches/13/main/framehook.c 433444 Diff: https://reviewboard.asterisk.org/r/4540/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 4541: clang compiler warning: -Wpointer-bool-conversion

2015-04-06 Thread Diederik de Groot
. - Diederik --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4541/#review15081 --- On April 7, 2015, 4:23 a.m., Diederik de Groot wrote

Re: [asterisk-dev] [Code Review] 4551: clang compiler warning: -Wnon-literal-null-conversion

2015-04-06 Thread Diederik de Groot
Diff: https://reviewboard.asterisk.org/r/4551/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 4552: clang compiler warning: -Wsometimes-uninitialized

2015-04-06 Thread Diederik de Groot
/ errors during compilation, some of which can be very helpfull in finding corner-case bugs. clang compiler warning:-Wsometimes-uninitialized Diffs - /branches/13/funcs/func_math.c 433444 Diff: https://reviewboard.asterisk.org/r/4552/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-04-03 Thread Diederik de Groot
/uploaded/files/2015/03/28/83f2f382-9ef2-41cf-8e7a-c188c014c17e__make.report Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-04-03 Thread Diederik de Groot
On April 3, 2015, 11:36 p.m., rmudgett wrote: This is still a nuisance warning that doesn't add much value for the effort. Diederik de Groot wrote: We can drop it no problem. I still think it could be useful in detecting _ref/_unref issues, alas it would quite a bit of work

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-04-03 Thread Diederik de Groot
https://reviewboard.asterisk.org/media/uploaded/files/2015/03/28/83f2f382-9ef2-41cf-8e7a-c188c014c17e__make.report Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-04-03 Thread Diederik de Groot
-c188c014c17e__make.report Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-04-03 Thread Diederik de Groot
On April 4, 2015, 12:40 a.m., rmudgett wrote: /branches/13/channels/chan_iax2.c, lines 2009-2013 https://reviewboard.asterisk.org/r/4554/diff/2/?file=73276#file73276line2009 This change causes bugs. It is supposed to return peer because it increased the ref. Diederik de Groot

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-04-03 Thread Diederik de Groot
On April 3, 2015, 11:36 p.m., rmudgett wrote: This is still a nuisance warning that doesn't add much value for the effort. Diederik de Groot wrote: We can drop it no problem. I still think it could be useful in detecting _ref/_unref issues, alas it would quite a bit of work

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread Diederik de Groot
/branches/13/include/asterisk/app.h 433444 /branches/13/funcs/func_curl.c 433444 /branches/13/channels/pjsip/dialplan_functions.c 433444 /branches/13/channels/chan_skinny.c 433444 Diff: https://reviewboard.asterisk.org/r/4533/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread Diederik de Groot
/branches/13/include/asterisk/app.h 433444 /branches/13/funcs/func_curl.c 433444 /branches/13/channels/pjsip/dialplan_functions.c 433444 /branches/13/channels/chan_skinny.c 433444 Diff: https://reviewboard.asterisk.org/r/4533/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/#review15013 --- On April 1, 2015, 4:52 a.m., Diederik de Groot wrote

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-31 Thread Diederik de Groot
-4952-43cd-b015-92d00da2338b__tests.xml Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-31 Thread Diederik de Groot
, no callers currently care about the return value. You changed this because clang had a problem in test_semi1() in tests/test_strings.c. There is a better way. Diederik de Groot wrote: Actually as i tried to mention in the description i changed this according to the tests being

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-03-31 Thread Diederik de Groot
/4554/#review14999 --- On March 29, 2015, 1:44 a.m., Diederik de Groot wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4554

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-31 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4555/#review15000 --- On April 1, 2015, 3:30 a.m., Diederik de Groot wrote

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-31 Thread Diederik de Groot
-4952-43cd-b015-92d00da2338b__tests.xml Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/#review15003 --- On March 30, 2015, 1:08 p.m., Diederik de Groot wrote

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-31 Thread Diederik de Groot
-4952-43cd-b015-92d00da2338b__tests.xml Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4550: clang compiler warning: --dev-mode and -Wparentheses-equality

2015-03-31 Thread Diederik de Groot
433444 /branches/13/main/astobj2_hash.c 433444 /branches/13/include/asterisk/vector.h 433444 /branches/13/include/asterisk/linkedlists.h 433444 /branches/13/include/asterisk/dlinkedlists.h 433444 Diff: https://reviewboard.asterisk.org/r/4550/diff/ Testing --- Thanks, Diederik de

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-31 Thread Diederik de Groot
-4952-43cd-b015-92d00da2338b__tests.xml Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread Diederik de Groot
--- On April 1, 2015, 3:59 a.m., Diederik de Groot wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread Diederik de Groot
/branches/13/include/asterisk/app.h 433444 /branches/13/funcs/func_curl.c 433444 /branches/13/channels/pjsip/dialplan_functions.c 433444 /branches/13/channels/chan_skinny.c 433444 Diff: https://reviewboard.asterisk.org/r/4533/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4541: clang compiler warning: -Wpointer-bool-conversion

2015-03-31 Thread Diederik de Groot
-mail. To reply, visit: https://reviewboard.asterisk.org/r/4541/#review14978 --- On March 31, 2015, 6:05 p.m., Diederik de Groot wrote: --- This is an automatically generated e-mail

Re: [asterisk-dev] [Code Review] 4541: clang compiler warning: -Wpointer-bool-conversion

2015-03-31 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4541/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4550: clang compiler warning: --dev-mode and -Wparentheses-equality

2015-03-31 Thread Diederik de Groot
to help avoid. It appears that the warning is intended to get rid of extra parentheses where they are unnecessary. The problem is that I don't see anything wrong with having them there, especially in macro definitions. Diederik de Groot wrote: Ok you know that to prevent an unintendet

Re: [asterisk-dev] [Code Review] 4550: clang compiler warning: --dev-mode and -Wparentheses-equality

2015-03-31 Thread Diederik de Groot
to help avoid. It appears that the warning is intended to get rid of extra parentheses where they are unnecessary. The problem is that I don't see anything wrong with having them there, especially in macro definitions. Diederik de Groot wrote: Ok you know that to prevent an unintendet

Re: [asterisk-dev] [Code Review] 4550: clang compiler warning: --dev-mode and -Wparentheses-equality

2015-03-31 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4550/#review14987 --- On March 29, 2015, 7:14 p.m., Diederik de Groot wrote

Re: [asterisk-dev] [Code Review] 4541: clang compiler warning: -Wpointer-bool-conversion

2015-03-31 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4541/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-30 Thread Diederik de Groot
/branches/13/include/asterisk/app.h 433444 /branches/13/funcs/func_curl.c 433444 /branches/13/channels/pjsip/dialplan_functions.c 433444 /branches/13/channels/chan_skinny.c 433444 Diff: https://reviewboard.asterisk.org/r/4533/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4551: clang compiler warning: -Wnon-literal-null-conversion

2015-03-30 Thread Diederik de Groot
warning:-Wnon-literal-null-conversion Diffs (updated) - /branches/13/res/stasis_recording/stored.c 433444 /branches/13/channels/chan_skinny.c 433444 /branches/13/channels/chan_sip.c 433444 Diff: https://reviewboard.asterisk.org/r/4551/diff/ Testing --- Thanks, Diederik de

Re: [asterisk-dev] [Code Review] 4535: clang compiler warning: -Wenum-conversion

2015-03-29 Thread Diederik de Groot
433444 /branches/13/channels/chan_pjsip.c 433444 Diff: https://reviewboard.asterisk.org/r/4535/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 4525: clang compiler warning: -Wabsolute-value

2015-03-29 Thread Diederik de Groot
/branches/13/main/jitterbuf.c 433444 /branches/13/channels/sip/dialplan_functions.c 433444 /branches/13/channels/chan_iax2.c 433444 /branches/13/apps/app_queue.c 433444 Diff: https://reviewboard.asterisk.org/r/4525/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4530: clang compiler warning: -Wgnu-variable-sized-type-not-at-end

2015-03-29 Thread Diederik de Groot
, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4545: clang compiler warning: -Wunused-command-line-argument

2015-03-29 Thread Diederik de Groot
/ errors during compilation, some of which can be very helpfull in finding corner-case bugs. clang compiler warning:-Wunused-command-line-argument Diffs - /branches/13/Makefile.rules 433444 Diff: https://reviewboard.asterisk.org/r/4545/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4530: clang compiler warning: -Wgnu-variable-sized-type-not-at-end

2015-03-29 Thread Diederik de Groot
. To reply, visit: https://reviewboard.asterisk.org/r/4530/#review14961 --- On March 30, 2015, 3:52 a.m., Diederik de Groot wrote: --- This is an automatically generated e-mail

Re: [asterisk-dev] [Code Review] 4543: clang compiler warning: RAII-clang reentrancy / Updating variable from inside a _block

2015-03-29 Thread Diederik de Groot
Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4550: clang compiler warning: --dev-mode and -Wparentheses-equality

2015-03-29 Thread Diederik de Groot
/branches/13/include/asterisk/vector.h 433444 /branches/13/include/asterisk/linkedlists.h 433444 /branches/13/include/asterisk/dlinkedlists.h 433444 Diff: https://reviewboard.asterisk.org/r/4550/diff/ Testing --- Thanks, Diederik de Groot

[asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-29 Thread Diederik de Groot
/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-29 Thread Diederik de Groot
blows up/crashes when running ast_alloca(0) (ie:__builtin_alloca(0)) possible solutions: - report issue to clang / llvm - add check to ast_alloca and enforce return value on error - or make sure we don't call ast_alloca with a size of 0 ever. - Diederik de Groot On March 29

Re: [asterisk-dev] [Code Review] 4550: clang compiler warning: --dev-mode and -Wparentheses-equality

2015-03-29 Thread Diederik de Groot
/branches/13/include/asterisk/dlinkedlists.h 433444 Diff: https://reviewboard.asterisk.org/r/4550/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-29 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4555/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-29 Thread Diederik de Groot
https://reviewboard.asterisk.org/r/4555/#comment25576 Woops. Debugging remnant, should not have been here. - Diederik de Groot On March 29, 2015, 7:24 p.m., Diederik de Groot wrote: --- This is an automatically generated e-mail

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-29 Thread Diederik de Groot
/branches/13/include/asterisk/app.h 433444 /branches/13/funcs/func_curl.c 433444 /branches/13/channels/pjsip/dialplan_functions.c 433444 /branches/13/channels/chan_skinny.c 433444 Diff: https://reviewboard.asterisk.org/r/4533/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-29 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4555/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-29 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4555/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-29 Thread Diederik de Groot
(except /main/stdtime) https://reviewboard.asterisk.org/media/uploaded/files/2015/03/29/4a17471b-4952-43cd-b015-92d00da2338b__tests.xml Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-29 Thread Diederik de Groot
(except /main/stdtime) https://reviewboard.asterisk.org/media/uploaded/files/2015/03/29/4a17471b-4952-43cd-b015-92d00da2338b__tests.xml Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-29 Thread Diederik de Groot
(as suggested by the tests), then this should be checked and not raise a problem in the assert - Diederik de Groot On March 30, 2015, 12:43 a.m., Diederik de Groot wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-03-29 Thread Diederik de Groot
/stdtime) https://reviewboard.asterisk.org/media/uploaded/files/2015/03/29/4a17471b-4952-43cd-b015-92d00da2338b__tests.xml Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

[asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-03-28 Thread Diederik de Groot
- /branches/13/include/asterisk/stringfields.h 433444 /branches/13/channels/iax2/parser.c 433444 /branches/13/channels/chan_iax2.c 433444 /branches/13/apps/app_agent_pool.c 433444 Diff: https://reviewboard.asterisk.org/r/4554/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-03-28 Thread Diederik de Groot
/83f2f382-9ef2-41cf-8e7a-c188c014c17e__make.report Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-03-28 Thread Diederik de Groot
On March 29, 2015, 1:49 a.m., Diederik de Groot wrote: The fixes for unused-value to chan_iax2, to compile smoothly should be seen as a showcase that this can be off potential benefit. Would have been nice if ao2_ref(..., -1) would have behaved in the same way, so that ao2_ref(..., -1

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-03-28 Thread Diederik de Groot
Attachments ASTCFLAGS=-Wno-error=unused-value make | grep [-W -B1 -A2 https://reviewboard.asterisk.org/media/uploaded/files/2015/03/28/83f2f382-9ef2-41cf-8e7a-c188c014c17e__make.report Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-03-28 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4554/#comment25570 function is being called with (peer = 0x0), which showed up after messing with the code above. Either this is a real issue, or caused by fiddling with the code. - Diederik de Groot On March 29, 2015, 1:44 a.m., Diederik de Groot wrote

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-03-28 Thread Diederik de Groot
, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4543: clang compiler warning: RAII-clang reentrancy / Updating variable from inside a _block

2015-03-28 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4543/#comment25573 Added a simple script to contrib, to show how to perform a scan-build using clang/llvm-gcc which uses the extensive llvm static analyzer. An html report will be generated in the created scanbuild-output subdirectory - Diederik de Groot On March 29, 2015, 5:01

Re: [asterisk-dev] [Code Review] 4543: clang compiler warning: RAII-clang reentrancy / Updating variable from inside a _block

2015-03-28 Thread Diederik de Groot
/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4543: clang compiler warning: RAII-clang reentrancy / Updating variable from inside a _block

2015-03-28 Thread Diederik de Groot
/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4543: clang compiler warning: RAII-clang reentrancy / Updating variable from inside a _block

2015-03-28 Thread Diederik de Groot
process - Diederik de Groot On March 29, 2015, 4:57 a.m., Diederik de Groot wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4543

Re: [asterisk-dev] [Code Review] 4543: clang compiler warning: RAII-clang reentrancy / Updating variable from inside a _block

2015-03-28 Thread Diederik de Groot
/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

2015-03-28 Thread Diederik de Groot
that where needed in chan_iax2.c and apps/app_agent_pool.c. Some others a less interesting, for example the SCHED_DEL fixes. Will wait for you guys to respond, before continuing. Will needs some more people to finish the '-Wunused-value' task, would be way to much for one person. - Diederik de Groot

Re: [asterisk-dev] [Code Review] 4539: clang compiler warning: -Winitializer-overrides

2015-03-28 Thread Diederik de Groot
://reviewboard.asterisk.org/r/4539/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4531: clang compiler warning: -Wparentheses-equality

2015-03-28 Thread Diederik de Groot
/branches/13/res/Makefile 433444 /branches/13/main/channel.c 433444 /branches/13/apps/app_voicemail.c 433444 /branches/13/apps/app_dictate.c 433444 Diff: https://reviewboard.asterisk.org/r/4531/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4526: clang compiler warning: -Wunused-value -Wunused-variable -Wunused-const-variable

2015-03-28 Thread Diederik de Groot
/chan_pjsip.c 433444 /branches/13/cel/cel_sqlite3_custom.c 433444 /branches/13/apps/app_queue.c 433444 Diff: https://reviewboard.asterisk.org/r/4526/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4546: clang compiler warning: -Warray-bounds

2015-03-28 Thread Diederik de Groot
On March 28, 2015, 1:28 p.m., Diederik de Groot wrote: /branches/13/configure.ac, lines 1179-1183 https://reviewboard.asterisk.org/r/4546/diff/2/?file=73163#file73163line1179 Test is not working as i hoped yet. Tests inside configure don't seem to get optimized to the same level

Re: [asterisk-dev] [Code Review] 4546: clang compiler warning: -Warray-bounds

2015-03-28 Thread Diederik de Groot
/autoconfig.h.in - Diederik de Groot On March 28, 2015, 3:01 p.m., Diederik de Groot wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4546

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-28 Thread Diederik de Groot
/dialplan_functions.c 433444 Diff: https://reviewboard.asterisk.org/r/4533/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-28 Thread Diederik de Groot
/utils.h 433444 /branches/13/include/asterisk/cel.h 433444 /branches/13/include/asterisk/app.h 433444 /branches/13/funcs/func_curl.c 433444 /branches/13/channels/pjsip/dialplan_functions.c 433444 Diff: https://reviewboard.asterisk.org/r/4533/diff/ Testing --- Thanks, Diederik de

Re: [asterisk-dev] [Code Review] 4546: clang compiler warning: -Warray-bounds

2015-03-28 Thread Diederik de Groot
the optimized macro version instead. - Diederik de Groot On March 27, 2015, 6:59 p.m., Diederik de Groot wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4546

Re: [asterisk-dev] [Code Review] 4546: clang compiler warning: -Warray-bounds

2015-03-28 Thread Diederik de Groot
warning:-Warray-bounds Diffs (updated) - /branches/13/configure.ac 433444 Diff: https://reviewboard.asterisk.org/r/4546/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] [Code Review] 4546: clang compiler warning: -Warray-bounds

2015-03-28 Thread Diederik de Groot
/4546/#comment25547 Test is not working as i hoped yet. Tests inside configure don't seem to get optimized to the same level (-O3), making this test somewhat useless. Trying to find out how to get the same behaviour as wenn running make. - Diederik de Groot On March 28, 2015, 12:14 p.m

Re: [asterisk-dev] [Code Review] 4546: clang compiler warning: -Warray-bounds

2015-03-28 Thread Diederik de Groot
warning:-Warray-bounds Diffs (updated) - /branches/13/configure.ac 433444 Diff: https://reviewboard.asterisk.org/r/4546/diff/ Testing --- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] [Code Review] 4527: clang compiler warning: -Wunused-function

2015-03-28 Thread Diederik de Groot
anywhere Diffs - /branches/13/main/dsp.c 433444 /branches/13/main/config.c 433470 /branches/13/channels/chan_iax2.c 433444 Diff: https://reviewboard.asterisk.org/r/4527/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4537: clang compiler warning: -Wbitfield-constant-conversion

2015-03-28 Thread Diederik de Groot
] fr-outoforder = -1; Changed to fr-outoforder = 1; Diffs - /branches/13/channels/chan_iax2.c 433444 Diff: https://reviewboard.asterisk.org/r/4537/diff/ Testing --- Thanks, Diederik de Groot

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

2015-03-28 Thread Diederik de Groot
--- Thanks, Diederik de Groot -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk

  1   2   >