[asterisk-dev] Change in testsuite[master]: python/asterisk/version: Update version handling for Git mig...

2015-04-14 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: python/asterisk/version: Update version handling for Git migration .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/91 To

[asterisk-dev] Change in testsuite[master]: pjsip/options: Add tests for qualify_timeout and max_initia...

2015-04-13 Thread George Joseph (Code Review)
George Joseph has uploaded a new patch set (#2). Change subject: pjsip/options: Add tests for qualify_timeout and max_initial_qualify_time .. pjsip/options: Add tests for qualify_timeout and max_initial_qualify_time Renamed

[asterisk-dev] Change in testsuite[master]: pjsip/options: Add tests for qualify_timeout and max_initia...

2015-04-13 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/92 Change subject: pjsip/options: Add tests for qualify_timeout and max_initial_qualify_time .. pjsip/options: Add tests for qualify_timeout

[asterisk-dev] Change in asterisk[13]: pjsip_options: Add qualify_timeout processing and eventing

2015-04-13 Thread George Joseph (Code Review)
George Joseph has uploaded a new patch set (#2). Change subject: pjsip_options: Add qualify_timeout processing and eventing .. pjsip_options: Add qualify_timeout processing and eventing This is the second follow-on to

[asterisk-dev] Change in asterisk[12]: Add .gitignore and .gitreview files

2015-04-13 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/81 Change subject: Add .gitignore and .gitreview files .. Add .gitignore and .gitreview files Add the .gitignore and .gitreview files to the

[asterisk-dev] Change in asterisk[1.8]: main/editline: Add .gitignore.

2015-04-13 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/84 Change subject: main/editline: Add .gitignore. .. main/editline: Add .gitignore. This patch adds a .gitignore for main/editline to ignore all

[asterisk-dev] Change in asterisk[12]: .gitignore: Ignore tarballs (*.gz)

2015-04-13 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/85 Change subject: .gitignore: Ignore tarballs (*.gz) .. .gitignore: Ignore tarballs (*.gz) This patch updates the root .gitignore file to

[asterisk-dev] Change in asterisk[1.8]: Add .gitignore and .gitreview files

2015-04-13 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/82 Change subject: Add .gitignore and .gitreview files .. Add .gitignore and .gitreview files Add the .gitignore and .gitreview files to the

[asterisk-dev] Change in asterisk[1.8]: .gitignore: Ignore tarballs (*.gz)

2015-04-13 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/86 Change subject: .gitignore: Ignore tarballs (*.gz) .. .gitignore: Ignore tarballs (*.gz) This patch updates the root .gitignore file to

[asterisk-dev] Change in asterisk[12]: main/editline: Add .gitignore.

2015-04-13 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/83 Change subject: main/editline: Add .gitignore. .. main/editline: Add .gitignore. This patch adds a .gitignore for main/editline to ignore all

[asterisk-dev] Change in testsuite[master]: PEP8 fixes

2015-04-13 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: PEP8 fixes .. Patch Set 2: Code-Review+1 All the pjsip tests works now. -- To view, visit https://gerrit.asterisk.org/40 To unsubscribe, visit

[asterisk-dev] Change in asterisk[master]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: build_tools/make_version: Update version parsing for Git migration .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/80 To

[asterisk-dev] Change in asterisk[13]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: build_tools/make_version: Update version parsing for Git migration .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/79 To

[asterisk-dev] Change in asterisk[11]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: build_tools/make_version: Update version parsing for Git migration .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/77 To

[asterisk-dev] Change in asterisk[12]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: build_tools/make_version: Update version parsing for Git migration .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/78 To

[asterisk-dev] Change in asterisk[1.8]: build_tools/make_version: Update version parsing for Git mig...

2015-04-13 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: build_tools/make_version: Update version parsing for Git migration .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/76 To

[asterisk-dev] Change in testsuite[master]: PEP8 fixes

2015-04-12 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: PEP8 fixes .. Patch Set 1: Code-Review-1 Ran the first 10 pjsip tests and all failed but 1. They all pass in master. -- To view, visit

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 4: Code-Review+1 Compile succeeded. -- To view, visit https://gerrit.asterisk.org/58 To

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread George Joseph (Code Review)
Hello Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/58 to look at the new patch set (#4). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-12 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 1: Code-Review-1 (1 comment) Compile fails.

[asterisk-dev] Change in asterisk[master]: main/editline: Add .gitignore.

2015-04-12 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Code-Review+1 Good catch. I always use the external editline so the internal one never gets built. -- To

[asterisk-dev] Change in asterisk[master]: main/editline: Add .gitignore.

2015-04-12 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Why is it not included in the main .ignore? main/editline/Makefile etc. We decided that the ignores

[asterisk-dev] Change in asterisk[11]: Add .gitignore and .gitreview files

2015-04-12 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/64 To unsubscribe, visit

[asterisk-dev] Change in asterisk[13]: main/editline: Add .gitignore.

2015-04-12 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/66 To unsubscribe, visit

[asterisk-dev] Change in asterisk[11]: main/editline: Add .gitignore.

2015-04-12 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/67 To unsubscribe, visit

[asterisk-dev] Change in asterisk[13]: Add .gitignore and .gitreview files

2015-04-12 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/62 To unsubscribe, visit

[asterisk-dev] Change in asterisk[11]: .gitignore: Ignore tarballs (*.gz)

2015-04-12 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: .gitignore: Ignore tarballs (*.gz) .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/65 To unsubscribe, visit

[asterisk-dev] Change in asterisk[13]: .gitignore: Ignore tarballs (*.gz)

2015-04-12 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: .gitignore: Ignore tarballs (*.gz) .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/63 To unsubscribe, visit

[asterisk-dev] Change in asterisk[13]: pjsip_options: Add qualify_timeout processing and eventing

2015-04-11 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/44 Change subject: pjsip_options: Add qualify_timeout processing and eventing .. pjsip_options: Add qualify_timeout processing and eventing This

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/42 Change subject: Add .gitignore and .gitreview files .. Add .gitignore and .gitreview files Add the .gitignore and .gitreview files to the

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 2: (1 comment) My only issue with this is that it makes it harder to troubleshoot or get an overview of

[asterisk-dev] Change in asterisk[13]: res_pjsip: Refactor endpt_send_request to include transactio...

2015-04-11 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/43 Change subject: res_pjsip: Refactor endpt_send_request to include transaction timeout .. res_pjsip: Refactor endpt_send_request to include

[asterisk-dev] Change in testsuite[master]: tests/channels/pjsip/config_wizard/hints: Add 'has_hint' var...

2015-04-11 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/41 Change subject: tests/channels/pjsip/config_wizard/hints: Add 'has_hint' variable .. tests/channels/pjsip/config_wizard/hints: Add 'has_hint'

[asterisk-dev] Change in asterisk[13]: res_pjsip: Add global option to limit the maximum time for i...

2015-04-11 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/45 Change subject: res_pjsip: Add global option to limit the maximum time for initial qualifies .. res_pjsip: Add global option to limit the

[asterisk-dev] Change in asterisk[13]: res_pjsip: Add global option to limit the maximum time for i...

2015-04-11 Thread George Joseph (Code Review)
George Joseph has uploaded a new patch set (#2). Change subject: res_pjsip: Add global option to limit the maximum time for initial qualifies .. res_pjsip: Add global option to limit the maximum time for initial qualifies

[asterisk-dev] Change in asterisk[master]: res_pjsip: Add global option to limit the maximum time for i...

2015-04-11 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/48 Change subject: res_pjsip: Add global option to limit the maximum time for initial qualifies .. res_pjsip: Add global option to limit the

[asterisk-dev] Change in asterisk[master]: pjsip_options: Add qualify_timeout processing and eventing

2015-04-11 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/47 Change subject: pjsip_options: Add qualify_timeout processing and eventing .. pjsip_options: Add qualify_timeout processing and eventing This

[asterisk-dev] Change in asterisk[13]: Add .gitignore and .gitreview files

2015-04-11 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/49 Change subject: Add .gitignore and .gitreview files .. Add .gitignore and .gitreview files Add the .gitignore and .gitreview files to the

[asterisk-dev] Change in asterisk[master]: pjsip_options: Add qualify_timeout processing and eventing

2015-04-11 Thread George Joseph (Code Review)
George Joseph has abandoned this change. Change subject: pjsip_options: Add qualify_timeout processing and eventing .. Abandoned -- To view, visit https://gerrit.asterisk.org/47 To unsubscribe, visit

[asterisk-dev] Change in asterisk[13]: Add .gitignore and .gitreview files

2015-04-11 Thread George Joseph (Code Review)
George Joseph has abandoned this change. Change subject: Add .gitignore and .gitreview files .. Abandoned -- To view, visit https://gerrit.asterisk.org/49 To unsubscribe, visit https://gerrit.asterisk.org/settings

[asterisk-dev] Change in asterisk[master]: res_pjsip: Refactor endpt_send_request to include transactio...

2015-04-11 Thread George Joseph (Code Review)
George Joseph has abandoned this change. Change subject: res_pjsip: Refactor endpt_send_request to include transaction timeout .. Abandoned -- To view, visit https://gerrit.asterisk.org/46 To unsubscribe, visit

[asterisk-dev] Change in asterisk[master]: res_pjsip: Add global option to limit the maximum time for i...

2015-04-11 Thread George Joseph (Code Review)
George Joseph has abandoned this change. Change subject: res_pjsip: Add global option to limit the maximum time for initial qualifies .. Abandoned -- To view, visit https://gerrit.asterisk.org/48 To unsubscribe, visit

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread George Joseph (Code Review)
Hello Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/42 to look at the new patch set (#3). Change subject: Add .gitignore and .gitreview files .. Add .gitignore and .gitreview

[asterisk-dev] Change in testsuite[master]: Testsuite: Test for res_pjsip_config_wizard auto-create hints

2015-03-27 Thread George Joseph (Code Review)
George Joseph has uploaded a new patch set (#2). Change subject: Testsuite: Test for res_pjsip_config_wizard auto-create hints .. Testsuite: Test for res_pjsip_config_wizard auto-create hints This test uses ListDialPlan to

[asterisk-dev] Change in testsuite[master]: Fixes related to testsuite GIT migration.

2015-03-26 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: Fixes related to testsuite GIT migration. .. Patch Set 1: Code-Review+1 Looks good to me although I really just wanted to test the Reply function. :) -- To