[Asterisk-Dev] Re: Voicemail to email volume change patch

2006-01-13 Thread Robert A. Thompson
would you want the patch against trunk or 1.2.1? I wrote it against 1.2.1 but just svn co trunk and massaged it against that tree also. Is there any particular coding standard and/or etc that is prefered and if so, I will clean the patch up to make less work on someone else. I'm getting the

[Asterisk-Dev] Re: Voicemail to email volume change patch

2006-01-13 Thread Robert A. Thompson
On Fri, 13 Jan 2006 12:28:14 -0600, Steven Critchfield wrote: Since you are just changing the volume level, is there a reason you aren't using the record_gain option that I see in the code I just checked out from trunk? It would save you from spawning a process out of asterisk for the

[Asterisk-Dev] Re: Voicemail to email volume change patch

2006-01-13 Thread Robert A. Thompson
On Fri, 13 Jan 2006 11:28:31 -0600, Steven Critchfield wrote: You aren't normalizing the audio, you are just adjusting the volume. If you are going to go to the work of using an external app, why not use normalize so it truly is normalized and doesn't introduce problems when audio comes from

Re: [Asterisk-Dev] Re: Voicemail to email volume change patch

2006-01-13 Thread Steven Critchfield
On Fri, 2006-01-13 at 15:03 -0600, Robert A. Thompson wrote: would you want the patch against trunk or 1.2.1? I wrote it against 1.2.1 but just svn co trunk and massaged it against that tree also. Is there any particular coding standard and/or etc that is prefered and if so, I will clean the