Re: [asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels

2013-11-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3003/ --- (Updated Nov. 23, 2013, 6:38 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels

2013-11-22 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3003/ --- (Updated Nov. 22, 2013, 5:20 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels

2013-11-22 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3003/#review10263 --- Ship it! Ship It! - Matt Jordan On Nov. 22, 2013, 5:20

Re: [asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels

2013-11-21 Thread Joshua Colp
On Nov. 21, 2013, 8:05 p.m., Matt Jordan wrote: /branches/12/res/res_stasis_snoop.c, lines 215-228 https://reviewboard.asterisk.org/r/3003/diff/3/?file=48153#file48153line215 Going out on a limb here, but if this ever occurs, something has gone horribly wrong. We should never

Re: [asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels

2013-11-21 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3003/#review10253 --- /branches/12/res/res_stasis_snoop.c

Re: [asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels

2013-11-21 Thread Matt Jordan
On Nov. 14, 2013, 4:53 p.m., Mark Michelson wrote: /branches/12/res/res_stasis_snoop.c, line 142 https://reviewboard.asterisk.org/r/3003/diff/3/?file=48153#file48153line142 Hm, would it be more useful to publish the snoop messages on the spyee channel's topic? I would suspect