---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3025/
---
(Updated Nov. 23, 2013, 11:38 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3025/
---
(Updated Nov. 22, 2013, 10:52 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3025/
---
(Updated Nov. 22, 2013, 1:36 p.m.)
Review request for Asterisk
On Nov. 21, 2013, 3:30 p.m., David Lee wrote:
branches/12/main/devicestate.c, lines 741-742
https://reviewboard.asterisk.org/r/3025/diff/2/?file=48588#file48588line741
Unused.
Actually this does get used as it before the function returns the device state
data gets unref'ed and
On Nov. 21, 2013, 3:03 p.m., opticron wrote:
branches/12/res/res_stasis_device_state.c, lines 139-150
https://reviewboard.asterisk.org/r/3025/diff/2/?file=48597#file48597line139
Why not search via OBJ_SEARCH_KEY? This seems like a pretty expensive
operation when it doesn't have
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3025/#review10266
---
Ship it!
Ship It!
- Matt Jordan
On Nov. 22, 2013, 7:36
On Nov. 21, 2013, 12:59 a.m., Paul Belanger wrote:
branches/12/rest-api/api-docs/device_states.json, line 11
https://reviewboard.asterisk.org/r/3025/diff/1/?file=48553#file48553line11
Hmm, not a fan of this URL schema. At first glance, what about just
/states.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3025/#review10254
---
branches/12/include/asterisk/stasis_app.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3025/#review10257
---
branches/12/include/asterisk/stasis_app.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3025/#review10260
---
branches/12/res/res_stasis_device_state.c
On Nov. 21, 2013, 12:59 a.m., Paul Belanger wrote:
Thanks for this, I plan to spend some time over the weekend trying this
out. My comments are mostly from the ARIs POV, specifically what is a
device in ARI? and is that the same as an endpoint?
I'd akin this more to a virtual generic
On Nov. 21, 2013, 6:04 p.m., Mark Michelson wrote:
branches/12/res/res_stasis_device_state.c, lines 142-149
https://reviewboard.asterisk.org/r/3025/diff/1/?file=48549#file48549line142
Instead of constructing a device_state_subscription and searching by
OBJ_SEARCH_OBJECT, just use
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3025/
---
(Updated Nov. 21, 2013, 6:25 p.m.)
Review request for Asterisk
On Nov. 22, 2013, 12:04 a.m., Mark Michelson wrote:
branches/12/res/res_stasis_device_state.c, lines 142-149
https://reviewboard.asterisk.org/r/3025/diff/1/?file=48549#file48549line142
Instead of constructing a device_state_subscription and searching by
OBJ_SEARCH_OBJECT, just
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3025/
---
(Updated Nov. 21, 2013, 1:12 p.m.)
Review request for Asterisk
15 matches
Mail list logo
