Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-19 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3069/ --- (Updated Dec. 19, 2013, 6:20 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-18 Thread Joshua Colp
On Dec. 16, 2013, 8:26 p.m., rmudgett wrote: /branches/12/main/channel.c, lines 10399-10400 https://reviewboard.asterisk.org/r/3069/diff/1/?file=49555#file49555line10399 One thing that ast_channel_masquerade() did that is not being done anymore is queuing null frames to wake up

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3069/ --- (Updated Dec. 18, 2013, 8:20 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3069/#review10453 --- /branches/12/main/channel.c

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3069/ --- (Updated Dec. 18, 2013, 11:10 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3069/#review10460 --- Ship it! Ship It! - rmudgett On Dec. 18, 2013, 11:10 p.m.,

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-17 Thread Mark Michelson
On Dec. 16, 2013, 8:26 p.m., rmudgett wrote: /branches/12/main/channel.c, line 6479 https://reviewboard.asterisk.org/r/3069/diff/1/?file=49555#file49555line6479 How about channel_do_masquerade() or simply do_masquerade() I went with channel_do_masquerade()

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-17 Thread rmudgett
On Dec. 16, 2013, 8:26 p.m., rmudgett wrote: /branches/12/main/channel.c, lines 2687-2704 https://reviewboard.asterisk.org/r/3069/diff/1/?file=49555#file49555line2687 It is probably simpler now to just make ast_hangup() wait for any masquerade in progress to complete.

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-16 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3069/#review10423 --- /branches/12/main/channel.c

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-13 Thread Matt Jordan
On Dec. 12, 2013, 4:03 p.m., Mark Michelson wrote: Josh and I talked on IRC, and it would really be great if the channels involved in the masquerade could be locked for the duration of the operation instead of having to unlock them in order to send indications to them. That way, it

[asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-12 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3069/ --- Review request for Asterisk Developers, Joshua Colp, Jonathan Rose, Matt

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-12 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3069/#review10408 --- Josh and I talked on IRC, and it would really be great if the