---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3125/#review10621
---
Ship it!
Ship It!
- Mark Michelson
On Jan. 13, 2014, 11:26
On Jan. 16, 2014, 5 p.m., Mark Michelson wrote:
/branches/12/main/http.c, line 813
https://reviewboard.asterisk.org/r/3125/diff/2/?file=52892#file52892line813
chunked_atoh shouldn't be necessary. You should be able to just use:
sscanf(chunk_header, %x, chunk_length);
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3125/#review10627
---
Ship it!
The chunked decode looks good according to the RFC!
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3125/
---
(Updated Jan. 17, 2014, 2:51 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3125/#review10603
---
/branches/12/main/http.c
On Jan. 16, 2014, 11 a.m., Mark Michelson wrote:
/branches/12/main/http.c, line 813
https://reviewboard.asterisk.org/r/3125/diff/2/?file=52892#file52892line813
chunked_atoh shouldn't be necessary. You should be able to just use:
sscanf(chunk_header, %x, chunk_length);
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3125/
---
Review request for Asterisk Developers and Matt Jordan.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3125/#review10583
---
/branches/12/include/asterisk/http.h
On Jan. 13, 2014, 4:24 p.m., Matt Jordan wrote:
/branches/12/main/http.c, lines 804-805
https://reviewboard.asterisk.org/r/3125/diff/1/?file=52887#file52887line804
You don't need the while(1) here, as you aren't breaking out of the
block scope that it provides.
The curly is in
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3125/
---
(Updated Jan. 13, 2014, 5:26 p.m.)
Review request for Asterisk Developers
On Jan. 13, 2014, 4:24 p.m., Matt Jordan wrote:
/branches/12/main/http.c, lines 804-805
https://reviewboard.asterisk.org/r/3125/diff/1/?file=52887#file52887line804
You don't need the while(1) here, as you aren't breaking out of the
block scope that it provides.
rmudgett wrote:
11 matches
Mail list logo