Re: [asterisk-dev] [Code Review] 3472: res_pjsip_sdp_rtp: Fix issue with unholding when it shouldn't.

2014-04-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3472/ --- (Updated April 30, 2014, 7:38 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3472: res_pjsip_sdp_rtp: Fix issue with unholding when it shouldn't.

2014-04-29 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3472/#review11782 --- Ship it! /branches/12/res/res_pjsip_sdp_rtp.c

Re: [asterisk-dev] [Code Review] 3472: res_pjsip_sdp_rtp: Fix issue with unholding when it shouldn't.

2014-04-29 Thread Joshua Colp
On April 29, 2014, 2:25 p.m., opticron wrote: /branches/12/res/res_pjsip_sdp_rtp.c, lines 1080-1081 https://reviewboard.asterisk.org/r/3472/diff/1/?file=57771#file57771line1080 I guess people don't use SRTP+video/text that often... activate isn't really used by res_rtp_asterisk,

[asterisk-dev] [Code Review] 3472: res_pjsip_sdp_rtp: Fix issue with unholding when it shouldn't.

2014-04-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3472/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23558