---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3481/
---
(Updated April 30, 2014, 8:04 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3481/#review11778
---
branches/11/res/res_http_websocket.c
On April 29, 2014, 7:28 a.m., Joshua Colp wrote:
branches/11/res/res_http_websocket.c, line 125
https://reviewboard.asterisk.org/r/3481/diff/2/?file=58003#file58003line125
Is there any need for this since it should always be non-NULL now?
There is at least one code path where this
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3481/
---
(Updated April 29, 2014, 8:14 a.m.)
Review request for Asterisk
On April 29, 2014, 12:28 p.m., Joshua Colp wrote:
branches/11/res/res_http_websocket.c, line 195
https://reviewboard.asterisk.org/r/3481/diff/2/?file=58003#file58003line195
I don't see a close_sent change in here.
opticron wrote:
close_sent is set to 1 on line 206.
I meant:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3481/#review11781
---
Ship it!
Ship It!
- Joshua Colp
On April 29, 2014, 1:48
On April 25, 2014, 2:04 p.m., Matt Jordan wrote:
branches/11/res/res_http_websocket.c, lines 526-530
https://reviewboard.asterisk.org/r/3481/diff/1/?file=57910#file57910line526
So, while locking may solve the issue, there's something more insidious
about this part of the code
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3481/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-23605
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3481/#review11756
---
branches/11/res/res_http_websocket.c
