Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-05-22 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3494/#review11952 --- Ship it! Make sure you update the CHANGES file before commit!

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-05-22 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3494/ --- (Updated May 22, 2014, 11:13 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-05-21 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3494/ --- (Updated May 21, 2014, 1:41 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-05-21 Thread Scott Griepentrog
On May 20, 2014, 10:38 a.m., Matt Jordan wrote: /branches/12/main/stasis.c, lines 1024-1030 https://reviewboard.asterisk.org/r/3494/diff/3/?file=58411#file58411line1024 Sticking heterogeneous types into a single ao2_container still feels like the wrong approach here, for a few

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-05-20 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3494/#review11925 --- /branches/12/include/asterisk/stasis_app.h

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-05-12 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3494/ --- (Updated May 12, 2014, 3:45 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-05-09 Thread Scott Griepentrog
On May 1, 2014, 2:26 p.m., Matt Jordan wrote: /branches/12/include/asterisk/stasis_app.h, lines 242-247 https://reviewboard.asterisk.org/r/3494/diff/1/?file=58104#file58104line242 Why AGER? App_generate? I'd use APP_GEN, personally. It's a bit easier to read. I was

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-05-09 Thread Scott Griepentrog
On May 2, 2014, 8:37 a.m., Matt Jordan wrote: /branches/12/main/stasis_user.c, lines 64-74 https://reviewboard.asterisk.org/r/3494/diff/1/?file=58110#file58110line64 Wrapping the snapshots is fine, but I think all you'll need is the type stored as an enum. That will allow

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-05-09 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3494/ --- (Updated May 9, 2014, 5:29 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-05-09 Thread Scott Griepentrog
On May 1, 2014, 4:59 p.m., Samuel Galarneau wrote: /branches/12/rest-api/api-docs/applications.json, line 51 https://reviewboard.asterisk.org/r/3494/diff/1/?file=58118#file58118line51 What was the thought process behind adding this API endpoint to the applications resource? Would

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-05-02 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3494/#review11814 --- /branches/12/main/stasis_user.c

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-05-01 Thread Samuel Galarneau
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3494/#review11809 --- /branches/12/rest-api/api-docs/applications.json

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-05-01 Thread Samuel Galarneau
On May 1, 2014, 7:26 p.m., Matt Jordan wrote: /branches/12/rest-api/api-docs/applications.json, lines 84-90 https://reviewboard.asterisk.org/r/3494/diff/1/?file=58118#file58118line84 I don't think there should be a userEvent field in the query parameter. If a user wants

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-05-01 Thread Scott Griepentrog
On May 1, 2014, 4:59 p.m., Samuel Galarneau wrote: /branches/12/rest-api/api-docs/applications.json, line 51 https://reviewboard.asterisk.org/r/3494/diff/1/?file=58118#file58118line51 What was the thought process behind adding this API endpoint to the applications resource? Would

Re: [asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-05-01 Thread Samuel Galarneau
On May 1, 2014, 9:59 p.m., Samuel Galarneau wrote: /branches/12/rest-api/api-docs/applications.json, line 51 https://reviewboard.asterisk.org/r/3494/diff/1/?file=58118#file58118line51 What was the thought process behind adding this API endpoint to the applications resource? Would

[asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-04-29 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3494/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22697