Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

2014-07-18 Thread Scott Griepentrog
On July 13, 2014, 4:22 p.m., rmudgett wrote: ast_assert() already outputs a backtrace using ao2_bt() even if DO_CRACH is not enabled. We also seem to have two backtrace generation functions: ao2_bt() ast_log_bactrace() Matt Jordan wrote: We could consolidate these two

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

2014-07-18 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3765/ --- (Updated July 18, 2014, 9:58 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

2014-07-18 Thread rmudgett
On July 13, 2014, 4:22 p.m., rmudgett wrote: ast_assert() already outputs a backtrace using ao2_bt() even if DO_CRACH is not enabled. We also seem to have two backtrace generation functions: ao2_bt() ast_log_bactrace() Matt Jordan wrote: We could consolidate these two

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

2014-07-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3765/#review12750 --- Ship it! I also checked that the utils directory still

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

2014-07-18 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3765/ --- (Updated July 18, 2014, 12:55 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

2014-07-13 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3765/ --- (Updated July 13, 2014, 3:05 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

2014-07-13 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3765/#review12607 --- Ship it! Ship It! - Corey Farrell On July 13, 2014, 4:05

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

2014-07-13 Thread Matt Jordan
On July 13, 2014, 4:22 p.m., rmudgett wrote: ast_assert() already outputs a backtrace using ao2_bt() even if DO_CRACH is not enabled. We also seem to have two backtrace generation functions: ao2_bt() ast_log_bactrace() We could consolidate these two functions easily;

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

2014-07-13 Thread rmudgett
On July 13, 2014, 4:22 p.m., rmudgett wrote: ast_assert() already outputs a backtrace using ao2_bt() even if DO_CRACH is not enabled. We also seem to have two backtrace generation functions: ao2_bt() ast_log_bactrace() Matt Jordan wrote: We could consolidate these two

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

2014-07-13 Thread Matt Jordan
On July 13, 2014, 4:22 p.m., rmudgett wrote: ast_assert() already outputs a backtrace using ao2_bt() even if DO_CRACH is not enabled. We also seem to have two backtrace generation functions: ao2_bt() ast_log_bactrace() Matt Jordan wrote: We could consolidate these two

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

2014-07-12 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3765/#review12599 --- /trunk/main/astobj2.c