Re: [asterisk-dev] [Code Review] 3908: ARI: Fix bug where hanging up while in a bridge during playback causes a crash

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3908/ --- (Updated Aug. 22, 2014, 11:27 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3908: ARI: Fix bug where hanging up while in a bridge during playback causes a crash

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3908/#review13154 --- Ship it! /branches/12/res/res_stasis_recording.c

Re: [asterisk-dev] [Code Review] 3908: ARI: Fix bug where hanging up while in a bridge during playback causes a crash

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3908/ --- (Updated Aug. 21, 2014, 3:11 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 3908: ARI: Fix bug where hanging up while in a bridge during playback causes a crash

> On Aug. 21, 2014, 3:03 p.m., rmudgett wrote: > > /branches/12/res/res_stasis_recording.c, lines 405-409 > > > > > > Missed an unref recoring here. > > > > You really didn't need to eliminate the RAII_VA

Re: [asterisk-dev] [Code Review] 3908: ARI: Fix bug where hanging up while in a bridge during playback causes a crash

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3908/#review13152 --- /branches/12/res/res_stasis_recording.c

Re: [asterisk-dev] [Code Review] 3908: ARI: Fix bug where hanging up while in a bridge during playback causes a crash

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3908/ --- (Updated Aug. 21, 2014, 2:44 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 3908: ARI: Fix bug where hanging up while in a bridge during playback causes a crash

> On Aug. 21, 2014, 1:30 p.m., rmudgett wrote: > > /branches/12/res/res_stasis_playback.c, lines 464-468 > > > > > > To be safe, swap the ao2_ref and the send_comand statements. If the > > send_command fails to se

Re: [asterisk-dev] [Code Review] 3908: ARI: Fix bug where hanging up while in a bridge during playback causes a crash

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3908/#review13141 --- mostly minor nits /branches/12/include/asterisk/stasis_app_im

Re: [asterisk-dev] [Code Review] 3908: ARI: Fix bug where hanging up while in a bridge during playback causes a crash

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3908/ --- (Updated Aug. 21, 2014, 11:30 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3908: ARI: Fix bug where hanging up while in a bridge during playback causes a crash

> On Aug. 20, 2014, 7:03 p.m., rmudgett wrote: > > /branches/12/res/stasis/command.c, lines 122-124 > > > > > > Call the data_destructor here if there is one to guarantee that the > > data will be destroyed regardl

Re: [asterisk-dev] [Code Review] 3908: ARI: Fix bug where hanging up while in a bridge during playback causes a crash

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3908/#review13128 --- /branches/12/res/stasis/command.h

Re: [asterisk-dev] [Code Review] 3908: ARI: Fix bug where hanging up while in a bridge during playback causes a crash

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3908/ --- (Updated Aug. 20, 2014, 4:21 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 3908: ARI: Fix bug where hanging up while in a bridge during playback causes a crash

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3908/#review13103 --- /branches/12/res/res_stasis.c

[asterisk-dev] [Code Review] 3908: ARI: Fix bug where hanging up while in a bridge during playback causes a crash

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3908/ --- Review request for Asterisk Developers, kmoore, Matt Jordan, and rmudgett.