Re: [asterisk-dev] [Code Review] 4132: config: Make ast_config_text_file_save and 'dialplan save' escape semicolons in values.

2014-11-04 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4132/#review13670 --- Ship it! Ship It! - opticron On Oct. 30, 2014, 7:02 p.m.,

Re: [asterisk-dev] [Code Review] 4132: config: Make ast_config_text_file_save and 'dialplan save' escape semicolons in values.

2014-11-04 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4132/ --- (Updated Nov. 4, 2014, 6:11 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 4132: config: Make ast_config_text_file_save and 'dialplan save' escape semicolons in values.

2014-10-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4132/ --- Review request for Asterisk Developers and Birger Harzenetter. Bugs:

Re: [asterisk-dev] [Code Review] 4132: config: Make ast_config_text_file_save and 'dialplan save' escape semicolons in values.

2014-10-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4132/ --- (Updated Oct. 30, 2014, 11:09 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4132: config: Make ast_config_text_file_save and 'dialplan save' escape semicolons in values.

2014-10-30 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4132/#review13632 --- This new function could use some unit tests for nominal and

Re: [asterisk-dev] [Code Review] 4132: config: Make ast_config_text_file_save and 'dialplan save' escape semicolons in values.

2014-10-30 Thread opticron
On Oct. 30, 2014, 1:25 p.m., opticron wrote: branches/13/main/utils.c, line 494 https://reviewboard.asterisk.org/r/4132/diff/3/?file=68631#file68631line494 This should be instead of = due to the need to write out a null terminator along with the escaped semicolon.

Re: [asterisk-dev] [Code Review] 4132: config: Make ast_config_text_file_save and 'dialplan save' escape semicolons in values.

2014-10-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4132/ --- (Updated Oct. 30, 2014, 3:35 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4132: config: Make ast_config_text_file_save and 'dialplan save' escape semicolons in values.

2014-10-30 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4132/#review13637 --- branches/13/main/config.c

Re: [asterisk-dev] [Code Review] 4132: config: Make ast_config_text_file_save and 'dialplan save' escape semicolons in values.

2014-10-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4132/ --- (Updated Oct. 30, 2014, 6:02 p.m.) Review request for Asterisk Developers