---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4135/
---
(Updated Nov. 14, 2014, 9 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4135/#review13759
---
Ship it!
Ship It!
- Matt Jordan
On Nov. 7, 2014, 12:31
On Nov. 6, 2014, 7:17 p.m., opticron wrote:
/branches/12/main/stasis_bridges.c, line 1061
https://reviewboard.asterisk.org/r/4135/diff/3/?file=68749#file68749line1061
Using RAII_VAR here would be appropriate since the 5 applicable return
paths require its cleanup.
I disagree.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4135/
---
(Updated Nov. 7, 2014, 6:31 p.m.)
Review request for Asterisk Developers.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4135/#review13703
---
/branches/12/include/asterisk/stasis_bridges.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4135/
---
(Updated Nov. 4, 2014, 9:44 p.m.)
Review request for Asterisk Developers.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4135/
---
(Updated Oct. 31, 2014, 3:58 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4135/#review13651
---
/branches/12/main/bridge.c
On Oct. 31, 2014, 5:39 p.m., rmudgett wrote:
/branches/12/main/bridge.c, line 4253
https://reviewboard.asterisk.org/r/4135/diff/2/?file=68675#file68675line4253
I have a feeling that the race also affects parking here. If so then
holding the bridge lock is not a viable solution.
On Oct. 31, 2014, 12:39 p.m., rmudgett wrote:
/branches/12/main/bridge.c, line 4253
https://reviewboard.asterisk.org/r/4135/diff/2/?file=68675#file68675line4253
I have a feeling that the race also affects parking here. If so then
holding the bridge lock is not a viable solution.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4135/
---
Review request for Asterisk Developers.
Repository: Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4135/#review13638
---
/branches/12/main/bridge.c
12 matches
Mail list logo