Re: [asterisk-dev] [Code Review] 4135: Resolve race condition that can result in ARI apps not being notified of transfers

2014-11-14 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4135/ --- (Updated Nov. 14, 2014, 9 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4135: Resolve race condition that can result in ARI apps not being notified of transfers

2014-11-13 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4135/#review13759 --- Ship it! Ship It! - Matt Jordan On Nov. 7, 2014, 12:31

Re: [asterisk-dev] [Code Review] 4135: Resolve race condition that can result in ARI apps not being notified of transfers

2014-11-07 Thread Mark Michelson
On Nov. 6, 2014, 7:17 p.m., opticron wrote: /branches/12/main/stasis_bridges.c, line 1061 https://reviewboard.asterisk.org/r/4135/diff/3/?file=68749#file68749line1061 Using RAII_VAR here would be appropriate since the 5 applicable return paths require its cleanup. I disagree.

Re: [asterisk-dev] [Code Review] 4135: Resolve race condition that can result in ARI apps not being notified of transfers

2014-11-07 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4135/ --- (Updated Nov. 7, 2014, 6:31 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4135: Resolve race condition that can result in ARI apps not being notified of transfers

2014-11-06 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4135/#review13703 --- /branches/12/include/asterisk/stasis_bridges.h

Re: [asterisk-dev] [Code Review] 4135: Resolve race condition that can result in ARI apps not being notified of transfers

2014-11-04 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4135/ --- (Updated Nov. 4, 2014, 9:44 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4135: Resolve race condition that can result in ARI apps not being notified of transfers

2014-10-31 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4135/ --- (Updated Oct. 31, 2014, 3:58 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4135: Resolve race condition that can result in ARI apps not being notified of transfers

2014-10-31 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4135/#review13651 --- /branches/12/main/bridge.c

Re: [asterisk-dev] [Code Review] 4135: Resolve race condition that can result in ARI apps not being notified of transfers

2014-10-31 Thread Mark Michelson
On Oct. 31, 2014, 5:39 p.m., rmudgett wrote: /branches/12/main/bridge.c, line 4253 https://reviewboard.asterisk.org/r/4135/diff/2/?file=68675#file68675line4253 I have a feeling that the race also affects parking here. If so then holding the bridge lock is not a viable solution.

Re: [asterisk-dev] [Code Review] 4135: Resolve race condition that can result in ARI apps not being notified of transfers

2014-10-31 Thread rmudgett
On Oct. 31, 2014, 12:39 p.m., rmudgett wrote: /branches/12/main/bridge.c, line 4253 https://reviewboard.asterisk.org/r/4135/diff/2/?file=68675#file68675line4253 I have a feeling that the race also affects parking here. If so then holding the bridge lock is not a viable solution.

[asterisk-dev] [Code Review] 4135: Resolve race condition that can result in ARI apps not being notified of transfers

2014-10-30 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4135/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4135: Resolve race condition that can result in ARI apps not being notified of transfers

2014-10-30 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4135/#review13638 --- /branches/12/main/bridge.c