Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

2014-12-31 Thread Scott Griepentrog
On Dec. 23, 2014, 7:41 a.m., Joshua Colp wrote: /trunk/main/rtp_engine.c, line 2193 https://reviewboard.asterisk.org/r/4286/diff/1/?file=69966#file69966line2193 Yeah, put this in the 96-127 rang instead. Wouldn't that cause ast_rtp_engine_load_format() to fail because no dynamic

Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

2014-12-31 Thread Joshua Colp
On Dec. 23, 2014, 1:41 p.m., Joshua Colp wrote: /trunk/main/rtp_engine.c, line 2193 https://reviewboard.asterisk.org/r/4286/diff/1/?file=69966#file69966line2193 Yeah, put this in the 96-127 rang instead. Scott Griepentrog wrote: Wouldn't that cause

Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

2014-12-31 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/ --- (Updated Dec. 31, 2014, 12:06 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

2014-12-31 Thread Scott Griepentrog
On Dec. 23, 2014, 7:41 a.m., Joshua Colp wrote: /trunk/main/rtp_engine.c, line 2193 https://reviewboard.asterisk.org/r/4286/diff/1/?file=69966#file69966line2193 Yeah, put this in the 96-127 rang instead. Scott Griepentrog wrote: Wouldn't that cause

Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

2014-12-31 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/#review14061 --- Ship it! Ship It! - Joshua Colp On Dec. 31, 2014, 6:06

Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

2014-12-31 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/ --- (Updated Dec. 31, 2014, 12:54 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

2014-12-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/#review14028 --- /trunk/main/rtp_engine.c

[asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

2014-12-19 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24367

Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

2014-12-19 Thread Olle E Johansson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/#review14021 --- You may want to consider fixing RFC 5761 restrictions while