---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4536/#review15145
---
Ship it!
Ship It!
- Matt Jordan
On April 7, 2015, 3:38
On April 7, 2015, 10:46 a.m., Matt Jordan wrote:
Also, please remember to close findings that you feel have been resolved.
Otherwise, it is difficult to know what all has been addressed between reviews.
- Matt
---
This is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4536/#review15090
---
trunk/channels/chan_iax2.c
On April 7, 2015, 10:46 a.m., Matt Jordan wrote:
trunk/channels/chan_iax2.c, lines 12365-12375
https://reviewboard.asterisk.org/r/4536/diff/2/?file=73573#file73573line12365
I would put a comment in here explaining why the schedule times are
chosen as they are. 5/6 feels arbitrary
On April 7, 2015, 3:46 p.m., Matt Jordan wrote:
Matt Jordan wrote:
Also, please remember to close findings that you feel have been resolved.
Otherwise, it is difficult to know what all has been addressed between
reviews.
ok.
On April 7, 2015, 3:46 p.m., Matt Jordan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4536/
---
(Updated April 7, 2015, 8:38 p.m.)
Review request for Asterisk Developers
On April 1, 2015, 1:07 a.m., Matt Jordan wrote:
trunk/channels/chan_iax2.c, line 12370
https://reviewboard.asterisk.org/r/4536/diff/1/?file=72980#file72980line12370
The usage of max_retries here feels arbitrary. I'm not against this
being controlled more dynamically based on the
On April 1, 2015, 1:07 a.m., Matt Jordan wrote:
trunk/channels/chan_iax2.c, line 12370
https://reviewboard.asterisk.org/r/4536/diff/1/?file=72980#file72980line12370
The usage of max_retries here feels arbitrary. I'm not against this
being controlled more dynamically based on the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4536/#review15007
---
trunk/channels/chan_iax2.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4536/
---
Review request for Asterisk Developers and rnewton.
Bugs: ASTERISK-24894
10 matches
Mail list logo