Re: [asterisk-dev] [Code Review] 4542: DNS: Add NAPTR support and tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4542/ --- (Updated April 6, 2015, 12:06 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4542: DNS: Add NAPTR support and tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4542/#review15031 --- Ship it! Ship It! - Kevin Harwell On April 1, 2015, 9:51 a.

Re: [asterisk-dev] [Code Review] 4542: DNS: Add NAPTR support and tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4542/ --- (Updated April 1, 2015, 2:51 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4542: DNS: Add NAPTR support and tests

> On March 31, 2015, 3:25 p.m., Matt Jordan wrote: > > /team/group/dns/main/dns_naptr.c, lines 420-421 > > > > > > The asserts here are appropriate. > > > > However, if there is an error in the record, such

Re: [asterisk-dev] [Code Review] 4542: DNS: Add NAPTR support and tests

> On March 31, 2015, 10:25 a.m., Matt Jordan wrote: > > /team/group/dns/main/dns_naptr.c, lines 447-449 > > > > > > Suggestion: since this is repeated after each check, you may want to > > macro-tize it: > > >

Re: [asterisk-dev] [Code Review] 4542: DNS: Add NAPTR support and tests

> On March 31, 2015, 4:50 p.m., Kevin Harwell wrote: > > /team/group/dns/main/dns_naptr.c, line 244 > > > > > > This seems like it should be a non assert check. What happens if > > asterisk is not compiled without

Re: [asterisk-dev] [Code Review] 4542: DNS: Add NAPTR support and tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4542/#review14984 --- /team/group/dns/include/asterisk/dns_internal.h

Re: [asterisk-dev] [Code Review] 4542: DNS: Add NAPTR support and tests

> On March 31, 2015, 10:25 a.m., Matt Jordan wrote: > > /team/group/dns/main/dns_naptr.c, lines 447-449 > > > > > > Suggestion: since this is repeated after each check, you may want to > > macro-tize it: > > >

Re: [asterisk-dev] [Code Review] 4542: DNS: Add NAPTR support and tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4542/#review14972 --- /team/group/dns/include/asterisk/dns_internal.h

Re: [asterisk-dev] [Code Review] 4542: DNS: Add NAPTR support and tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4542/ --- (Updated March 27, 2015, 2:45 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 4542: DNS: Add NAPTR support and tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4542/ --- Review request for Asterisk Developers. Repository: Asterisk Description