Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

2015-03-28 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4544/ --- (Updated March 28, 2015, 7:48 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

2015-03-27 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4544/#review14917 --- I'm wondering if -Wself-assign should not be enabled. It

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

2015-03-27 Thread Diederik de Groot
On March 27, 2015, 6:14 p.m., rmudgett wrote: I'm wondering if -Wself-assign should not be enabled. It appears to be just a nuisance warning. I do agree, some of the clang warnings can be a little bit petty to be honest. Some of them have proven to be quite usefull though. I will leave

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

2015-03-27 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4544/ --- (Updated March 27, 2015, 6:20 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

2015-03-27 Thread Diederik de Groot
On March 27, 2015, 5:20 p.m., Jared Smith wrote: /branches/13/formats/format_wav.c, line 67 https://reviewboard.asterisk.org/r/4544/diff/1/?file=73085#file73085line67 Red blob... I like to line up the slashes when using macro's. But ok - Diederik

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

2015-03-27 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4544/ --- (Updated March 27, 2015, 5:38 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

2015-03-27 Thread Jared Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4544/#review14907 --- /branches/13/formats/format_wav.c

[asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

2015-03-27 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4544/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24917

Re: [asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

2015-03-27 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4544/#review14925 --- Ship it! Ship It! - Matt Jordan On March 27, 2015, 12:20