Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-06-08 Thread Jeffrey Ollie
On Mon, Jun 8, 2015 at 8:35 AM, Russell Bryant russ...@russellbryant.net wrote: On Tue, Jun 2, 2015 at 8:05 PM, Matthew Jordan mjor...@digium.com wrote: Suggestion 1: Make the module opt in instead of opt out. In most cases, I would normally agree with this proposal, as I personally prefer

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-06-08 Thread Leif Madsen
On Mon, Jun 8, 2015 at 9:35 AM, Russell Bryant russ...@russellbryant.net wrote: On Tue, Jun 2, 2015 at 8:05 PM, Matthew Jordan mjor...@digium.com wrote: Personally, I'd like some way to present any user of Asterisk with a one-time only, non-annoying please help the project and opt in

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-06-08 Thread Russell Bryant
On Mon, Jun 8, 2015 at 9:57 AM, Leif Madsen leif.mad...@avoxi.com wrote: On Mon, Jun 8, 2015 at 9:35 AM, Russell Bryant russ...@russellbryant.net wrote: On Tue, Jun 2, 2015 at 8:05 PM, Matthew Jordan mjor...@digium.com wrote: Personally, I'd like some way to present any user of Asterisk

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-06-08 Thread Russell Bryant
On Tue, Jun 2, 2015 at 8:05 PM, Matthew Jordan mjor...@digium.com wrote: Suggestion 1: Make the module opt in instead of opt out. In most cases, I would normally agree with this proposal, as I personally prefer an opt in model instead of an opt out model. Unfortunately, I'm not sure I can

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-06-07 Thread Moises Silva
How often were you envisioning having the job call home? I was thinking at startup and core reload and if that's the case why bother with an external process and the work that goes with it? I know someone mentioned they don't want asterisk crashing because of a flaw in the beacon but you

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-06-02 Thread George Joseph
On Tue, Jun 2, 2015 at 6:05 PM, Matthew Jordan mjor...@digium.com wrote: snip Thanks everyone for the suggestions and ideas. I'm sorry I haven't had a chance to reply back to them all until now, but I've had a lot of trips and other things pop up, and didn't have a chance to fully digest the

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-06-02 Thread Matthew Jordan
snip Thanks everyone for the suggestions and ideas. I'm sorry I haven't had a chance to reply back to them all until now, but I've had a lot of trips and other things pop up, and didn't have a chance to fully digest the suggestions and reply back until now. I've grouped the various suggestions

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-13 Thread Moises Silva
On Tue, May 12, 2015 at 1:47 PM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: On Tue, May 12, 2015 at 11:15:40AM -0600, George Joseph wrote: The only volatile stats to be reported were active/total calls and I'd be willing to give that up to keep the process simple. Even if we did keep

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-13 Thread Tzafrir Cohen
On Tue, May 12, 2015 at 01:24:17PM -0500, Scott Griepentrog wrote: On Tue, May 12, 2015 at 12:59 PM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: Quoting the spec: | Spoofing | | In order to limit spoofing, the server will return a token for all | accepted requests to a server.

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Tzafrir Cohen
On Tue, May 12, 2015 at 10:39:04AM -0600, George Joseph wrote: On Tue, May 12, 2015 at 10:08 AM, Jeffrey Ollie j...@ocjtech.us wrote: On Tue, May 12, 2015 at 9:47 AM, George Joseph george.jos...@fairview5.com wrote: On Tue, May 12, 2015 at 5:41 AM, Tzafrir Cohen tzafrir.co...@xorcom.com

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Jeffrey Ollie
On Tue, May 12, 2015 at 11:39 AM, George Joseph george.jos...@fairview5.com wrote: Hmmm. It just seems to me we're way over thinking this. Separate executables and a public APIs seems overkill for something that on;y needs to run for a few seconds on startup and reload. Hmm, yes, I guess

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Tzafrir Cohen
On Tue, May 12, 2015 at 11:15:40AM -0600, George Joseph wrote: The only volatile stats to be reported were active/total calls and I'd be willing to give that up to keep the process simple. Even if we did keep the calls, and it reported a few times a day I still don't see the need for the

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread George Joseph
On Tue, May 12, 2015 at 10:08 AM, Jeffrey Ollie j...@ocjtech.us wrote: On Tue, May 12, 2015 at 9:47 AM, George Joseph george.jos...@fairview5.com wrote: On Tue, May 12, 2015 at 5:41 AM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: On Mon, May 11, 2015 at 01:29:04PM -0600, George

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread George Joseph
On Tue, May 12, 2015 at 10:59 AM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: On Tue, May 12, 2015 at 10:39:04AM -0600, George Joseph wrote: On Tue, May 12, 2015 at 10:08 AM, Jeffrey Ollie j...@ocjtech.us wrote: On Tue, May 12, 2015 at 9:47 AM, George Joseph

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Jeffrey Ollie
On Tue, May 12, 2015 at 9:47 AM, George Joseph george.jos...@fairview5.com wrote: On Tue, May 12, 2015 at 5:41 AM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: On Mon, May 11, 2015 at 01:29:04PM -0600, George Joseph wrote: As for the other issues, why not just have asterisk fork itself on

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Scott Griepentrog
Correction: as one will end up getting a new ID (the second one to reuse the same token). On Tue, May 12, 2015 at 1:24 PM, Scott Griepentrog sgriepent...@digium.com wrote: So as opposed to spoofing, there is also the case that someone having a copy of Asteirsk in a virtual machine clones it,

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Scott Griepentrog
So as opposed to spoofing, there is also the case that someone having a copy of Asteirsk in a virtual machine clones it, and ends up with two instances reporting the same random ID. With the spoofing detection mechanism (using tokens to get an ID from the server), the effect of this case is

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Tzafrir Cohen
Quoting the spec: | Spoofing | | In order to limit spoofing, the server will return a token for all | accepted requests to a server. Any subsequent requests to that resource | must present the token in the request. If a subsequent request fails to | provide the token, the request is rejected.

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Tzafrir Cohen
On Mon, May 11, 2015 at 01:29:04PM -0600, George Joseph wrote: As for the other issues, why not just have asterisk fork itself on startup and reloads just to send the stats. No separate executables, no AMI, no cron, and you get the process separation so a segv or orthe rerror doesn't kill

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread George Joseph
On Tue, May 12, 2015 at 5:41 AM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: On Mon, May 11, 2015 at 01:29:04PM -0600, George Joseph wrote: As for the other issues, why not just have asterisk fork itself on startup and reloads just to send the stats. No separate executables, no AMI, no

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-11 Thread Tzafrir Cohen
On Thu, May 07, 2015 at 09:35:11PM -0500, Matthew Jordan wrote: [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Beacon+Module One minor issue: the operating system seems to be mostly (at least in the example given there) identified by the kernel. This doesn't always map good to the

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-11 Thread Tzafrir Cohen
On Fri, May 08, 2015 at 09:37:37PM -0500, Matthew Jordan wrote: On Fri, May 8, 2015 at 4:54 PM, Rodrigo Ramírez Norambuena decipher...@gmail.com wrote: On Fri, May 08, 2015 at 11:49:39AM -0400, Moises Silva wrote: On Thu, May 7, 2015 at 10:35 PM, Matthew Jordan mjor...@digium.com wrote:

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-11 Thread George Joseph
On Mon, May 11, 2015 at 11:56 AM, Russell Bryant russ...@russellbryant.net wrote: On Mon, May 11, 2015 at 1:31 PM, Jeffrey Ollie j...@ocjtech.us wrote: On Thu, May 7, 2015 at 9:35 PM, Matthew Jordan mjor...@digium.com wrote: * The module must provide the ability for users to opt out of

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-11 Thread Jeffrey Ollie
On Thu, May 7, 2015 at 9:35 PM, Matthew Jordan mjor...@digium.com wrote: * The module must provide the ability for users to opt out of gathering statistics. I believe that this must be opt *in*, not opt out. Yes, you'll get fewer servers reporting data but it's the much friendlier thing to

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-11 Thread Russell Bryant
On Mon, May 11, 2015 at 1:31 PM, Jeffrey Ollie j...@ocjtech.us wrote: On Thu, May 7, 2015 at 9:35 PM, Matthew Jordan mjor...@digium.com wrote: * The module must provide the ability for users to opt out of gathering statistics. I believe that this must be opt *in*, not opt out. Yes,

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-10 Thread Moises Silva
On Fri, May 8, 2015 at 10:37 PM, Matthew Jordan mjor...@digium.com wrote: 1) Not all of the data you may want to retrieve may be readily available. Granted, right now, I don't think that's the case, but there's certainly more flexibility if you have access to Asterisk's C APIs. If the time

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-08 Thread Moises Silva
On Thu, May 7, 2015 at 10:35 PM, Matthew Jordan mjor...@digium.com wrote: Hey everyone - At the past several AstriDevCon events, we've had an open discussion about adding a module to Asterisk that would gather anonymous usage statistics. Said module would be used to help the Asterisk

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-08 Thread Rodrigo Ramírez Norambuena
On Fri, May 08, 2015 at 11:49:39AM -0400, Moises Silva wrote: On Thu, May 7, 2015 at 10:35 PM, Matthew Jordan mjor...@digium.com wrote: Hey everyone - At the past several AstriDevCon events, we've had an open discussion about adding a module to Asterisk that would gather anonymous usage

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-08 Thread Matthew Jordan
On Fri, May 8, 2015 at 4:54 PM, Rodrigo Ramírez Norambuena decipher...@gmail.com wrote: On Fri, May 08, 2015 at 11:49:39AM -0400, Moises Silva wrote: On Thu, May 7, 2015 at 10:35 PM, Matthew Jordan mjor...@digium.com wrote: Hey everyone - At the past several AstriDevCon events, we've had

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-08 Thread Matthew Jordan
On Thu, May 7, 2015 at 11:40 PM, George Joseph george.jos...@fairview5.com wrote: On Thu, May 7, 2015 at 8:35 PM, Matthew Jordan mjor...@digium.com wrote: Hey everyone - At the past several AstriDevCon events, we've had an open discussion about adding a module to Asterisk that would gather

[asterisk-dev] Asterisk Beacon Module Proposal

2015-05-07 Thread Matthew Jordan
Hey everyone - At the past several AstriDevCon events, we've had an open discussion about adding a module to Asterisk that would gather anonymous usage statistics. Said module would be used to help the Asterisk Developer community better support the users of Asterisk, as we would have some

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-07 Thread George Joseph
On Thu, May 7, 2015 at 8:35 PM, Matthew Jordan mjor...@digium.com wrote: Hey everyone - At the past several AstriDevCon events, we've had an open discussion about adding a module to Asterisk that would gather anonymous usage statistics. Said module would be used to help the Asterisk