---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4441/#review14966
---
Thank you for working on the TLS code, we surely need more
On 30 Mar 2015, at 16:54, Mark Michelson mmichel...@digium.com wrote:
On 03/28/2015 08:06 PM, Joshua Colp wrote:
George Joseph wrote:
The fact that it goes to unavailable would be a bug. Why does it do so?
Mark should probably chime in here but I think it's because the
earliest you could
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4558/
---
(Updated March 31, 2015, 6:47 a.m.)
Status
--
This change has been
On Tue, Mar 31, 2015 at 8:04 AM, Yaron Nachum nachum.ya...@gmail.com wrote:
Hi everyone,
I am trying to add some tests for the PJSIP auto-dtmf support . Before I
start I just wanted to run some of the existing tests in order to understand
the process.
Whenever I try to run a test from the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4533/#review15013
---
/branches/13/channels/chan_skinny.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4533/
---
(Updated April 1, 2015, 4:52 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4533/
---
(Updated April 1, 2015, 4:54 a.m.)
Review request for Asterisk
On April 1, 2015, 4:30 a.m., rmudgett wrote:
/branches/13/channels/chan_skinny.c, line 2387
https://reviewboard.asterisk.org/r/4533/diff/8/?file=73424#file73424line2387
Guidelines: No space with parens
if (a) {
}
Getting late...
- Diederik
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4533/#review15003
---
/branches/13/channels/chan_skinny.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4555/#review15012
---
/branches/13/tests/test_strings.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4555/
---
(Updated April 1, 2015, 4:47 a.m.)
Review request for Asterisk
On April 1, 2015, 1:21 a.m., rmudgett wrote:
/branches/13/main/utils.c, lines 492-493
https://reviewboard.asterisk.org/r/4555/diff/5/?file=73346#file73346line492
Revert this. This change could affect the callers of the function
since you are changing the API. However, no
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4551/#review15006
---
Ship it!
Ship It!
- Matt Jordan
On March 30, 2015, 6:16
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4571/#review15004
---
/trunk/CHANGES
On April 1, 2015, 12:30 a.m., rmudgett wrote:
I dislike this warning. It is more nuisance than helpful. I once worked
with compiler that had a similar warning. The lengths you sometimes have
to go to eradicate the the warning can be extream.
There are several places in this
On April 1, 2015, 1:21 a.m., rmudgett wrote:
/branches/13/tests/test_strings.c, line 399
https://reviewboard.asterisk.org/r/4555/diff/5/?file=73351#file73351line399
Did you mean ast_alloca() or ast_strdupa()?
Ooh sorry i meant ast_alloca... Typo.
On April 1, 2015, 1:21 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4555/
---
(Updated April 1, 2015, 3:30 a.m.)
Review request for Asterisk
On April 1, 2015, 3:16 a.m., rmudgett wrote:
/branches/13/funcs/func_curl.c, lines 174-175
https://reviewboard.asterisk.org/r/4533/diff/7/?file=73369#file73369line174
Try defining this as:
#define CURLOPT_SPECIAL_HASHCOMPAT ((CURLoption) -500)
This should shut-up
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4555/
---
(Updated April 1, 2015, 4:46 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4555/#review15016
---
Ship it!
Ship It!
- rmudgett
On March 31, 2015, 9:42 p.m.,
On Tue, Mar 24, 2015 at 4:04 PM, Yousf Ateya y.at...@starkbits.com wrote:
One of the ways in which IAX calculates peer ping time is using
POKE/PONG/ACK sequence as follows:
- Peer1 sends POKE (frame timestamp is time of sending)
- Peer2 sends PONG with same time stamp received from POKE.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4550/
---
(Updated April 1, 2015, 3:33 a.m.)
Review request for Asterisk
On March 31, 2015, 8:16 p.m., rmudgett wrote:
/branches/13/funcs/func_curl.c, lines 174-175
https://reviewboard.asterisk.org/r/4533/diff/7/?file=73369#file73369line174
Try defining this as:
#define CURLOPT_SPECIAL_HASHCOMPAT ((CURLoption) -500)
This should shut-up
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4555/
---
(Updated April 1, 2015, 4:42 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4536/#review15007
---
trunk/channels/chan_iax2.c
On April 1, 2015, 3:16 a.m., rmudgett wrote:
Thanks for your help on this one !
- Diederik
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4533/#review15003
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4533/
---
(Updated April 1, 2015, 3:59 a.m.)
Review request for Asterisk
On March 31, 2015, 6:21 p.m., rmudgett wrote:
/branches/13/main/utils.c, lines 492-493
https://reviewboard.asterisk.org/r/4555/diff/5/?file=73346#file73346line492
Revert this. This change could affect the callers of the function
since you are changing the API. However, no
The following is the output
[root@stnrd5652 testsuite]# ls /usr/lib/asterisk/modules | grep pjsip
chan_pjsip.so
func_pjsip_aor.so
func_pjsip_contact.so
func_pjsip_endpoint.so
res_hep_pjsip.so
res_pjsip_acl.so
res_pjsip_authenticator_digest.so
res_pjsip_caller_id.so
res_pjsip_config_wizard.so
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4557/#review14969
---
Ship it!
Ship It!
- Joshua Colp
On March 29, 2015, 6:30
On March 31, 2015, 3:19 p.m., Michael Young wrote:
I would hold off on committing this patch as I feel it is not really a
proper solution. I believe that this is just short circuiting the
conditional and always applying remapping if IPv6 is involved or not. On
the issue tracker,
Got it !!!
The testsuite was looking for these modules in /usr/lib64.
I recompiled the asterisk with --libdir=/usr/lib64 and it works.
Now the test is running
I will start working on it now.
Thank you.
On Tue, Mar 31, 2015 at 6:09 PM, Yaron Nachum nachum.ya...@gmail.com
wrote:
The following
Another thing that is important is that the sample configs must be
installed.
Many tests have some difficulty if this is not the case. For me it was
because
I had configurations defining the same endpoints with chan_sip and
chan_pjsip.
The conflicting configs caused crashes in tests that did not
On March 31, 2015, 10:25 a.m., Matt Jordan wrote:
/team/group/dns/main/dns_naptr.c, lines 447-449
https://reviewboard.asterisk.org/r/4542/diff/2/?file=73012#file73012line447
Suggestion: since this is repeated after each check, you may want to
macro-tize it:
#define
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4563/#review14973
---
I would hold off on committing this patch as I feel it is not
Thank you mathew,
The pjproject was detected on the installation process. When I run Asterisk
I see that pjsip modules are running.
Any idea?
Yaron
On Tue, Mar 31, 2015 at 4:12 PM, Matthew Jordan mjor...@digium.com wrote:
On Tue, Mar 31, 2015 at 8:04 AM, Yaron Nachum nachum.ya...@gmail.com
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4563/#review14970
---
Ship it!
Ship It!
- Joshua Colp
On March 30, 2015, 2:23
On March 31, 2015, 3:19 p.m., Michael Young wrote:
I would hold off on committing this patch as I feel it is not really a
proper solution. I believe that this is just short circuiting the
conditional and always applying remapping if IPv6 is involved or not. On
the issue tracker,
On Tue, Mar 31, 2015 at 9:00 AM, Yaron Nachum nachum.ya...@gmail.com wrote:
Thank you mathew,
The pjproject was detected on the installation process. When I run Asterisk
I see that pjsip modules are running.
The dependency checking for Asterisk assumes that the Asterisk modules
are all
On Tue, Mar 31, 2015 at 10:29 AM, Richard Mudgett rmudg...@digium.com wrote:
Another thing that is important is that the sample configs must be
installed.
Many tests have some difficulty if this is not the case. For me it was
because
I had configurations defining the same endpoints with
On March 31, 2015, 10:28 a.m., Mark Michelson wrote:
/trunk/main/dns_srv.c, lines 98-100
https://reviewboard.asterisk.org/r/4528/diff/2/?file=72947#file72947line98
Let's talk alignment.
In DNS, there is no padding used for variable-length elements. There is
no
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4520/
---
(Updated March 31, 2015, 10:58 a.m.)
Status
--
This change has been
On March 31, 2015, 5:50 p.m., Mark Michelson wrote:
/branches/13/apps/app_queue.c, lines 9089-9093
https://reviewboard.asterisk.org/r/4541/diff/1/?file=73002#file73002line9089
This change is not correct. While the mem-state_interface will always
be non-NULL (thanks, clang!), it
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4520/
---
(Updated March 31, 2015, 10:58 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4529/#review14980
---
Ship it!
Ship It!
- Mark Michelson
On March 28, 2015, 3:08
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4528/#review14981
---
Ship it!
Ship It!
- Mark Michelson
On March 31, 2015, 3:50
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4541/
---
(Updated March 31, 2015, 6:05 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4542/#review14984
---
/team/group/dns/include/asterisk/dns_internal.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4541/#review14985
---
Ship it!
There's only one finding left and it's just to swap
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4553/#review14983
---
Ship it!
Ship It!
- Mark Michelson
On March 28, 2015, 6:22
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4528/
---
(Updated March 31, 2015, 3:50 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4541/#review14978
---
/branches/13/apps/app_minivm.c
On 03/31/2015 01:51 AM, Olle E. Johansson wrote:
On 30 Mar 2015, at 16:54, Mark Michelson mmichel...@digium.com wrote:
On 03/28/2015 08:06 PM, Joshua Colp wrote:
George Joseph wrote:
The fact that it goes to unavailable would be a bug. Why does it do so?
Mark should probably chime in here
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4542/#review14972
---
/team/group/dns/include/asterisk/dns_internal.h
On March 31, 2015, 12:14 p.m., Mark Michelson wrote:
I don't understand the purpose of this warning. I tried searching for
details about this warning flag on the internet and came up empty, so I
can't find any documentation that explains what type of error this check is
supposed to
On Tue, Mar 31, 2015 at 2:32 PM, Matthew Jordan mjor...@digium.com wrote:
Hey everyone:
Hi!
Just as a brief status update on the Asterisk Git Migration project,
here is where we stand today, and what the next steps are:
Awesome work so far. :-)
There's a large amount of intervening
On March 31, 2015, 12:23 p.m., Mark Michelson wrote:
One thing to take into consideration here is that there are some places
within Asterisk where we will send an AST_CONTROL_UNHOLD frame on a
channel, even though it may not currently be on hold. This means you may
send some unhold
On March 31, 2015, 7:14 p.m., Mark Michelson wrote:
I don't understand the purpose of this warning. I tried searching for
details about this warning flag on the internet and came up empty, so I
can't find any documentation that explains what type of error this check is
supposed to
On March 31, 2015, 5:23 p.m., Mark Michelson wrote:
One thing to take into consideration here is that there are some places
within Asterisk where we will send an AST_CONTROL_UNHOLD frame on a
channel, even though it may not currently be on hold. This means you may
send some unhold
On March 31, 2015, 7:14 p.m., Mark Michelson wrote:
I don't understand the purpose of this warning. I tried searching for
details about this warning flag on the internet and came up empty, so I
can't find any documentation that explains what type of error this check is
supposed to
Ashley Sanders has posted comments on this change.
Change subject: Rewrite sip_attended_transfer test to stop failing.
..
Patch Set 2: Code-Review-1
(6 comments)
Overall, this is pretty good. The flow was mostly easy to
On March 31, 2015, 10:25 a.m., Matt Jordan wrote:
/team/group/dns/main/dns_naptr.c, lines 447-449
https://reviewboard.asterisk.org/r/4542/diff/2/?file=73012#file73012line447
Suggestion: since this is repeated after each check, you may want to
macro-tize it:
#define
Ashley Sanders has posted comments on this change.
Change subject: Add SIP attended transfer for Asterisk 11.
..
Patch Set 1: Code-Review-1
(1 comment)
I think that most of this could be collapsed into the logic for the test
Mark Michelson has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 1:
(10 comments)
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4552/#review14989
---
Ship it!
Ship It!
- Mark Michelson
On March 28, 2015, 5:08
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4549/#review14988
---
One thing to take into consideration here is that there are
On March 31, 2015, 7:14 p.m., Mark Michelson wrote:
I don't understand the purpose of this warning. I tried searching for
details about this warning flag on the internet and came up empty, so I
can't find any documentation that explains what type of error this check is
supposed to
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4541/
---
(Updated March 31, 2015, 7:15 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4550/#review14987
---
I don't understand the purpose of this warning. I tried
Mark Michelson has posted comments on this change.
Change subject: Rewrite sip_attended_transfer test to stop failing.
..
Patch Set 2:
(6 comments)
Thanks for the review!
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4528/#review14971
---
/trunk/main/dns_srv.c
Ashley Sanders has posted comments on this change.
Change subject: Memory Debugging Improvements
..
Patch Set 3:
Would it be possible for you to post a sample output file?
--
To view, visit https://gerrit.asterisk.org/15
To
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4549/#review14967
---
/branches/13/funcs/func_holdintercept.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4519/#review14968
---
Ship it!
./branches/13/apps/app_stasis.c
On Tue, Mar 31, 2015 at 1:48 PM, Russell Bryant
russ...@russellbryant.net wrote:
On Tue, Mar 31, 2015 at 2:32 PM, Matthew Jordan mjor...@digium.com wrote:
snip
There's a large amount of intervening work that has to be done, and
some questions that still need to be answered. In no particular
Ashley Sanders has posted comments on this change.
Change subject: Memory Debugging Improvements
..
Patch Set 3: Code-Review-1
(1 comment)
I only have one finding - a misspelling.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4519/
---
(Updated March 31, 2015, 4:54 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4108/#review14995
---
This approach is much simpler and easier to understand than
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4519/
---
(Updated March 31, 2015, 5 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4554/#review14999
---
I dislike this warning. It is more nuisance than helpful. I
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4555/#review15000
---
/branches/13/main/utils.c
On March 31, 2015, 5:52 p.m., rmudgett wrote:
/trunk/main/astobj2.c, line 798
https://reviewboard.asterisk.org/r/4108/diff/5/?file=71780#file71780line798
I think you need to have a weakproxy destructor callback that performs
a sanity check on the proxy object to ensure that it is
82 matches
Mail list logo
