Re: [asterisk-dev] [Code Review] 4578: res_pjsip_phoneprov_provider: Fix leaked OBJ_MULTIPLE iterator.

2015-04-05 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4578/ --- (Updated April 5, 2015, 7:54 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4573: trunk: Can't touch this

2015-04-05 Thread Matt Jordan
> On April 2, 2015, 1:49 a.m., Olle E Johansson wrote: > > So typical US-centric. The rest of the world has moved to Unicode-art. > > ◼️🔲⚫️🔲◼️ > > > > 🔁 Please add this to the agenda of the Asterisk-internationalization > > meeting in Stockholm next month. We also need to discuss the babel-fis

Re: [asterisk-dev] [Code Review] 4573: trunk: Can't touch this

2015-04-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4573/ --- (Updated April 5, 2015, 8:29 p.m.) Status -- This change has been dis

Re: [asterisk-dev] [Code Review] 4490: astdb: Allow clustering of the Asterisk Database between multiple Asterisk servers

2015-04-05 Thread Matt Jordan
> On April 2, 2015, 2:41 p.m., Mark Michelson wrote: > > /trunk/main/db.c, lines 958-977 > > > > > > The dialplan function allows an omitted type to automatically be > > interpreted as "global" but the CLI command

[asterisk-dev] Change in testsuite[master]: channels/pjsip/publish/asterisk_event_db: Add AstDB clusteri...

2015-04-05 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new patch set (#2). Change subject: channels/pjsip/publish/asterisk_event_db: Add AstDB clustering tests .. channels/pjsip/publish/asterisk_event_db: Add AstDB clustering tests This test verifies that

Re: [asterisk-dev] [Code Review] 4490: astdb: Allow clustering of the Asterisk Database between multiple Asterisk servers

2015-04-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4490/ --- (Updated April 5, 2015, 9:22 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4549: ARI: Add the ability to intercept hold and raise an event

2015-04-05 Thread Matt Jordan
> On March 31, 2015, 8:21 a.m., Joshua Colp wrote: > > /branches/13/res/stasis/control.c, lines 609-622 > > > > > > This is substantially changing the behavior. > > > > ast_indicate will tell the channel to

Re: [asterisk-dev] [Code Review] 4549: ARI: Add the ability to intercept hold and raise an event

2015-04-05 Thread Matt Jordan
> On March 31, 2015, 12:23 p.m., Mark Michelson wrote: > > One thing to take into consideration here is that there are some places > > within Asterisk where we will send an AST_CONTROL_UNHOLD frame on a > > channel, even though it may not currently be on hold. This means you may > > send some

Re: [asterisk-dev] [Code Review] 4549: ARI: Add the ability to intercept hold and raise an event

2015-04-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4549/ --- (Updated April 5, 2015, 9:39 p.m.) Review request for Asterisk Developers

[asterisk-dev] Change in testsuite[master]: tests/rest_api/channels/hold: Add a default Hold action test

2015-04-05 Thread Matt Jordan (Code Review)
Matt Jordan has abandoned this change. Change subject: tests/rest_api/channels/hold: Add a default Hold action test .. Abandoned -- To view, visit https://gerrit.asterisk.org/17 To unsubscribe, visit https://gerrit.asterisk.or

[asterisk-dev] Change in testsuite[master]: tests/rest_api/channels: Add a channel hold intercept test

2015-04-05 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new patch set (#3). Change subject: tests/rest_api/channels: Add a channel hold intercept test .. tests/rest_api/channels: Add a channel hold intercept test This test verifies that a channel that initi

[asterisk-dev] Change in testsuite[master]: tests/rest_api/channels: Add a channel hold intercept test

2015-04-05 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new patch set (#3). Change subject: tests/rest_api/channels: Add a channel hold intercept test .. tests/rest_api/channels: Add a channel hold intercept test This test verifies that a channel that initi

[asterisk-dev] [BOUNTY] ASTERISK-24795 Park/Pickup CLID Issue

2015-04-05 Thread Derek Bolichowski
Please review https://issues.asterisk.org/jira/browse/ASTERISK-24795 We're offering a bounty for anyone who is willing to work directly with us to resolve this issue. We have a custom developed asterisk cluster that has an issue where when an external call is made, parked, then picked up, the C