---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3125/#review10621
---
Ship it!
Ship It!
- Mark Michelson
On Jan. 13, 2014, 11:26
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3133/
---
Review request for Asterisk Developers.
Repository: Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3129/#review10622
---
Ship it!
Ship It!
- Mark Michelson
On Jan. 16, 2014, 8:56
On Jan. 16, 2014, 5 p.m., Mark Michelson wrote:
/branches/12/main/http.c, line 813
https://reviewboard.asterisk.org/r/3125/diff/2/?file=52892#file52892line813
chunked_atoh shouldn't be necessary. You should be able to just use:
sscanf(chunk_header, %x, chunk_length);
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3133/
---
(Updated Jan. 17, 2014, 9:46 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3051/#review10619
---
Without going into the functionality of the patch, a few
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3131/#review10623
---
Ship it!
Because my comments are so minor, I'm going ahead
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3118/#review10624
---
Ship it!
Ship It!
- Mark Michelson
On Jan. 16, 2014, 8:26
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3122/#review10625
---
branches/12/res/ari/resource_channels.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3134/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-22861
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3130/#review10626
---
Ship it!
Ship It!
- Mark Michelson
On Jan. 16, 2014, 6:33
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3125/#review10627
---
Ship it!
The chunked decode looks good according to the RFC!
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3125/
---
(Updated Jan. 17, 2014, 2:51 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3126/
---
(Updated Jan. 17, 2014, 2:58 p.m.)
Status
--
This change has been
On Jan. 17, 2014, 12:38 p.m., Kevin Harwell wrote:
branches/12/res/ari/resource_channels.c, lines 753-756
https://reviewboard.asterisk.org/r/3122/diff/2/?file=51449#file51449line753
I'm sure you looked into this, but is there no way to have this block
of code in the auto
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3131/
---
(Updated Jan. 17, 2014, 3:53 p.m.)
Status
--
This change has been
On Jan. 16, 2014, 11:16 a.m., Sean Bright wrote:
/trunk/channels/chan_sip.c, lines 13419-13421
https://reviewboard.asterisk.org/r/2723/diff/5/?file=44381#file44381line13419
Shouldn't this be a_audio instead of a_text, or does it matter?
Good catch - feel free to patch away
- Matt
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3135/
---
Review request for Asterisk Developers and leifmadsen.
Repository:
On Jan. 16, 2014, 5:16 p.m., Sean Bright wrote:
/trunk/channels/chan_sip.c, lines 13419-13421
https://reviewboard.asterisk.org/r/2723/diff/5/?file=44381#file44381line13419
Shouldn't this be a_audio instead of a_text, or does it matter?
Matt Jordan wrote:
Good catch - feel
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3136/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-23092
Greetings,
When a subscription to MWI comes into the res_pjsip_mwi module it will
attempt to extract an aor_name from the URI on the request. Currently
a warning message is logged and the request is rejected if a suitable
AoR cannot be found by the given name.
But what should happen if the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3136/#review10632
---
Not sure this is a good idea. First, I wouldn't hardcode a
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3135/#review10631
---
/branches/1.8/main/channel.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3134/#review10633
---
Only the corryfarrel patch is needed. The other patch is not
On Jan. 17, 2014, 11:50 p.m., rmudgett wrote:
/branches/1.8/main/channel.c, lines 3576-3579
https://reviewboard.asterisk.org/r/3135/diff/1/?file=52962#file52962line3576
This should not be done at all.
You are dropping a reference when timingdata doesn't really hold the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3135/
---
(Updated Jan. 18, 2014, 12:58 a.m.)
Review request for Asterisk
26 matches
Mail list logo
