Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

2014-07-30 Thread Corey Farrell
On July 17, 2014, 5:41 p.m., Matt Jordan wrote: /trunk/main/stasis_channels.c, lines 1071-1077 https://reviewboard.asterisk.org/r/3811/diff/1/?file=64565#file64565line1071 I'm not sure why these changes (removal of the .to_ami callback) were necessary. Generally, I

[asterisk-dev] [Code Review] 3867: [chan_sip] Default DTLS settings to use if peer misses own settings

2014-07-30 Thread Michael K.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3867/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24128

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

2014-07-30 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3603/#review12921 --- /branches/11/funcs/func_jitterbuffer.c

Re: [asterisk-dev] [Code Review] 3833: Allow sending voicemail to multiple email addresses

2014-07-30 Thread abelbeck
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3833/#review12922 --- trunk/apps/app_voicemail.c

Re: [asterisk-dev] [Code Review] 3833: Allow sending voicemail to multiple email addresses

2014-07-30 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3833/#review12923 --- trunk/apps/app_voicemail.c

[asterisk-dev] [Code Review] 3870: alembic: Adjust sippeers, queue_members, and voicemail_messages tables.

2014-07-30 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3870/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23825,

[asterisk-dev] [Code Review] 3869: res_pjsip_publish_asterisk: Inbound and outbound device state test

2014-07-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3869/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24115

Re: [asterisk-dev] [Code Review] 3607: [app_queue] Add the optional ability to load queue rules from realtime.

2014-07-30 Thread Michael K.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3607/ --- (Updated July 30, 2014, 3:07 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3607: [app_queue] Add the optional ability to load queue rules from realtime.

2014-07-30 Thread Michael K.
On July 29, 2014, 2:57 p.m., Mark Michelson wrote: trunk/apps/app_queue.c, line 2748 https://reviewboard.asterisk.org/r/3607/diff/4/?file=61358#file61358line2748 The file is extconfig.conf, not extconfigs.conf typo :P - Michael

Re: [asterisk-dev] [Code Review] 3842: Tests the forward and reverse playback ARI functions for both channels and bridges

2014-07-30 Thread Christopher Wolfe
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3842/ --- (Updated July 30, 2014, 3:27 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3726: ari: Add message technology agnostic out of call text messaging

2014-07-30 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3726/#review12920 --- /branches/12/include/asterisk/json.h

Re: [asterisk-dev] [Code Review] 3867: [chan_sip] Default DTLS settings to use if peer misses own settings

2014-07-30 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3867/#review12924 --- trunk/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3607: [app_queue] Add the optional ability to load queue rules from realtime.

2014-07-30 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3607/#review12926 --- Ship it! Ship It! - Mark Michelson On July 30, 2014, 3:07

[asterisk-dev] [Code Review] 3872: Tests the various ARI channel muting applications (the both, in, and out directions)

2014-07-30 Thread Christopher Wolfe
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3872/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24094

[asterisk-dev] [Code Review] 3873: Testsuite: RLS tests - nominal presence lists

2014-07-30 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3873/ --- Review request for Asterisk Developers and Mark Michelson. Bugs:

Re: [asterisk-dev] [Code Review] 3807: xmldoc: Add support for an example tag in the Asterisk XML documentation

2014-07-30 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3807/#review12927 --- Ship it! Ship It! - Mark Michelson On July 28, 2014, 7:03

Re: [asterisk-dev] [Code Review] 3873: Testsuite: RLS tests - nominal presence lists

2014-07-30 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3873/#review12928 ---

Re: [asterisk-dev] [Code Review] 3799: manager: Add ExtensionStateList, PresenceStateList, and DeviceStateList commands

2014-07-30 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3799/ --- (Updated July 30, 2014, 1:32 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3874: Add tests for the DeviceStateList, PresenceStateList, and ExtensionStateList AMI actions

2014-07-30 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3874/ --- Review request for Asterisk Developers and Matt Jordan. Repository:

Re: [asterisk-dev] [Code Review] 3874: Add tests for the DeviceStateList, PresenceStateList, and ExtensionStateList AMI actions

2014-07-30 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3874/ --- (Updated July 30, 2014, 2:47 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3873: Testsuite: RLS tests - nominal presence lists

2014-07-30 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3873/ --- (Updated July 30, 2014, 2:54 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 3875: Testsuite: RLS tests - nominal MWI lists

2014-07-30 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3875/ --- Review request for Asterisk Developers and Mark Michelson. Bugs:

Re: [asterisk-dev] [Code Review] 3854: manager.c - Improve documentation for manager command Getvar, Setvar

2014-07-30 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3854/ --- (Updated July 30, 2014, 10:40 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3854: manager.c - Improve documentation for manager command Getvar, Setvar

2014-07-30 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3854/#review12930 --- /branches/1.8/main/manager.c

Re: [asterisk-dev] [Code Review] 3854: manager.c - Improve documentation for manager command Getvar, Setvar

2014-07-30 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3854/ --- (Updated July 30, 2014, 10:45 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3854: manager.c - Improve documentation for manager command Getvar, Setvar

2014-07-30 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3854/ --- (Updated July 30, 2014, 10:52 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

2014-07-30 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3603/ --- (Updated July 30, 2014, 7:19 p.m.) Review request for Asterisk