Re: [asterisk-dev] [Code Review] 3982: res_rtp_asterisk: Fix a slew of TURN issues.

2014-09-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3982/ --- (Updated Sept. 10, 2014, 11:24 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3985: realtime configuration: anything that goes through ast_destroy_realtime crashes if only a single key/value pair is used.

2014-09-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3985/#review13269 --- /branches/12/main/config.c

Re: [asterisk-dev] [Code Review] 3986: config: bug: fix truncation of included config files on permissions error

2014-09-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3986/#review13270 --- Ship it! Ship It! - Joshua Colp On Sept. 10, 2014, 1:34

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/#review13271 --- /branches/13/res/res_pjsip.c

Re: [asterisk-dev] [Code Review] 3978: Testsuite: Test for RLS large NOTIFY requests

2014-09-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3978/#review13272 --- Ship it! Ship It! - Joshua Colp On Sept. 4, 2014, 8:11

Re: [asterisk-dev] [Code Review] 3985: realtime configuration: anything that goes through ast_destroy_realtime crashes if only a single key/value pair is used.

2014-09-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3985/#review13273 --- - Joshua Colp On Sept. 9, 2014, 5:04 p.m., Jonathan Rose

Re: [asterisk-dev] [Code Review] 3986: config: bug: fix truncation of included config files on permissions error

2014-09-10 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3986/#review13275 --- Ship it! Ship It! - rmudgett On Sept. 9, 2014, 8:34 p.m.,

Re: [asterisk-dev] [Code Review] 3978: Testsuite: Test for RLS large NOTIFY requests

2014-09-10 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3978/ --- (Updated Sept. 10, 2014, 10:44 a.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3987: Bridging: Fix bouncing native bridge

2014-09-10 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3987/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24211

Re: [asterisk-dev] [Code Review] 3987: Bridging: Fix bouncing native bridge

2014-09-10 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3987/ --- (Updated Sept. 10, 2014, 10:56 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-10 Thread Joshua Colp
On Sept. 10, 2014, 11:51 a.m., Joshua Colp wrote: /branches/13/res/res_pjsip.c, lines 2478-2480 https://reviewboard.asterisk.org/r/3954/diff/3/?file=67221#file67221line2478 I'm hesitant to say that this will always be true. I fear that due to the asynchronous nature of things

[asterisk-dev] SIPit 31

2014-09-10 Thread Matthew Jordan
Hey everyone - Myself, Joshua Colp, and Olle Johansson will all be at SIPit 31 this year. For myself and Josh, we're going to be focussing heavily on testing out the PJSIP stack in Asterisk 13 - I'm sure Olle will be up to all sorts of torturous tests with both Kamailio and Asterisk! If you're

Re: [asterisk-dev] [Code Review] 3986: config: bug: fix truncation of included config files on permissions error

2014-09-10 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3986/ --- (Updated Sept. 10, 2014, 10:58 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-10 Thread rmudgett
On Sept. 10, 2014, 6:51 a.m., Joshua Colp wrote: /branches/13/res/res_pjsip.c, line 2443 https://reviewboard.asterisk.org/r/3954/diff/3/?file=67221#file67221line2443 unsigned int Sure, if you want. On Sept. 10, 2014, 6:51 a.m., Joshua Colp wrote: /branches/13/res/res_pjsip.c,

[asterisk-dev] [Code Review] 3988: res_pjsip: Don't require a password when doing userpass authentication

2014-09-10 Thread Sean Bright
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3988/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3988: res_pjsip: Don't require a password when doing userpass authentication

2014-09-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3988/#review13278 --- /branches/12/res/res_pjsip/config_auth.c

Re: [asterisk-dev] [Code Review] 3985: realtime configuration: anything that goes through ast_destroy_realtime crashes if only a single key/value pair is used.

2014-09-10 Thread Jonathan Rose
On Sept. 10, 2014, 6:33 a.m., Joshua Colp wrote: /branches/12/main/config.c, lines 3147-3149 https://reviewboard.asterisk.org/r/3985/diff/1/?file=67294#file67294line3147 It's still possible for this to occur under extreme circumstances (out of memory). Joshua Colp wrote:

Re: [asterisk-dev] [Code Review] 3985: realtime configuration: anything that goes through ast_destroy_realtime crashes if only a single key/value pair is used.

2014-09-10 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3985/ --- (Updated Sept. 10, 2014, 4:31 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-10 Thread rmudgett
On Sept. 10, 2014, 6:51 a.m., Joshua Colp wrote: /branches/13/res/res_pjsip.c, lines 2478-2480 https://reviewboard.asterisk.org/r/3954/diff/3/?file=67221#file67221line2478 I'm hesitant to say that this will always be true. I fear that due to the asynchronous nature of things (was

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-10 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/ --- (Updated Sept. 10, 2014, 5:18 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3989: utils: Create ast_strsep function that ignores separators inside quotes.

2014-09-10 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3989/ --- Review request for Asterisk Developers and rmudgett. Repository: Asterisk

[asterisk-dev] chan_sip.c:23647 handle_request_invite: Failed to authenticate device

2014-09-10 Thread Deepak Bhatia
Hi, Why are we getting message in the asterisk [Sep 10 12:55:23] NOTICE[15043]: chan_sip.c:23647 handle_request_invite: Failed to authenticate device 601sip:601@111.118.185.107; tag=2f498fbd [Sep 10 12:55:24] NOTICE[15043]: chan_sip.c:23647 handle_request_invite: Failed to authenticate device