Re: [asterisk-dev] [Code Review] 2764: Add edit-MASTER-channel option to CHANNEL() function. To work around channel optimization removing my channel settings.

2014-09-15 Thread wdoekes
On Aug. 21, 2013, 1:47 p.m., Matt Jordan wrote: Why not use pre-dial to put the musicclass directly on the channel that will survive, as opposed to the Local channel? Because I have no pre-dial in this old branch, mostly. But now I don't need it on the local channel anymore. Thanks for

Re: [asterisk-dev] [Code Review] 3993: config: bug: Fix SEGV in ast_category_insert when a matching category isn't found

2014-09-15 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3993/#review13298 --- branches/1.8/main/config.c

Re: [asterisk-dev] [Code Review] 3993: config: bug: Fix SEGV in ast_category_insert when a matching category isn't found

2014-09-15 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3993/ --- (Updated Sept. 15, 2014, 9:03 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3992: res_pjsip_sdp_rtp: Add optimistic SRTP support.

2014-09-15 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3992/#review13301 --- This change appears to render the media_use_received_transport

Re: [asterisk-dev] [Code Review] 3992: res_pjsip_sdp_rtp: Add optimistic SRTP support.

2014-09-15 Thread Joshua Colp
On Sept. 15, 2014, 4:14 p.m., opticron wrote: This change appears to render the media_use_received_transport configuration option non-functional since it removes all checks relating to it. It'll still work, the difference is on received it is always done and the outgoing check has

[asterisk-dev] [Code Review] 3994: Bridges User Documentation Update

2014-09-15 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3994/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23469 None

Re: [asterisk-dev] [Code Review] 3916: Testsuite: Add test for AllVariables Status parameter

2014-09-15 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3916/#review13303 --- Ship it!

[asterisk-dev] [Code Review] 3995: res_pjsip_endpoint_identifier_ip: Can't parse identify with match value containing CIDR

2014-09-15 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3995/ --- Review request for Asterisk Developers and Joshua Colp. Bugs:

Re: [asterisk-dev] [Code Review] 3988: res_pjsip: Don't require a password when doing userpass authentication

2014-09-15 Thread Sean Bright
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3988/ --- (Updated Sept. 15, 2014, 7:27 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3988: res_pjsip: Don't require a password when doing userpass authentication

2014-09-15 Thread Sean Bright
On Sept. 10, 2014, 6:25 p.m., Joshua Colp wrote: /branches/12/res/res_pjsip/config_auth.c, line 116 https://reviewboard.asterisk.org/r/3988/diff/1/?file=67303#file67303line116 Test this and make sure that the PJSIP digest authentication doesn't freak. :P Confirmed that no

Re: [asterisk-dev] [Code Review] 3989: utils: Create ast_strsep function that ignores separators inside quotes.

2014-09-15 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3989/#review13305 --- branches/12/include/asterisk/strings.h

Re: [asterisk-dev] [Code Review] 3989: utils: Create ast_strsep function that ignores separators inside quotes.

2014-09-15 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3989/ --- (Updated Sept. 15, 2014, 1:43 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3996: Fix zero duration vm description when using MixMonitor m option

2014-09-15 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3996/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3996: Fix zero duration vm description when using MixMonitor m option

2014-09-15 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3996/ --- (Updated Sept. 15, 2014, 4:37 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3996: Fix zero duration vm description when using MixMonitor m option

2014-09-15 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3996/#review13306 --- This seems to only be a problem in v13+ and should not be

Re: [asterisk-dev] [Code Review] 3971: astobj2.c/refcounter.py: Fix to deal with invalid object refs.

2014-09-15 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3971/#review13307 --- /branches/1.8/contrib/scripts/refcounter.py

Re: [asterisk-dev] [Code Review] 3971: astobj2.c/refcounter.py: Fix to deal with invalid object refs.

2014-09-15 Thread rmudgett
On Sept. 15, 2014, 6:07 p.m., Corey Farrell wrote: /branches/1.8/contrib/scripts/refcounter.py, lines 118-119 https://reviewboard.asterisk.org/r/3971/diff/1/?file=67190#file67190line118 This can be optimized if invalid objects are given curcount == -1, that way it wouldn't have