[asterisk-dev] [Code Review] 4112: testsuite: Make tests/fax/pjsip/* depend on chan_pjsip

2014-10-27 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4112/ --- Review request for Asterisk Developers. Repository: testsuite

[asterisk-dev] [Code Review] 4113: func_cdr: CDR_PROP leaks payload

2014-10-27 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4113/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24455

Re: [asterisk-dev] [Code Review] 4113: func_cdr: CDR_PROP leaks payload

2014-10-27 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4113/#review13593 --- Ship it! Ship It! - wdoekes On Oct. 27, 2014, 8:03 a.m.,

Re: [asterisk-dev] [Code Review] 4111: app_queue: ao2_iterator not destroyed, causing leak

2014-10-27 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4111/#review13594 --- Ship it! Ship It! - wdoekes On Oct. 27, 2014, 5:53 a.m.,

[asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

2014-10-27 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4114/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24307

Re: [asterisk-dev] [Code Review] 4112: testsuite: Make tests/fax/pjsip/* depend on chan_pjsip

2014-10-27 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4112/#review13595 --- Ship it! Sounds good. Note that the following three tests

Re: [asterisk-dev] [Code Review] 4115: res_fax: fax gateway frames leak

2014-10-27 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4115/ --- (Updated Oct. 27, 2014, 8:12 a.m.) Review request for Asterisk

[asterisk-dev] Dahdi building: autoconf generated configure script

2014-10-27 Thread Łukasz Wójcik
Hey there, I've got a trivial question I hope to get a quick response to :) I am fiddling with dahdi 2.10.0.1 on non-linux variant of UNIX. To be more specific, I am trying to build dahdi from sources, and am a bit confused about autoconf. It seems that 'configure' script generated using

Re: [asterisk-dev] [Code Review] 4115: res_fax: fax gateway frames leak

2014-10-27 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4115/#review13597 --- Ship it! Ship It! - wdoekes On Oct. 27, 2014, 12:12 p.m.,

Re: [asterisk-dev] [Code Review] 4111: app_queue: ao2_iterator not destroyed, causing leak

2014-10-27 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4111/#review13598 --- Ship it! Ship It! - rmudgett On Oct. 27, 2014, 12:53 a.m.,

Re: [asterisk-dev] [Code Review] 4110: manager: acl_change_sub leaks

2014-10-27 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4110/#review13599 --- Ship it! Ship It! - Matt Jordan On Oct. 27, 2014, 12:38

Re: [asterisk-dev] [Code Review] 4106: configure: Add autoconf check for libopus

2014-10-27 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4106/#review13600 --- Ship it! I think this is fine to go into 13. - Matt Jordan

Re: [asterisk-dev] [Code Review] 4106: configure: Add autoconf check for libopus

2014-10-27 Thread Sean Bright
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4106/ --- (Updated Oct. 27, 2014, 12:54 p.m.) Status -- This change has been

[asterisk-dev] AppKonference 2.6

2014-10-27 Thread Paul Albrecht
I have released an updated AppKonference that compiles with Asterisk 13. You can download the latest code from source forge: sourceforge.net/projects/appkonference That said Asterisk 13 doesn’t get that much attention because I use Asterisk 1.4 + some hacks. Here’s a link to my Asterisk 1.4

Re: [asterisk-dev] AstriDevCon 2014:Agenda item Deprecate AMI/AGI (Ben Klang)

2014-10-27 Thread Paul Albrecht
The reason the dial plan can never be deprecated is because Asterisk wouldn’t be Asterisk without the dial plan. Sure, you could re-engineer Asterisk so that it would be “better for a small select group of users at the expense of the majority of community that use the product as designed for

Re: [asterisk-dev] AstriDevCon 2014:Agenda item Deprecate AMI/AGI (Ben Klang)

2014-10-27 Thread Jeffrey Ollie
On Mon, Oct 27, 2014 at 2:04 PM, Paul Albrecht palbre...@glccom.com wrote: The reason the dial plan can never be deprecated is because Asterisk wouldn’t be Asterisk without the dial plan. Sure, you could re-engineer Asterisk so that it would be “better for a small select group of users at

[asterisk-dev] [Code Review] 4116: res_pjsip: incorrect qualify statistics after disabling for contact

2014-10-27 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4116/ --- Review request for Asterisk Developers and Mark Michelson. Bugs:

Re: [asterisk-dev] SRTP in chan_motif.c

2014-10-27 Thread Joshua Colp
dwal...@fifo99.com wrote: On Mon, Oct 27, 2014 at 07:01:10PM -0300, Joshua Colp wrote: As there is no crypto support written it is not possible to negotiate it. Support would have to be added. All 3 variants are implemented. Non-Documented Google, Google, and XEP. So Google Voice's protocol

Re: [asterisk-dev] SRTP in chan_motif.c

2014-10-27 Thread Joshua Colp
dwal...@fifo99.com wrote: On Mon, Oct 27, 2014 at 07:24:27PM -0300, Joshua Colp wrote: dwal...@fifo99.com wrote: On Mon, Oct 27, 2014 at 07:01:10PM -0300, Joshua Colp wrote: As there is no crypto support written it is not possible to negotiate it. Support would have to be added. All 3