Re: [asterisk-dev] Fwd: Code Review request of func_redis module

2015-05-12 Thread Sergio Medina Toledo
The part of the internal API that I used haven't changed from 11 to 13 so it should work without any problem. But I haven't tested the module intensively and I'm not sure if it is thread safe, so I don't recommend use it in production servers right now. Today I'm gonna install the module in an

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Tzafrir Cohen
On Tue, May 12, 2015 at 10:39:04AM -0600, George Joseph wrote: On Tue, May 12, 2015 at 10:08 AM, Jeffrey Ollie j...@ocjtech.us wrote: On Tue, May 12, 2015 at 9:47 AM, George Joseph george.jos...@fairview5.com wrote: On Tue, May 12, 2015 at 5:41 AM, Tzafrir Cohen tzafrir.co...@xorcom.com

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Jeffrey Ollie
On Tue, May 12, 2015 at 11:39 AM, George Joseph george.jos...@fairview5.com wrote: Hmmm. It just seems to me we're way over thinking this. Separate executables and a public APIs seems overkill for something that on;y needs to run for a few seconds on startup and reload. Hmm, yes, I guess

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Tzafrir Cohen
On Tue, May 12, 2015 at 11:15:40AM -0600, George Joseph wrote: The only volatile stats to be reported were active/total calls and I'd be willing to give that up to keep the process simple. Even if we did keep the calls, and it reported a few times a day I still don't see the need for the

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread George Joseph
On Tue, May 12, 2015 at 10:08 AM, Jeffrey Ollie j...@ocjtech.us wrote: On Tue, May 12, 2015 at 9:47 AM, George Joseph george.jos...@fairview5.com wrote: On Tue, May 12, 2015 at 5:41 AM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: On Mon, May 11, 2015 at 01:29:04PM -0600, George

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread George Joseph
On Tue, May 12, 2015 at 10:59 AM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: On Tue, May 12, 2015 at 10:39:04AM -0600, George Joseph wrote: On Tue, May 12, 2015 at 10:08 AM, Jeffrey Ollie j...@ocjtech.us wrote: On Tue, May 12, 2015 at 9:47 AM, George Joseph

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Jeffrey Ollie
On Tue, May 12, 2015 at 9:47 AM, George Joseph george.jos...@fairview5.com wrote: On Tue, May 12, 2015 at 5:41 AM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: On Mon, May 11, 2015 at 01:29:04PM -0600, George Joseph wrote: As for the other issues, why not just have asterisk fork itself on

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Scott Griepentrog
Correction: as one will end up getting a new ID (the second one to reuse the same token). On Tue, May 12, 2015 at 1:24 PM, Scott Griepentrog sgriepent...@digium.com wrote: So as opposed to spoofing, there is also the case that someone having a copy of Asteirsk in a virtual machine clones it,

Re: [asterisk-dev] Fwd: Code Review request of func_redis module

2015-05-12 Thread Ludovic Gasc
Don't worry, I understand it isn't production ready, I'll test that only on a dev instance. I don't know yet if I'll have skills to help you with pull requests, but at least, with tests and eventual bug reports. For now, it isn't really critical, because I've a daemon that plays as a Redis proxy

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Scott Griepentrog
So as opposed to spoofing, there is also the case that someone having a copy of Asteirsk in a virtual machine clones it, and ends up with two instances reporting the same random ID. With the spoofing detection mechanism (using tokens to get an ID from the server), the effect of this case is

Re: [asterisk-dev] Journald support for Asterisk

2015-05-12 Thread Ludovic Gasc
I've two remarks about that: 1. Even if a journald support is one day included in Asterisk, it will be for Asterisk 14 or 15 at least. The time you have that as stable version, it will be 2016 or 2017. Even if we already have some few CentOS on production because it's mandatory for some products,

Re: [asterisk-dev] Journald support for Asterisk

2015-05-12 Thread Ludovic Gasc
2015-05-12 13:48 GMT+02:00 Tzafrir Cohen tzafrir.co...@xorcom.com: On Mon, May 11, 2015 at 11:26:31PM +0200, Ludovic Gasc wrote: The idea behind structured log is to retrieve easily a context with a log to reduce the effort of categorization after, because you don't need to parse and

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Tzafrir Cohen
Quoting the spec: | Spoofing | | In order to limit spoofing, the server will return a token for all | accepted requests to a server. Any subsequent requests to that resource | must present the token in the request. If a subsequent request fails to | provide the token, the request is rejected.

Re: [asterisk-dev] systemd sd_notify() [was: Re: Journald support for Asterisk]

2015-05-12 Thread Matthew Jordan
On Sun, May 10, 2015 at 3:03 AM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: On Sat, May 09, 2015 at 10:17:24AM +0200, Ludovic Gasc wrote: Hi, Systemd and Journald is now by default on Debian Jessie and Ubuntu 15.04, as on RHEL/CentOS. Journald supports syslog format, nevertheless, at

Re: [asterisk-dev] (unreported) uninitialized: struct ast_sockaddr

2015-05-12 Thread Matthew Jordan
On Mon, May 11, 2015 at 9:16 AM, Alexander Traud pabstr...@compuserve.com wrote: B) Change my patch not to use a char* but char[128]. Your easiest option with less chance of regression elsewhere would be this. Yes. Anyway: Is the Asterisk team interested in a patch at least for the 5 affected

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Tzafrir Cohen
On Mon, May 11, 2015 at 01:29:04PM -0600, George Joseph wrote: As for the other issues, why not just have asterisk fork itself on startup and reloads just to send the stats. No separate executables, no AMI, no cron, and you get the process separation so a segv or orthe rerror doesn't kill

Re: [asterisk-dev] Journald support for Asterisk

2015-05-12 Thread Tzafrir Cohen
On Mon, May 11, 2015 at 11:26:31PM +0200, Ludovic Gasc wrote: The idea behind structured log is to retrieve easily a context with a log to reduce the effort of categorization after, because you don't need to parse and recognize patterns in log message. Technically, instead of to have a

Re: [asterisk-dev] Journald support for Asterisk

2015-05-12 Thread Jeffrey Ollie
On Sat, May 9, 2015 at 9:15 AM, Bruce Ferrell bferr...@baywinds.org wrote: systemd and journald SUCK to high heaven. I have no idea if the issues I've had with them (OpenSUSE) are distro related or inherent. You're welcome to your opinion, but I find systemd/journald very nice. I'd welcome

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread George Joseph
On Tue, May 12, 2015 at 5:41 AM, Tzafrir Cohen tzafrir.co...@xorcom.com wrote: On Mon, May 11, 2015 at 01:29:04PM -0600, George Joseph wrote: As for the other issues, why not just have asterisk fork itself on startup and reloads just to send the stats. No separate executables, no AMI, no