Re: [asterisk-dev] [Code Review] 3488: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality.

2015-03-12 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3488/ --- (Updated March 12, 2015, 9:19 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3488: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality.

2015-01-25 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3488/#review14277 --- A few remarks before noting some additional issues: First,

Re: [asterisk-dev] [Code Review] 3488: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality.

2015-01-25 Thread Diederik de Groot
On Jan. 25, 2015, 11:25 p.m., Matt Jordan wrote: A few remarks before noting some additional issues: First, thanks again for providing the patch to get Asterisk to compile under clang. It's definitely a large first step in the right direction. Second, sorry for not replying again

Re: [asterisk-dev] [Code Review] 3488: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality.

2015-01-25 Thread Diederik de Groot
On Jan. 25, 2015, 11:25 p.m., Matt Jordan wrote: /trunk/configure.ac, lines 1094-1097 https://reviewboard.asterisk.org/r/3488/diff/2/?file=58453#file58453line1094 This will actually always fail, causing gcc to fail to compile Asterisk. The AC_LANG_PROGRAM macro will

Re: [asterisk-dev] [Code Review] 3488: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality.

2014-05-15 Thread Diederik de Groot
On May 15, 2014, 4:50 a.m., Matt Jordan wrote: Hi Matt, Thank you for your review ! On May 15, 2014, 4:50 a.m., Matt Jordan wrote: /trunk/configure.ac, line 1092 https://reviewboard.asterisk.org/r/3488/diff/1/?file=57985#file57985line1092 red blob On May 15, 2014, 4:50

Re: [asterisk-dev] [Code Review] 3488: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality.

2014-05-15 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3488/ --- (Updated May 15, 2014, 10:57 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3488: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality.

2014-05-14 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3488/#review11849 --- /trunk/configure.ac

[asterisk-dev] [Code Review] 3488: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality.

2014-04-28 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3488/ --- Review request for Asterisk Developers. Summary (updated)

Re: [asterisk-dev] [Code Review] 3488: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality.

2014-04-28 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3488/ --- (Updated April 28, 2014, 1:28 p.m.) Review request for Asterisk