Re: [asterisk-dev] [Code Review] 4441: Enable TLS Dual-Certificates (ECC+RSA)

2015-04-13 Thread Alexander Traud
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4441/ --- (Updated April 13, 2015, 1:30 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4441: Enable TLS Dual-Certificates (ECC+RSA)

2015-04-13 Thread Alexander Traud
On April 10, 2015, 5:45 p.m., rmudgett wrote: trunk/main/tcptls.c, lines 841-858 https://reviewboard.asterisk.org/r/4441/diff/2/?file=73366#file73366line841 This is effectively the same code duplicated for ecc and dsa. Make a subroutine that takes the variants as parameters:

Re: [asterisk-dev] [Code Review] 4441: Enable TLS Dual-Certificates (ECC+RSA)

2015-04-13 Thread Alexander Traud
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4441/ --- (Updated April 13, 2015, 1:28 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4441: Enable TLS Dual-Certificates (ECC+RSA)

2015-03-31 Thread Olle E Johansson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4441/#review14966 --- Thank you for working on the TLS code, we surely need more

Re: [asterisk-dev] [Code Review] 4441: Enable TLS Dual-Certificates (ECC+RSA)

2015-03-30 Thread Alexander Traud
On Feb. 24, 2015, 5:20 p.m., rmudgett wrote: trunk/main/tcptls.c, line 836 https://reviewboard.asterisk.org/r/4441/diff/1/?file=71569#file71569line836 It doesn't look like there is a standard cert file naming convention to name the files example_rsa.pem, example_ecc.pem, and

Re: [asterisk-dev] [Code Review] 4441: Enable TLS Dual-Certificates (ECC+RSA)

2015-03-30 Thread Alexander Traud
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4441/ --- (Updated March 30, 2015, 8:34 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4441: Enable TLS Dual-Certificates (ECC+RSA)

2015-02-24 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4441/#review14529 --- See coding guidelines:

[asterisk-dev] [Code Review] 4441: Enable TLS Dual-Certificates (ECC+RSA)

2015-02-23 Thread Alexander Traud
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4441/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24815