Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2017-03-02 Thread Matthew Jordan
On Thu, Mar 2, 2017 at 3:46 AM, Dennis Guse wrote: > Since all patches are now merged, this will be the last eMail from me on > this thread. > Here are just the steps to setup the binaural synthesis and the required > stereo-capable OPUS module: > > ``` > git

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2017-03-02 Thread Dennis Guse
Since all patches are now merged, this will be the last eMail from me on this thread. Here are just the steps to setup the binaural synthesis and the required stereo-capable OPUS module: ``` git clone http://gerrit.asterisk.org/asterisk git clone

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-12-23 Thread Dennis Guse
The final three patches are now on Gerrit: * https://gerrit.asterisk.org/#/c/4654/ * https://gerrit.asterisk.org/#/c/3524/ * https://gerrit.asterisk.org/#/c/3525/ 4654 fails to build as it requires libsndfile (which is not present to anonymous coward9. Finally, we will port our opus changes (ie.

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-11-30 Thread Richard Mudgett
On Wed, Nov 30, 2016 at 8:04 AM, Joshua Colp wrote: > On Fri, Nov 25, 2016, at 10:20 AM, Dennis Guse wrote: > > Hey guys, > > > > we continued working on our largest changeset: https://gerrit. > > asterisk.org/#/c/3524/ > > Besides the copyright of HRTFs (still under

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-11-30 Thread Joshua Colp
On Fri, Nov 25, 2016, at 10:20 AM, Dennis Guse wrote: > Hey guys, > > we continued working on our largest changeset: https://gerrit. > asterisk.org/#/c/3524/ > Besides the copyright of HRTFs (still under investigation from our side), > the only issue on our side is the introduced `settings_lock`

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-11-30 Thread Joshua Colp
On Fri, Nov 25, 2016, at 10:20 AM, Dennis Guse wrote: > Hey guys, > > we continued working on our largest changeset: https://gerrit. > asterisk.org/#/c/3524/ > Besides the copyright of HRTFs (still under investigation from our side), > the only issue on our side is the introduced `settings_lock`

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-11-25 Thread Dennis Guse
Hey guys, we continued working on our largest changeset: https://gerrit. asterisk.org/#/c/3524/ Besides the copyright of HRTFs (still under investigation from our side), the only issue on our side is the introduced `settings_lock` (defined in bridge.h:254). This lock is used in addition to the

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-10-25 Thread Joshua Colp
Dennis Guse wrote: Thanks Joshua, just to be clear that I understood it correctly. 1. We would extend ast_format [2] with the additional field `uint channel_count:1` 2. We would modify `opus_parse_sdp_fmtp` [1] to set `cloned->channel_count=2`on the `ast_format` to be returned. Would this be

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-10-25 Thread Dennis Guse
Thanks Joshua, just to be clear that I understood it correctly. 1. We would extend ast_format [2] with the additional field `uint channel_count:1` 2. We would modify `opus_parse_sdp_fmtp` [1] to set `cloned->channel_count=2`on the `ast_format` to be returned. Would this be acceptable or is this

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-10-25 Thread Joshua Colp
Dennis Guse wrote: Hey, last week we started reworking the major patch [1] and could not solve one issue. At the moment, the softmix_bridge determines if interleaved stereo can be written by querying ast_format's attribute data if OPUS is used ([2]): ``` struct opus_attr *attr =

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-10-25 Thread Dennis Guse
Hey, last week we started reworking the major patch [1] and could not solve one issue. At the moment, the softmix_bridge determines if interleaved stereo can be written by querying ast_format's attribute data if OPUS is used ([2]): ``` struct opus_attr *attr =

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-09-17 Thread Leif Madsen
This is getting to be an old thread, but the "magic" for adding multiple changes is as follows: * use your working branch * make changes * git commit -a --amend * save... * git review This way, the same branch, with the initial commit, will be preserved along with the same change ID. If you

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-08-23 Thread Joshua Colp
Dennis Guse wrote: Hey, we adjusted the patch set (fftw3 is now a ifdef-ed). Precisely, these two commits have been modified (basically adding HAVE_FFTW3) https://gerrit.asterisk.org/#/c/3522/ https://gerrit.asterisk.org/#/c/3524/ Two questions: 1. It seems that we were working outside the

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-08-23 Thread Dennis Guse
Hey, we adjusted the patch set (fftw3 is now a ifdef-ed). Precisely, these two commits have been modified (basically adding HAVE_FFTW3) https://gerrit.asterisk.org/#/c/3522/ https://gerrit.asterisk.org/#/c/3524/ Two questions: 1. It seems that we were working outside the commit tree by

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-08-18 Thread Matt Fredrickson
Responses inline. On Tue, Aug 16, 2016 at 4:41 AM, Dennis Guse wrote: > Hello, > > the cleanup and splitting up into individual patches took some time, > but those are now submitted: Asterisk-26292 [1]. > The issue with this patch set is that it _requires_

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-08-16 Thread Joshua Colp
Dennis Guse wrote: Hello, the cleanup and splitting up into individual patches took some time, but those are now submitted: Asterisk-26292 [1]. The issue with this patch set is that it _requires_ libfftw3. We just figured out, how the dependency system works and will adjust the fftw-related

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-08-16 Thread Dennis Guse
Hello, the cleanup and splitting up into individual patches took some time, but those are now submitted: Asterisk-26292 [1]. The issue with this patch set is that it _requires_ libfftw3. We just figured out, how the dependency system works and will adjust the fftw-related patch by using

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-08-05 Thread Matthew Jordan
Hi Dennis: Apologies for not responding quicker to your e-mail - I've been on vacation the last week and a half. Some comments inline below. On Sat, Jul 23, 2016 at 3:50 AM, Dennis Guse wrote: > Then lets get started. > Due to the relatively large number of

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-07-23 Thread Dennis Guse
Then lets get started. Due to the relatively large number of changes, we will split them up into individual patches: 1) Support for interleaved stereo (mainly softmix and struct channel) 2) Extension of confbridge with binaural synthesis via convolution (if channel supports stereo) For the

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-07-20 Thread Matthew Jordan
On Tue, Jul 19, 2016 at 4:59 PM, Matt Fredrickson wrote: > On Tue, Jul 19, 2016 at 12:59 PM, Sean Bright > wrote: > > On 7/19/2016 10:35 AM, Matt Fredrickson wrote: > >> > >> Response below. > >> > >> On Mon, Jul 18, 2016 at 7:18 AM, Dennis Guse > >>

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-07-19 Thread Matt Fredrickson
On Tue, Jul 19, 2016 at 12:59 PM, Sean Bright wrote: > On 7/19/2016 10:35 AM, Matt Fredrickson wrote: >> >> Response below. >> >> On Mon, Jul 18, 2016 at 7:18 AM, Dennis Guse >> wrote: >>> >>> Technical Details (at the moment the

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-07-19 Thread Bruce Ferrell
On 07/19/2016 01:56 PM, Sean Bright wrote: > On 7/19/2016 4:00 PM, Bruce Ferrell wrote: >> On 07/19/2016 10:59 AM, Sean Bright wrote: >>> On 7/19/2016 10:35 AM, Matt Fredrickson wrote: Response below. On Mon, Jul 18, 2016 at 7:18 AM, Dennis Guse

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-07-19 Thread Sean Bright
On 7/19/2016 4:00 PM, Bruce Ferrell wrote: On 07/19/2016 10:59 AM, Sean Bright wrote: On 7/19/2016 10:35 AM, Matt Fredrickson wrote: Response below. On Mon, Jul 18, 2016 at 7:18 AM, Dennis Guse wrote: Technical Details (at the moment the modifications are

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-07-19 Thread Bruce Ferrell
On 07/19/2016 10:59 AM, Sean Bright wrote: > On 7/19/2016 10:35 AM, Matt Fredrickson wrote: >> Response below. >> >> On Mon, Jul 18, 2016 at 7:18 AM, Dennis Guse >> wrote: >>> Technical Details (at the moment the modifications are based upon 13.6.0): >>> * Enabled

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-07-19 Thread Sean Bright
On 7/19/2016 10:35 AM, Matt Fredrickson wrote: Response below. On Mon, Jul 18, 2016 at 7:18 AM, Dennis Guse wrote: Technical Details (at the moment the modifications are based upon 13.6.0): * Enabled OPUS (with incoming stereo and outgoing stereo

Re: [asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-07-19 Thread Matt Fredrickson
Response below. On Mon, Jul 18, 2016 at 7:18 AM, Dennis Guse wrote: > Hello, > > spatial audio for telephone conferencing has been proclaimed as a > silver bullet for speech-based telephone conferencing. > For research, we needed a _production-ready_ system that

[asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

2016-07-18 Thread Dennis Guse
Hello, spatial audio for telephone conferencing has been proclaimed as a silver bullet for speech-based telephone conferencing. For research, we needed a _production-ready_ system that provides a centralized conferencing bridge being able to provide binaural synthesized spatial audio (i.e., for a