Re: [asterisk-dev] Asterisk-11.5.1 Confbridge Dailout using pbx_exce new user not placed into current conference

2014-04-29 Thread hkc323
hkc323 hkc323 at gmail.com writes: SOLVED NOW -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit:

Re: [asterisk-dev] SIP Presence using SIP SIMPLE: How?

2014-04-29 Thread Dennis Guse
Hi Olle, adding Kamailio is one option, but I must admit that I don't want to complicate the existing setup any more and Asterisk is working quite well. Actually I can live without the feature - it would just make things more nicer ;) About adding this feature - I can only offer some my work

Re: [asterisk-dev] A thread for format work

2014-04-29 Thread Joshua Colp
Matthew Jordan wrote: Like a normal person, I decided to poke at the format work while watching tornadoes track North and South of Huntsville (because really, what else are you going to do?) After looking through Josh's notes on the wiki [1] and the code in the team branch [2], I decided to

Re: [asterisk-dev] [Code Review] 3480: chan_pjsip: Implement get_pvt_uniqueid channel technology callback.

2014-04-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3480/ --- (Updated April 29, 2014, 6:19 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3479: chan_pjsip: Call pickup test.

2014-04-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3479/ --- (Updated April 29, 2014, 11:29 a.m.) Review request for Asterisk

Re: [asterisk-dev] A thread for format work

2014-04-29 Thread Matthew Jordan
On Tue, Apr 29, 2014 at 6:15 AM, Joshua Colp jc...@digium.com wrote: Matthew Jordan wrote: (1) Where will the packetization of a format on a channel reside? With the format on the channel? Or with the capability of the channel? It has to reside in the RTP engine layer and optionally can

Re: [asterisk-dev] A thread for format work

2014-04-29 Thread Matthew Jordan
On Tue, Apr 29, 2014 at 6:49 AM, Matthew Jordan mjor...@digium.com wrote: On Tue, Apr 29, 2014 at 6:15 AM, Joshua Colp jc...@digium.com wrote: snip The ability to set the framing per-format, globally in a capabilities structure, and to get the framing already exists. What doesn't exist

Re: [asterisk-dev] A thread for format work

2014-04-29 Thread Joshua Colp
Matthew Jordan wrote: snip snip The ability to set the framing per-format, globally in a capabilities structure, and to get the framing already exists. What doesn't exist is adding a format and then setting the framing as two separate API calls. That is something that could

Re: [asterisk-dev] A thread for format work

2014-04-29 Thread Matthew Jordan
On Tue, Apr 29, 2014 at 6:55 AM, Joshua Colp jc...@digium.com wrote: Matthew Jordan wrote: snip snip The ability to set the framing per-format, globally in a capabilities structure, and to get the framing already exists. What doesn't exist is adding a format and then

Re: [asterisk-dev] A thread for format work

2014-04-29 Thread Joshua Colp
Matthew Jordan wrote: snip So something like: read_ptime0 = ast_format_cap_get_framing(cap0, ast_channel_rawreadformat(c0-chan)); read_ptime1 = ast_format_cap_get_framing(cap1, ast_channel_rawreadformat(c1-chan)); write_ptime0 = ast_format_cap_get_framing(cap0,

Re: [asterisk-dev] [Code Review] 3481: Websocket: Add locking around session access and modification

2014-04-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3481/#review11778 --- branches/11/res/res_http_websocket.c

Re: [asterisk-dev] [Code Review] 3481: Websocket: Add locking around session access and modification

2014-04-29 Thread opticron
On April 29, 2014, 7:28 a.m., Joshua Colp wrote: branches/11/res/res_http_websocket.c, line 125 https://reviewboard.asterisk.org/r/3481/diff/2/?file=58003#file58003line125 Is there any need for this since it should always be non-NULL now? There is at least one code path where this

Re: [asterisk-dev] [Code Review] 3481: Websocket: Add locking around session access and modification

2014-04-29 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3481/ --- (Updated April 29, 2014, 8:14 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3481: Websocket: Add locking around session access and modification

2014-04-29 Thread Joshua Colp
On April 29, 2014, 12:28 p.m., Joshua Colp wrote: branches/11/res/res_http_websocket.c, line 195 https://reviewboard.asterisk.org/r/3481/diff/2/?file=58003#file58003line195 I don't see a close_sent change in here. opticron wrote: close_sent is set to 1 on line 206. I meant:

Re: [asterisk-dev] [Code Review] 3481: Websocket: Add locking around session access and modification

2014-04-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3481/#review11781 --- Ship it! Ship It! - Joshua Colp On April 29, 2014, 1:48

Re: [asterisk-dev] [Code Review] 3490: Testsuite: Ensure that repeated device states and presence states behave as expected

2014-04-29 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3490/ --- (Updated April 29, 2014, 2:20 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3472: res_pjsip_sdp_rtp: Fix issue with unholding when it shouldn't.

2014-04-29 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3472/#review11782 --- Ship it! /branches/12/res/res_pjsip_sdp_rtp.c

Re: [asterisk-dev] [Code Review] 3472: res_pjsip_sdp_rtp: Fix issue with unholding when it shouldn't.

2014-04-29 Thread Joshua Colp
On April 29, 2014, 2:25 p.m., opticron wrote: /branches/12/res/res_pjsip_sdp_rtp.c, lines 1080-1081 https://reviewboard.asterisk.org/r/3472/diff/1/?file=57771#file57771line1080 I guess people don't use SRTP+video/text that often... activate isn't really used by res_rtp_asterisk,

Re: [asterisk-dev] [Code Review] 3473: res_pjsip_sdp_rtp: Add tests for receiving same SDP when call is already held.

2014-04-29 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3473/#review11784 ---

[asterisk-dev] [Code Review] 3491: res_pjsip: Allow cipher to be specified by name

2014-04-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3491/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23498

Re: [asterisk-dev] [Code Review] 3485: pjsip: Fix a bug where transferring to a parking extension causes calls to hang

2014-04-29 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3485/ --- (Updated April 29, 2014, 10:47 a.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3494: ARI: Add the ability to raise an arbitrary User Event from the Applications resource

2014-04-29 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3494/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22697

[asterisk-dev] [Code Review] 3495: res_stasis: Add missing PROGRESS indications to functions

2014-04-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3495/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23560

[asterisk-dev] [Code Review] 3496: testsuite: add valgrind support

2014-04-29 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3496/ --- Review request for Asterisk Developers. Repository: testsuite

Re: [asterisk-dev] [Code Review] 3027: Valgrind support in TestSuite

2014-04-29 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3027/ --- (Updated April 29, 2014, 1:28 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3495: res_stasis: Add missing PROGRESS indications to functions

2014-04-29 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3495/#review11785 --- Ship it! Ship It! - Matt Jordan On April 29, 2014, 11:51

Re: [asterisk-dev] [Code Review] 3490: Testsuite: Ensure that repeated device states and presence states behave as expected

2014-04-29 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3490/#review11786 --- Ship it! Ship It! - Matt Jordan On April 29, 2014, 9:20

[asterisk-dev] [Code Review] 3501: testsuite: add tests for ari userevents

2014-04-29 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3501/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22697

Re: [asterisk-dev] [Code Review] 3491: res_pjsip: Allow cipher to be specified by name

2014-04-29 Thread Sean Bright
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3491/#review11787 --- Ship it! Ship It! - Sean Bright On April 29, 2014, 3:21

[asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

2014-04-29 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3505/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23381

[asterisk-dev] [Code Review] 3506: format improvements: Port bridge_native_rtp over to new format capability API

2014-04-29 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3506/ --- Review request for Asterisk Developers, Joshua Colp and Kevin Harwell.

Re: [asterisk-dev] A thread for format work

2014-04-29 Thread Matthew Jordan
bridge_native_rtp up for review. One down, three hundred to go... But onward anyway. Next on the list: format attributes! The new specification calls for setting attributes using ast_format_set_attr, which takes in a key/value pair along with the format to set the attribute on. While this seems