Re: [asterisk-dev] [Code Review] 3780: res_pjsip_outbound_publish / res_pjsip_publish_asterisk: Add outbound PUBLISH support with 'asterisk' event type.

2014-08-01 Thread Olle E. Johansson
On 31 Jul 2014, at 17:28, Joshua Colp reviewbo...@asterisk.org wrote: This adds two PJSIP modules which add outbound PUBLISH support and an 'asterisk' event type. I don't think it's a good idea to mix different events in one event tag. Will make it hard to handle in proxys and stuff. We

[asterisk-dev] Read dtmf after ast_bridge_call

2014-08-01 Thread vassilux .
Hi, I try to read DTMF digits from a channel after calling ast_bridge_call. There are a lot of errors about : called with no recorded file descriptor from static struct ast_frame *__ast_read(struct ast_channel *chan, int dropaudio) function. I can read DTMF digits before execute

Re: [asterisk-dev] [Code Review] 3797: PJSIP: Add ContactStatusDetail to PJSIPShowEndpoint AMI command output

2014-08-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3797/#review12954 --- /trunk/res/res_pjsip/pjsip_options.c

[asterisk-dev] [Code Review] 3888: Manager: Add documentation for PJSIPShowEndpoint[s] responses

2014-08-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3888/ --- Review request for Asterisk Developers and Mark Michelson. Repository:

Re: [asterisk-dev] [Code Review] 3872: Tests the various ARI channel muting applications (the both, in, and out directions)

2014-08-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3872/#review12955 ---

Re: [asterisk-dev] [Code Review] 3797: PJSIP: Add ContactStatusDetail to PJSIPShowEndpoint AMI command output

2014-08-01 Thread opticron
On July 31, 2014, 2:09 p.m., opticron wrote: Go ahead and commit this as the code looks good to go. I'll take care of the documentation for it since PJSIPShowEndpoint is lacking enough in reponse documentation so as to be out of the scope of this review. The documentation for this

Re: [asterisk-dev] [Code Review] 3797: PJSIP: Add ContactStatusDetail to PJSIPShowEndpoint AMI command output

2014-08-01 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3797/ --- (Updated Aug. 1, 2014, 9:48 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3795: Test for MixMonitor Recording Feature

2014-08-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3795/#review12957 --- Ship it! Ship It! - opticron On July 25, 2014, 2:51 p.m.,

Re: [asterisk-dev] [Code Review] 3872: Tests the various ARI channel muting applications (the both, in, and out directions)

2014-08-01 Thread Christopher Wolfe
On Aug. 1, 2014, 2:34 p.m., opticron wrote: /asterisk/trunk/tests/rest_api/channels/mute/in_only/test-config.yaml, line 371 https://reviewboard.asterisk.org/r/3872/diff/1/?file=65759#file65759line371 It seems odd that this is not 3. Can this be attributed to the fact that the

Re: [asterisk-dev] [Code Review] 3872: Tests the various ARI channel muting applications (the both, in, and out directions)

2014-08-01 Thread Christopher Wolfe
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3872/ --- (Updated Aug. 1, 2014, 4:24 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3854: manager.c - Improve documentation for manager command Getvar, Setvar

2014-08-01 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3854/ --- (Updated Aug. 1, 2014, 6:17 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3872: Tests the various ARI channel muting applications (the both, in, and out directions)

2014-08-01 Thread opticron
On Aug. 1, 2014, 9:34 a.m., opticron wrote: /asterisk/trunk/tests/rest_api/channels/mute/in_only/test-config.yaml, line 371 https://reviewboard.asterisk.org/r/3872/diff/1/?file=65759#file65759line371 It seems odd that this is not 3. Can this be attributed to the fact that the

Re: [asterisk-dev] [Code Review] 3872: Tests the various ARI channel muting applications (the both, in, and out directions)

2014-08-01 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3872/#review12960 --- This test unfortunately doesn't work on my box and after

Re: [asterisk-dev] [Code Review] 3888: Manager: Add documentation for PJSIPShowEndpoint[s] responses

2014-08-01 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3888/#review12961 --- Ship it! Ship It! - Mark Michelson On Aug. 1, 2014, 12:54

Re: [asterisk-dev] [Code Review] 3854: manager.c - Improve documentation for manager command Getvar, Setvar

2014-08-01 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3854/#review12962 --- Ship it! Ship It! - Mark Michelson On Aug. 1, 2014, 6:17

Re: [asterisk-dev] [Code Review] 3885: chan_iax2: Fix a crash caused by trying to allow all codecs on a chan_iax2 peer

2014-08-01 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3885/#review12963 --- Ship it! - Mark Michelson On July 31, 2014, 9:40 p.m.,

Re: [asterisk-dev] [Code Review] 3873: Testsuite: RLS tests - nominal presence lists

2014-08-01 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3873/#review12964 ---

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

2014-08-01 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3811/ --- (Updated Aug. 1, 2014, 6:22 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

2014-08-01 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3811/#review12965 --- /trunk/main/logger.c

Re: [asterisk-dev] [Code Review] 3883: Testsuite: RLS tests - Lists containing lists tests for MWI

2014-08-01 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3883/ --- (Updated Aug. 1, 2014, 5:46 p.m.) Review request for Asterisk Developers

[asterisk-dev] managerEvent XML documentation

2014-08-01 Thread Corey Farrell
Hello everyone, As part of r3811 I'm fixing build_tools/get_documentation so it picks up every /*** DOCUMENTATION ***/ block, instead of just the first from each file. As a side-effect this picked up some validation error's that were previously unnoticed. One of them is in main/logger.c, the

Re: [asterisk-dev] [Code Review] 3881: Testsuite: RLS tests - Lists containing lists tests for presence

2014-08-01 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3881/ --- (Updated Aug. 1, 2014, 5:49 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3875: Testsuite: RLS tests - nominal MWI lists

2014-08-01 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3875/ --- (Updated Aug. 1, 2014, 5:51 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3873: Testsuite: RLS tests - nominal presence lists

2014-08-01 Thread Jonathan Rose
On Aug. 1, 2014, 4:23 p.m., Jonathan Rose wrote: /asterisk/trunk/tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/full_state/full_state.py, lines 37-38 https://reviewboard.asterisk.org/r/3873/diff/1/?file=65767#file65767line37 Alright, this right here turns out to

Re: [asterisk-dev] [Code Review] 3888: Manager: Add documentation for PJSIPShowEndpoint[s] responses

2014-08-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3888/ --- (Updated Aug. 1, 2014, 10:37 p.m.) Status -- This change has been