---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4502/
---
(Updated March 27, 2015, 2:06 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4502/#review14881
---
Before committing I found a link error for utils/refcounter
On March 27, 2015, 2:11 a.m., Matt Jordan wrote:
/branches/13/pbx/pbx_config.c, line 977
https://reviewboard.asterisk.org/r/4529/diff/1/?file=72935#file72935line977
So, dup'ing things on the stack here in a nested loop is actually quite
dangerous. Unlike a local variable with
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4533/
---
(Updated March 27, 2015, 11:42 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4529/
---
(Updated March 27, 2015, 11:22 a.m.)
Review request for Asterisk
On March 27, 2015, 2:11 a.m., Matt Jordan wrote:
/branches/13/main/stdtime/localtime.c, lines 357-361
https://reviewboard.asterisk.org/r/4530/diff/1/?file=72936#file72936line357
Just curious, what was the compiler warning on this one?
There can only be one variable size struct
On March 26, 2015, 6:52 p.m., Diederik de Groot wrote:
/branches/13/channels/chan_iax2.c, lines 2026-2032
https://reviewboard.asterisk.org/r/4527/diff/1/?file=72928#file72928line2026
user_ref function not being used, may/might actually indicate a
refcount issue.
Because of
On March 27, 2015, 2:11 a.m., Matt Jordan wrote:
/branches/13/pbx/pbx_config.c, line 977
https://reviewboard.asterisk.org/r/4529/diff/1/?file=72935#file72935line977
So, dup'ing things on the stack here in a nested loop is actually quite
dangerous. Unlike a local variable with
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4532/#review14886
---
/branches/13/main/threadpool.c
On March 26, 2015, 6:37 p.m., Diederik de Groot wrote:
/branches/13/funcs/func_env.c, line 728
https://reviewboard.asterisk.org/r/4526/diff/1/?file=72920#file72920line728
Note the double closing parens after the first sizeof, i actually
finishes the ast_str_append_substr command
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4537/
---
(Updated March 27, 2015, 12:24 p.m.)
Review request for Asterisk
On March 26, 2015, 11:13 p.m., Diederik de Groot wrote:
/branches/13/channels/pjsip/dialplan_functions.c, line 869
https://reviewboard.asterisk.org/r/4533/diff/1/?file=72956#file72956line869
len is of type size_t, which is unsigned. It will not be able to hold a
value 0
Matt
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4532/#review14888
---
Just adding a note to the comment.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4527/
---
(Updated March 27, 2015, 11:46 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4537/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4540/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4525/
---
(Updated March 27, 2015, 1:38 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4538/
---
Review request for Asterisk Developers.
Repository: Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4539/
---
(Updated March 27, 2015, 12:41 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4539/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4540/
---
(Updated March 27, 2015, 12:51 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4541/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4538/#review14891
---
Ship it!
Ship It!
- Joshua Colp
On March 27, 2015, 11:52
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4538/
---
(Updated March 27, 2015, 7:25 a.m.)
Status
--
This change has been
Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/15
Change subject: Memory Debugging Improvements
..
Memory Debugging Improvements
* Enable XML output from valgrind.
* Display and save a
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4541/
---
(Updated March 27, 2015, 1:13 p.m.)
Review request for Asterisk
On March 26, 2015, 12:37 p.m., Diederik de Groot wrote:
/branches/13/funcs/func_env.c, line 728
https://reviewboard.asterisk.org/r/4526/diff/1/?file=72920#file72920line728
Note the double closing parens after the first sizeof, i actually
finishes the ast_str_append_substr command
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4537/#review14897
---
Ship it!
/branches/13/channels/chan_iax2.c
Michael L. Young has uploaded a new patch set (#3).
Change subject: Add web proxy support to commit_msg.py
..
Add web proxy support to commit_msg.py
This patch allows the commit_msg.py script to connect to the issue
tracker
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4527/#review14896
---
Ship it!
Ship It!
- Matt Jordan
On March 27, 2015, 5:48
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4531/#review14893
---
Ship it!
Ship It!
- Matt Jordan
On March 26, 2015, 1:20
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4530/#review14895
---
Ship it!
Ship It!
- Matt Jordan
On March 26, 2015, 1:12
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4529/#review14894
---
/branches/13/pbx/pbx_config.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4539/#review14898
---
Ship it!
I think your solution here is fine.
- Matt Jordan
On March 26, 2015, 6:37 p.m., Diederik de Groot wrote:
/branches/13/funcs/func_env.c, line 728
https://reviewboard.asterisk.org/r/4526/diff/1/?file=72920#file72920line728
Note the double closing parens after the first sizeof, i actually
finishes the ast_str_append_substr command
Matt Jordan has posted comments on this change.
Change subject: PJSIP: Added test to ensure retransmissions are not handled.
..
Patch Set 1:
(2 comments)
https://gerrit.asterisk.org/#/c/14/1//COMMIT_MSG
Commit Message:
Line
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4542/
---
Review request for Asterisk Developers.
Repository: Asterisk
Corey Farrell has uploaded a new patch set (#2).
Change subject: Memory Debugging Improvements
..
Memory Debugging Improvements
* Enable XML output from valgrind.
* Display and save a summary of valgrind errors and leaks.
*
On March 23, 2015, 9:57 a.m., Matt Jordan wrote:
Ship It!
As an addendum to this, this patch does not merge cleanly on Asterisk 11. As
such, I'll be merging this to Asterisk 13+.
Alas, as I don't run a system that can compile kqueue, it's kind of hard for me
to backport that. If someone
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4465/
---
(Updated March 27, 2015, 9:41 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4542/
---
(Updated March 27, 2015, 2:45 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4519/
---
(Updated March 27, 2015, 9:54 a.m.)
Review request for Asterisk
On March 24, 2015, 1:15 p.m., rmudgett wrote:
./branches/13/apps/app_stasis.c, lines 77-79
https://reviewboard.asterisk.org/r/4519/diff/1/?file=72716#file72716line77
Using a parameter value before asserting that it is non-NULL is just
wrong.
That's just closing the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4519/
---
(Updated March 27, 2015, 9:59 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4519/
---
(Updated March 27, 2015, 10:01 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4520/
---
(Updated March 27, 2015, 10:02 a.m.)
Review request for Asterisk
On March 24, 2015, 1:15 p.m., Kevin Harwell wrote:
./asterisk/trunk/tests/rest_api/applications/stasis_status/ari_client.py,
lines 351-352
https://reviewboard.asterisk.org/r/4520/diff/1/?file=72742#file72742line351
I would opt for the python convention of easier to ask
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4543/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4520/#review14902
---
On March 27, 2015, 2:23 p.m., Matt Jordan wrote:
/branches/13/pbx/pbx_config.c, lines 960-961
https://reviewboard.asterisk.org/r/4529/diff/2/?file=72981#file72981line960
Well, this won't quite work, as appdata can be NULL. strlen isn't NULL
safe.
As such, you'll need
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4544/#review14917
---
I'm wondering if -Wself-assign should not be enabled. It
On March 24, 2015, 11:23 a.m., Matt Jordan wrote:
./asterisk/trunk/tests/rest_api/applications/stasis_status/test_case.py,
lines 20-26
https://reviewboard.asterisk.org/r/4520/diff/1/?file=72750#file72750line20
You may want to consider moving this class back into runtest.
Mark Michelson has uploaded a new patch set (#2).
Change subject: PJSIP: Added test to ensure retransmissions are not handled.
..
PJSIP: Added test to ensure retransmissions are not handled.
In this test, a SIPp scenario sends
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4531/
---
(Updated March 27, 2015, 6:52 p.m.)
Review request for Asterisk
On March 27, 2015, 8:23 a.m., Matt Jordan wrote:
/branches/13/pbx/pbx_config.c, lines 960-961
https://reviewboard.asterisk.org/r/4529/diff/2/?file=72981#file72981line960
Well, this won't quite work, as appdata can be NULL. strlen isn't NULL
safe.
As such, you'll need
Mark Michelson has uploaded a new patch set (#2).
Change subject: PJSIP: Added test to ensure retransmissions are not handled.
..
PJSIP: Added test to ensure retransmissions are not handled.
In this test, a SIPp scenario sends
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4520/
---
(Updated March 27, 2015, 10:56 a.m.)
Review request for Asterisk
On March 27, 2015, 2:23 p.m., Matt Jordan wrote:
/branches/13/pbx/pbx_config.c, lines 960-961
https://reviewboard.asterisk.org/r/4529/diff/2/?file=72981#file72981line960
Well, this won't quite work, as appdata can be NULL. strlen isn't NULL
safe.
As such, you'll need
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4530/
---
(Updated March 27, 2015, 6:10 p.m.)
Review request for Asterisk
On March 27, 2015, 6:14 p.m., rmudgett wrote:
I'm wondering if -Wself-assign should not be enabled. It appears to be
just a nuisance warning.
I do agree, some of the clang warnings can be a little bit petty to be honest.
Some of them have proven to be quite usefull though. I will leave
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4544/
---
(Updated March 27, 2015, 6:20 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4523/
---
(Updated March 27, 2015, 12:51 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4531/
---
(Updated March 27, 2015, 6:53 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4546/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
On March 26, 2015, 6:37 p.m., Diederik de Groot wrote:
/branches/13/funcs/func_env.c, line 728
https://reviewboard.asterisk.org/r/4526/diff/1/?file=72920#file72920line728
Note the double closing parens after the first sizeof, i actually
finishes the ast_str_append_substr command
On March 26, 2015, 8:11 p.m., Matt Jordan wrote:
/branches/13/main/stdtime/localtime.c, lines 357-361
https://reviewboard.asterisk.org/r/4530/diff/1/?file=72936#file72936line357
Just curious, what was the compiler warning on this one?
Diederik de Groot wrote:
There can only
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4520/
---
(Updated March 27, 2015, 10:58 a.m.)
Review request for Asterisk
On March 27, 2015, 2:26 p.m., Matt Jordan wrote:
/branches/13/channels/chan_iax2.c, line 11898
https://reviewboard.asterisk.org/r/4537/diff/1/?file=72997#file72997line11898
Interestingly enough, we don't use this value anywhere :-P
But that's a different problem.
You
On March 27, 2015, 2:26 p.m., Matt Jordan wrote:
I think your solution here is fine.
Hi Matt, can i commit directly to the svn repository or does someone have to do
this for me.
Your 'ship it' gives the impression that i can. If so is there a particular
format to which the commit message
On March 27, 2015, 10:39 a.m., Joshua Colp wrote:
/branches/13/res/res_pjsip.c, lines 3325-3328
https://reviewboard.asterisk.org/r/4532/diff/1/?file=72952#file72952line3325
Just a question - if I somehow have two messages in-flight in
processing what will happen here? I assume
On March 27, 2015, 5:20 p.m., Jared Smith wrote:
/branches/13/formats/format_wav.c, line 67
https://reviewboard.asterisk.org/r/4544/diff/1/?file=73085#file73085line67
Red blob...
I like to line up the slashes when using macro's. But ok
- Diederik
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4544/
---
(Updated March 27, 2015, 5:38 p.m.)
Review request for Asterisk
On March 27, 2015, 2:11 a.m., Matt Jordan wrote:
/branches/13/main/stdtime/localtime.c, lines 357-361
https://reviewboard.asterisk.org/r/4530/diff/1/?file=72936#file72936line357
Just curious, what was the compiler warning on this one?
Diederik de Groot wrote:
There can only
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4543/
---
(Updated March 27, 2015, 4:08 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4519/
---
(Updated March 27, 2015, 10:59 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4544/#review14907
---
/branches/13/formats/format_wav.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4529/
---
(Updated March 27, 2015, 5:32 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4544/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4488/#review14906
---
Ship it!
Go ahead and ship it after uncommenting that format
On March 24, 2015, 1:15 p.m., Kevin Harwell wrote:
./asterisk/trunk/tests/rest_api/applications/stasis_status/test_case.py,
lines 22-23
https://reviewboard.asterisk.org/r/4520/diff/1/?file=72750#file72750line22
A lot of the code in this object as well as others (AriClient,
Jared K. Smith has uploaded a new patch set (#3).
Change subject: PJSIP: Added test to ensure retransmissions are not handled
twice.
..
PJSIP: Added test to ensure retransmissions are not handled twice.
In this test, a SIPp
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4532/
---
(Updated March 27, 2015, 3:34 p.m.)
Status
--
This change has been
George Joseph has uploaded a new patch set (#2).
Change subject: Testsuite: Test for res_pjsip_config_wizard auto-create hints
..
Testsuite: Test for res_pjsip_config_wizard auto-create hints
This test uses ListDialPlan to
Jared K. Smith has posted comments on this change.
Change subject: Testsuite: Test for res_pjsip_config_wizard auto-create hints
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/10
To unsubscribe,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4547/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
Matt Jordan has submitted this change and it was merged.
Change subject: Testsuite: Test for res_pjsip_config_wizard auto-create hints
..
Testsuite: Test for res_pjsip_config_wizard auto-create hints
This test uses
Matt Jordan has posted comments on this change.
Change subject: Testsuite: Test for res_pjsip_config_wizard auto-create hints
..
Patch Set 2: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/10
To
Matt Jordan has posted comments on this change.
Change subject: PJSIP: Added test to ensure retransmissions are not handled
twice.
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.asterisk.org/14
To
Matt Jordan has posted comments on this change.
Change subject: PJSIP: Added test to ensure retransmissions are not handled
twice.
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.asterisk.org/14
To unsubscribe,
Mark Michelson has posted comments on this change.
Change subject: Add web proxy support to commit_msg.py
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/13
To unsubscribe, visit
On March 24, 2015, 1:15 p.m., Kevin Harwell wrote:
./asterisk/trunk/tests/rest_api/applications/stasis_status/test_case.py,
lines 22-23
https://reviewboard.asterisk.org/r/4520/diff/1/?file=72750#file72750line22
A lot of the code in this object as well as others (AriClient,
Matt Jordan has submitted this change and it was merged.
Change subject: PJSIP: Added test to ensure retransmissions are not handled
twice.
..
PJSIP: Added test to ensure retransmissions are not handled twice.
In this test, a
Jared K. Smith has posted comments on this change.
Change subject: Add web proxy support to commit_msg.py
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/13
To unsubscribe, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4504/
---
(Updated March 27, 2015, 5:25 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4503/
---
(Updated March 27, 2015, 5:35 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4548/
---
Review request for Asterisk Developers, rmudgett and Scott Griepentrog.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4548/
---
(Updated March 27, 2015, 7:45 p.m.)
Review request for Asterisk
Matt Jordan has uploaded a new change for review.
https://gerrit.asterisk.org/16
Change subject: tests/rest_api/channels: Add a channel hold intercept test
..
tests/rest_api/channels: Add a channel hold intercept test
This
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4544/#review14925
---
Ship it!
Ship It!
- Matt Jordan
On March 27, 2015, 12:20
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4526/#review14926
---
Ship it!
Ship It!
- Matt Jordan
On March 27, 2015, 6:09
1 - 100 of 109 matches
Mail list logo
