Re: [asterisk-dev] [Code Review] 4441: Enable TLS Dual-Certificates (ECC+RSA)

> On Feb. 24, 2015, 5:20 p.m., rmudgett wrote: > > trunk/main/tcptls.c, line 836 > > > > > > It doesn't look like there is a standard cert file naming convention to > > name the files example_rsa.pem, example_ecc.p

Re: [asterisk-dev] [Code Review] 4441: Enable TLS Dual-Certificates (ECC+RSA)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4441/ --- (Updated March 30, 2015, 8:34 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/ --- (Updated March 30, 2015, 1:08 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4551: clang compiler warning: -Wnon-literal-null-conversion

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4551/ --- (Updated March 30, 2015, 1:16 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4548: Restrict ast_log_safe use from utils.h to the core only.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4548/ --- (Updated March 30, 2015, 6:40 a.m.) Status -- This change has been ma

[asterisk-dev] [Code Review] 4563: chan_sip: handle IPv4 mapped clients when NAT and IPv6 socket is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4563/ --- Review request for Asterisk Developers. Bugs: ASTERISK-18032 https://i

Re: [asterisk-dev] [Code Review] 4563: chan_sip: handle IPv4 mapped clients when NAT and IPv6 socket is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4563/ --- (Updated March 30, 2015, 2:23 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] RFC: Refactor qualify and res_pjsip/endpt_send_request

On 03/28/2015 08:06 PM, Joshua Colp wrote: George Joseph wrote: The fact that it goes to unavailable would be a bug. Why does it do so? Mark should probably chime in here but I think it's because the earliest you could get a response from pjsip when a contact isn't reachable is the unconfigura

Re: [asterisk-dev] RFC: Refactor qualify and res_pjsip/endpt_send_request

On Mon, Mar 30, 2015 at 8:54 AM, Mark Michelson wrote: > On 03/28/2015 08:06 PM, Joshua Colp wrote: > >> George Joseph wrote: >> >>> The fact that it goes to unavailable would be a bug. Why does it do so? >>> >>> Mark should probably chime in here but I think it's because the >>> earliest yo

[asterisk-dev] Change in testsuite[master]: Rewrite sip_attended_transfer test to stop failing.

Mark Michelson has uploaded a new change for review. https://gerrit.asterisk.org/19 Change subject: Rewrite sip_attended_transfer test to stop failing. .. Rewrite sip_attended_transfer test to stop failing. The sip_attended_t

[asterisk-dev] Change in testsuite[master]: Rewrite sip_attended_transfer test to stop failing.

Mark Michelson has uploaded a new patch set (#2). Change subject: Rewrite sip_attended_transfer test to stop failing. .. Rewrite sip_attended_transfer test to stop failing. The sip_attended_transfer test has been bouncing for a

[asterisk-dev] Change in testsuite[master]: Add SIP attended transfer for Asterisk 11.

Mark Michelson has uploaded a new change for review. https://gerrit.asterisk.org/20 Change subject: Add SIP attended transfer for Asterisk 11. .. Add SIP attended transfer for Asterisk 11. The structure of this is similar to

[asterisk-dev] Change in testsuite[master]: Add SIP attended transfer for Asterisk 11.

Corey Farrell has posted comments on this change. Change subject: Add SIP attended transfer for Asterisk 11. .. Patch Set 1: This is nearly identical to the test for 12+, couldn't they be combined with attended_transfer.py usi

[asterisk-dev] [Code Review] 4571: Add usegmtime option to cel_pgsql

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4571/ --- Review request for Asterisk Developers. Bugs: https://issues.asterisk.org/

[asterisk-dev] [Code Review] 4572: RFC: Refactor Qualify and res_pjsip/endpt_send_request

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4572/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24863 https://i

Re: [asterisk-dev] [Code Review] 4441: Enable TLS Dual-Certificates (ECC+RSA)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4441/#review14966 --- Thank you for working on the TLS code, we surely need more atte

Re: [asterisk-dev] RFC: Refactor qualify and res_pjsip/endpt_send_request

On 30 Mar 2015, at 16:54, Mark Michelson wrote: > On 03/28/2015 08:06 PM, Joshua Colp wrote: >> George Joseph wrote: The fact that it goes to unavailable would be a bug. Why does it do so? >>> >>> Mark should probably chime in here but I think it's because the >>> earliest you could get a