Re: [asterisk-users] Need for more hangup reasons in ARI?

2018-12-07 Thread Joshua C. Colp
On Thu, Dec 6, 2018, at 1:37 PM, Sebastian Damm wrote:
> Hi,
> 
> On Thu, Dec 6, 2018 at 2:44 PM Joshua C. Colp  wrote:
> > Nope. No specific reason. The ones there are what most people would use, 
> > and what those not as familiar with telephony would understand.
> 
> Thanks for the quick response. I have submitted a patch for adding
> more hangup reasons.
> 
> BTW: Is there a way to have them documented on the Wiki page instead
> of having to dig into the source code? I'd be happy to help.

The wiki documentation is derived from the Swagger JSON itself if I recall, so 
it would need to be documented there somehow and then extracted as part of that 
process. I don't have much experience with the documentation stuff itself 
outside of that, so I don't know anything further.

-- 
Joshua C. Colp
Digium - A Sangoma Company | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com & www.asterisk.org

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

Check out the new Asterisk community forum at: https://community.asterisk.org/

New to Asterisk? Start here:
  https://wiki.asterisk.org/wiki/display/AST/Getting+Started

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users

Re: [asterisk-users] Need for more hangup reasons in ARI?

2018-12-06 Thread Sebastian Damm
Hi,

On Thu, Dec 6, 2018 at 2:44 PM Joshua C. Colp  wrote:
> Nope. No specific reason. The ones there are what most people would use, and 
> what those not as familiar with telephony would understand.

Thanks for the quick response. I have submitted a patch for adding
more hangup reasons.

BTW: Is there a way to have them documented on the Wiki page instead
of having to dig into the source code? I'd be happy to help.

Regards,
Sebastian

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

Check out the new Asterisk community forum at: https://community.asterisk.org/

New to Asterisk? Start here:
  https://wiki.asterisk.org/wiki/display/AST/Getting+Started

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users

Re: [asterisk-users] Need for more hangup reasons in ARI?

2018-12-06 Thread Joshua C. Colp
On Thu, Dec 6, 2018, at 9:36 AM, Sebastian Damm wrote:
> Hi,
> 
> while implementing an application based on ARI, I wanted to hangup
> calls in different states with different hangup reasons. After not
> finding anything in the documentation I found the possible reasons in
> the 
> sources:(https://github.com/asterisk/asterisk/blob/4ca709768db9bafdfa83ee1cfc6cc0639f097857/res/ari/resource_channels.c#L866)
> 
> I think, there are some important reasons missing. For example I want
> to return a 408 if the callee doesn't answer after some time. I guess,
> I could submit a patch for more hangup reasons, but before doing so,
> is there a reason that there are only those five hangup reasons?

Nope. No specific reason. The ones there are what most people would use, and 
what those not as familiar with telephony would understand.

-- 
Joshua C. Colp
Digium - A Sangoma Company | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com & www.asterisk.org

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

Check out the new Asterisk community forum at: https://community.asterisk.org/

New to Asterisk? Start here:
  https://wiki.asterisk.org/wiki/display/AST/Getting+Started

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users

[asterisk-users] Need for more hangup reasons in ARI?

2018-12-06 Thread Sebastian Damm
Hi,

while implementing an application based on ARI, I wanted to hangup
calls in different states with different hangup reasons. After not
finding anything in the documentation I found the possible reasons in
the 
sources:(https://github.com/asterisk/asterisk/blob/4ca709768db9bafdfa83ee1cfc6cc0639f097857/res/ari/resource_channels.c#L866)

I think, there are some important reasons missing. For example I want
to return a 408 if the callee doesn't answer after some time. I guess,
I could submit a patch for more hangup reasons, but before doing so,
is there a reason that there are only those five hangup reasons?

Regards,
Sebastian

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

Check out the new Asterisk community forum at: https://community.asterisk.org/

New to Asterisk? Start here:
  https://wiki.asterisk.org/wiki/display/AST/Getting+Started

asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-users