[asterisk-users] Possible bug in app_meetme.c

2009-10-17 Thread Richard Kenner
Is this patch correct? The doesn't make logical sense to me. I think it should be || and making this change fixes the problem I have with SIP phones in MeetMe conferences. If it's correct, is there someplace more formal that I should submit it to? *** app_meetme.c.old2009-10-11

Re: [asterisk-users] Possible bug in app_meetme.c

2009-10-17 Thread Moises Silva
On Sat, Oct 17, 2009 at 2:26 PM, Richard Kenner ken...@gnat.com wrote: Is this patch correct? The doesn't make logical sense to me. I think it should be || and making this change fixes the problem I have with SIP phones in MeetMe conferences. If it's correct, is there someplace more

Re: [asterisk-users] Possible bug in app_meetme.c

2009-10-17 Thread David Backeberg
On Sat, Oct 17, 2009 at 2:26 PM, Richard Kenner ken...@gnat.com wrote: Is this patch correct?  The doesn't make logical sense to me.  I think it should be || and making this change fixes the problem I have with SIP phones in MeetMe conferences.  If it's correct, is there someplace more formal

Re: [asterisk-users] Possible bug in app_meetme.c

2009-10-17 Thread David Backeberg
On Sat, Oct 17, 2009 at 2:26 PM, Richard Kenner ken...@gnat.com wrote: Is this patch correct?  The doesn't make logical sense to me.  I think it should be || and making this change fixes the problem I have with SIP phones in MeetMe conferences.  If it's correct, is there someplace more formal

Re: [asterisk-users] Possible bug in app_meetme.c

2009-10-17 Thread Richard Kenner
David Backeberg wrote: From a quick glance at your patch, I would say that it probably tries to address the audio quality problems I and others were experiencing. No, it's fixing a much more serious issue. As I sent to this list twice, when I have a conference between Dahdi ports and SIP

Re: [asterisk-users] Possible bug in app_meetme.c

2009-10-17 Thread Richard Kenner
What version are you running? 1.6.2.0-rc2 Does that version support disabling talker optimization? Yes. Have you tried disabling talker optimization? Yes. That's how I found the bug. I got no audio from the SIP phone into the conference, so I decided I'd try seeing if it did if the SIP