Re: [asterisk-users] Possible bug in chan_sip:add_sdp

2010-05-12 Thread Klaus Darilion
This code is really ugly und hard to verify. Please file a bug report at https://issues.asterisk.org/ thanks klaus Am 06.05.2010 23:54, schrieb Richard Kenner: I can confirm that the following fixes my problem: --- chan_sip.c (revision 261450) +++ chan_sip.c (working copy) @@ -10357,12

Re: [asterisk-users] Possible bug in chan_sip:add_sdp

2010-05-12 Thread Richard Kenner
This code is really ugly und hard to verify. Since the computation of the is being done with separate code from the actual output, the code in that part of the module is indeed ugly. But I wanted to make the smallest possible change. However, I do suggest that the full output string be built

[asterisk-users] Possible bug in chan_sip:add_sdp

2010-05-06 Thread Richard Kenner
Am I missing something here? I see if (needvideo) { /* only if video response is appropriate */ add_line(resp, m_video-str); add_line(resp, a_video-str); add_line(resp, hold); /* Repeat hold for the video stream */ } else if

Re: [asterisk-users] Possible bug in chan_sip:add_sdp

2010-05-06 Thread Richard Kenner
I can confirm that the following fixes my problem: --- chan_sip.c (revision 261450) +++ chan_sip.c (working copy) @@ -10357,12 +10357,22 @@ strlen(connection) + strlen(session_time); if (needaudio) len += m_audio-used + a_audio-used + strlen(hold); +