Re: [PATCH] ath10k: request firmware flush in ath10k_flush.

2014-09-24 Thread Michal Kazior
On 23 September 2014 16:19, Ben Greear gree...@candelatech.com wrote: On 09/23/2014 02:16 AM, Michal Kazior wrote: On 19 September 2014 20:28, gree...@candelatech.com wrote: [...] + /* If we are CT firmware, ask it to flush all tids on all peers on +* all vdevs. Normal

Re: [PATCH v2 1/3] ath10k: don't enable interrupts for the diagnostic window

2014-09-24 Thread Michal Kazior
On 23 September 2014 16:32, Kalle Valo kv...@qca.qualcomm.com wrote: [...] - for (ce_id = 0; ce_id CE_COUNT; ce_id++) + /* Skip the last copy engine, CE7 the diagnostic window, as that +* uses polling and isn't initialized for interrupts. */ Comment style :-) MichaƂ

[PATCH v3 3/3] ath10k: add cal_data debugfs file

2014-09-24 Thread Kalle Valo
Provide calibration data used by the firmware to user space via a debugfs file. This makes it easier to debug calibration related problems. Example: sudo cp /sys/kernel/debug/ieee80211/phy0/ath10k/cal_data 1.cal Signed-off-by: Kalle Valo kv...@qca.qualcomm.com ---

[PATCH v3 1/3] ath10k: don't enable interrupts for the diagnostic window

2014-09-24 Thread Kalle Valo
The diagnostic window (CE7) uses polling and is not initiliased to retrieve interrupts so disable interrupts altogether for CE7. Otherwise ath10k crashes when using the diagnostic window while the firmware is running due to NULL dereference and polling reads timeout. Signed-off-by: Kalle Valo