Re: [PATCH] ath10k: fix a NULL vs IS_ERR() check

2018-11-26 Thread Kalle Valo
Dan Carpenter writes: > On Mon, Nov 26, 2018 at 10:24:38AM +0200, Kalle Valo wrote: >> Dan Carpenter writes: >> >> > The devm_memremap() function doesn't return NULLs, it returns error >> > pointers. >> > >> > Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 >> > client")

Re: missing firmware in debian 9

2018-11-26 Thread Sven Eckelmann
On Freitag, 16. November 2018 08:38:51 CET Anil Duggirala wrote: > hello, > I am getting this message at boot. > > [ 10.678576] ath10k_pci :03:00.0: firmware: failed to load > ath10k/pre-cal-pci-:03:00.0.bin (-2) > [ 10.678631] ath10k_pci :03:00.0: Direct firmware load for >

Re: [PATCH] ath10k: fix a NULL vs IS_ERR() check

2018-11-26 Thread Dan Carpenter
On Mon, Nov 26, 2018 at 10:24:38AM +0200, Kalle Valo wrote: > Dan Carpenter writes: > > > The devm_memremap() function doesn't return NULLs, it returns error > > pointers. > > > > Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client") > > Signed-off-by: Dan Carpenter > >

Re: [PATCH] ath10k: fix a NULL vs IS_ERR() check

2018-11-26 Thread Kalle Valo
Dan Carpenter writes: > The devm_memremap() function doesn't return NULLs, it returns error > pointers. > > Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client") > Signed-off-by: Dan Carpenter > --- > drivers/net/wireless/ath/ath10k/qmi.c | 4 ++-- > 1 file changed, 2

[PATCH] ath10k: fix a NULL vs IS_ERR() check

2018-11-26 Thread Dan Carpenter
The devm_memremap() function doesn't return NULLs, it returns error pointers. Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client") Signed-off-by: Dan Carpenter --- drivers/net/wireless/ath/ath10k/qmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git