Re: [RFC 2/2] ath10k: Add QCA vendor command/attr support to filterneighbor BSS frames

2019-01-25 Thread Johannes Berg
On Tue, 2018-11-20 at 08:10 +0530, Karthikeyan Periyasamy wrote: > > This patch only talks about "allow an AP" etc. and so while important, > > power isn't the _utmost_ concern like on mobile. Given an efficient > > filtering solution in software, would that be sufficient? > > Assume in a

Re: [PATCH] ath10k: fix dma unmap direction for management frames

2019-01-25 Thread Kalle Valo
Rakesh Pillai writes: > The management frames transmitted are dma mapped with > direction TO_DEVICE, but incorrectly mapped with > direction FROM_DEVICE during tx complete and error cases. > > Fix the direction of dma during dma unmap of the > transmitted management frames. > > Tested HW:

Re: [PATCH v7 1/4] mac80211: Expose ieee80211_schedule_txq() function

2019-01-25 Thread Toke Høiland-Jørgensen
Johannes Berg writes: >> +void ieee80211_schedule_txq(struct ieee80211_hw *hw, >> +struct ieee80211_txq *txq) >> +__acquires(txq_lock) __releases(txq_lock) >> +{ >> +struct ieee80211_local *local = hw_to_local(hw); >> +struct txq_info *txqi = to_txq_info(txq);

Re: [PATCH v7 1/4] mac80211: Expose ieee80211_schedule_txq() function

2019-01-25 Thread Johannes Berg
> +void ieee80211_schedule_txq(struct ieee80211_hw *hw, > + struct ieee80211_txq *txq) > + __acquires(txq_lock) __releases(txq_lock) > +{ > + struct ieee80211_local *local = hw_to_local(hw); > + struct txq_info *txqi = to_txq_info(txq); > + > +

Re: [PATCH 2/3] mac80211: store tx power value from user to station

2019-01-25 Thread Johannes Berg
On Thu, 2019-01-17 at 16:54 +0530, Balaji Pothunoori wrote: > > + * @txpwr: indicates the tx power, in mBm, to be used when sending data > frames > + * to the STA. > + * @type: In particular if TPC %type is NL80211_TX_POWER_LIMITED then txpwr > will > + * be less than or equal to specified

Re: [PATCH 1/3] cfg80211: Add support to set tx power for a station associated

2019-01-25 Thread Johannes Berg
On Thu, 2019-01-17 at 16:52 +0530, Balaji Pothunoori wrote: > > + s16 txpwr; > + enum nl80211_tx_power_setting type; you should probably call this txpwr_type, or do something like struct { s16 power; enum ... type; } txpwr; > + [NL80211_ATTR_STA_TX_POWER_SETTING] =

Re: [PATCH v6 4/4] ath10k: reporting estimated tx airtime for fairness

2019-01-25 Thread Toke Høiland-Jørgensen
Kan Yan writes: > Hi Toke, > > This patch looks good to me. Great job on getting the airtime fairness > scheduling framework done! Great, thanks for checking! Have another patch to test on top of this series, then we should look into getting the airtime queue limit patch into mac80211 as well