On 4/12/19 3:17 PM, Kalle Valo wrote:
Erik Stromdahl writes:
This patch fixes a bug with padding of the skb data buffer.
Since skb_trim can only be used to reduce the skb len, it is useless when
we pad (increase the length of) the skb. Instead we must set skb->len
directly.
Signed-off-by:
> -Original Message-
> From: David Laight
> Sent: Monday, 15 April 2019 9:04 PM
> To: 'Alastair D'Silva' ; 'Petr Mladek'
>
> Cc: 'Alastair D'Silva' ; 'Jani Nikula'
> ; 'Joonas Lahtinen'
> ; 'Rodrigo Vivi' ;
> 'David Airlie' ; 'Daniel Vetter' ; 'Karsten
> Keil' ; 'Jassi Brar' ; 'Tom
>
From: Alastair D'Silva
> Sent: 15 April 2019 11:45
...
> > Although I think you'd want a 'no hex' flag to suppress the hex.
> >
> > Probably more useful flags are ones to suppress the address column.
>
> This is already supported by the prefix_type parameter - are you proposing
> that we
> From: Alastair D'Silva
> > Sent: 15 April 2019 11:29
> ...
> > I do, and I believe the choice of the output length should be in the
> > hands of the caller.
> >
> > On further thought, it would make more sense to remove the hardcoded
> > list of sizes and just enforce a power of 2. The function
From: Alastair D'Silva
> Sent: 15 April 2019 11:29
...
> I do, and I believe the choice of the output length should be in the hands
> of the caller.
>
> On further thought, it would make more sense to remove the hardcoded list of
> sizes and just enforce a power of 2. The function shouldn't
> -Original Message-
> From: David Laight
> Sent: Monday, 15 April 2019 8:21 PM
> To: 'Alastair D'Silva' ; 'Petr Mladek'
>
> Cc: 'Alastair D'Silva' ; 'Jani Nikula'
> ; 'Joonas Lahtinen'
> ; 'Rodrigo Vivi' ;
> 'David Airlie' ; 'Daniel Vetter' ; 'Karsten
> Keil' ; 'Jassi Brar' ; 'Tom
>
> > > On Wed 2019-04-10 13:17:18, Alastair D'Silva wrote:
> > > > From: Alastair D'Silva
> > > >
> > > > Some buffers may only be partially filled with useful data, while
> > > > the rest is padded (typically with 0x00 or 0xff).
> > > >
> > > > This patch introduces flags which allow lines of
> -Original Message-
> From: Petr Mladek
> Sent: Monday, 15 April 2019 7:24 PM
> To: Alastair D'Silva
> Cc: 'Alastair D'Silva' ; 'Jani Nikula'
> ; 'Joonas Lahtinen'
> ; 'Rodrigo Vivi'
;
> 'David Airlie' ; 'Daniel Vetter' ;
'Karsten
> Keil' ; 'Jassi Brar' ; 'Tom
> Lendacky' ; 'David S.
> > > On Wed 2019-04-10 13:17:17, Alastair D'Silva wrote:
> > > > From: Alastair D'Silva
> > > >
> > > > With modern high resolution screens, we can display more data,
> > > > which makes life a bit easier when debugging.
> > >
> > > I have quite some doubts about this feature.
> > >
> > > We
From: Alastair D'Silva
> Sent: 15 April 2019 11:07
...
> In the above example the author only wants the hex output, while in other
> situations, both hex & ASCII output is desirable. If you just want ASCII
> output, the caller should just use a printk or one of it's wrappers.
Hexdump will
On Sat 2019-04-13 09:31:27, Alastair D'Silva wrote:
> > -Original Message-
> > From: Petr Mladek
> > Sent: Saturday, 13 April 2019 12:12 AM
> > To: Alastair D'Silva
> > Cc: alast...@d-silva.org; Jani Nikula ;
> Joonas
> > Lahtinen ; Rodrigo Vivi
> > ; David Airlie ; Daniel Vetter
> > ;
On Sat 2019-04-13 09:28:03, Alastair D'Silva wrote:
> > -Original Message-
> > From: Petr Mladek
> > Sent: Saturday, 13 April 2019 12:04 AM
> > To: Alastair D'Silva
> > Cc: alast...@d-silva.org; Jani Nikula ;
> Joonas
> > Lahtinen ; Rodrigo Vivi
> > ; David Airlie ; Daniel Vetter
> > ;
On Sat 2019-04-13 09:22:05, Alastair D'Silva wrote:
> > -Original Message-
> > From: Petr Mladek
> > Sent: Friday, 12 April 2019 11:48 PM
> > To: Alastair D'Silva
> > Cc: alast...@d-silva.org; Jani Nikula ;
> Joonas
> > Lahtinen ; Rodrigo Vivi
> > ; David Airlie ; Daniel Vetter
> > ;
tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git
ath11k-bringup
head: 9bcbbf4cedb7a1f30cb547cf87dc480d7f8a5e87
commit: 9bcbbf4cedb7a1f30cb547cf87dc480d7f8a5e87 [93/93] ath11k: enable pktlog
filter per peer
New smatch warnings:
drivers/net/wireless/ath/ath11k/debug.c:1143
tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git
ath11k-bringup
head: 9bcbbf4cedb7a1f30cb547cf87dc480d7f8a5e87
commit: b186001339ca6058afd49d7611647bd766dd555e [92/93] ath11k: add pktlog
rxbuf support
New smatch warnings:
drivers/net/wireless/ath/ath11k/dp_rx.c:991
tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git
ath11k-bringup
head: 9bcbbf4cedb7a1f30cb547cf87dc480d7f8a5e87
commit: 426598fdbef82ace7b4a728445f61ecf034f233c [89/93] ath11k: add qmi API
support and rproc_boot for Q6
New smatch warnings:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git
ath11k-bringup
head: 9bcbbf4cedb7a1f30cb547cf87dc480d7f8a5e87
commit: 3a7b4838b6f6f234239f263ef3dc02e612a083ad [66/93] ath11k: Add support
for subsystem recovery
:: branch date: 4 days ago
:: commit date: 12 days ago
tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git
ath11k-bringup
head: 9bcbbf4cedb7a1f30cb547cf87dc480d7f8a5e87
commit: 5cf3588467b76d48542fd0ff70fc666a723df3bb [58/93] ath11k: make
simulate_fw_crash to work if any radio is up
smatch warnings:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git
ath11k-bringup
head: 9bcbbf4cedb7a1f30cb547cf87dc480d7f8a5e87
commit: 627a418bbae46c034b1fd8739c0e94fa62190620 [47/93] ath11k: process
monitor status ring for RX stats
New smatch warnings:
19 matches
Mail list logo