Wen Gong writes:
> add fw coredump for sdio when firmware assert
Please add the changelog here.
> Wen Gong (2):
> ath10k: add bus type for each layout of coredump
> v2: change code style
> v3: split bus type to another patch,
> remove ATH10K_BUS_ANY,
> add bus type for each layout
>
Tomislav Požega writes:
> Drop unneeded lines by moving skb data in both main and 10x WMI
> pull service ready event operations.
>
> Signed-off-by: Tomislav Požega
> ---
> drivers/net/wireless/ath/ath10k/wmi.c |6 ++
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git
Toke Høiland-Jørgensen writes:
> Kalle Valo writes:
>
>> Toke Høiland-Jørgensen writes:
>>
>>> Yibo Zhao writes:
>>>
On 2019-09-21 22:00, Toke Høiland-Jørgensen wrote:
> Yibo Zhao writes:
>
>> On 2019-09-21 21:02, Toke Høiland-Jørgensen wrote:
>>> Yibo Zhao writes:
patch v3 sent.
https://patchwork.kernel.org/patch/11156663/
https://patchwork.kernel.org/patch/11156659/
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
On 2019-09-23 19:00, Toke Høiland-Jørgensen wrote:
- if (params->airtime_weight)
- sta->airtime_weight = params->airtime_weight;
+ if (params->airtime_weight &&
+ params->airtime_weight != sta->airtime_weight) {
This check doesn't work I think? You're not
On 2019-09-23 18:56, Toke Høiland-Jørgensen wrote:
Yibo Zhao writes:
In a loop txqs dequeue scenario, if the first txq in the rbtree gets
removed from rbtree immediately in the ieee80211_return_txq(), the
loop will break soon in the ieee80211_next_txq() due to schedule_pos
not leading to the
On 2019-09-23 18:47, Toke Høiland-Jørgensen wrote:
Yibo Zhao writes:
So, instead we need to keep next_txq() the way it is, and just add
Right, should keep next_txq() the way it is.
local->schedule_pos[ac] = rb_prev(node);
whenever we remove a node (both in return_txq() and resort_txq()).
Software version within WMI event ready message was displayed
in a not very useful decimal format. Change this info to be shown
in a hexadecimal format instead.
Signed-off-by: Tomislav Požega
---
drivers/net/wireless/ath/ath10k/wmi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Drop unneeded lines by moving skb data in both main and 10x WMI
pull service ready event operations.
Signed-off-by: Tomislav Požega
---
drivers/net/wireless/ath/ath10k/wmi.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c
Add lowest/highest 2ghz channel arguments for use within WMI service
ready structure.
Signed-off-by: Tomislav Požega
---
drivers/net/wireless/ath/ath10k/core.h|2 ++
drivers/net/wireless/ath/ath10k/wmi-tlv.c |2 ++
drivers/net/wireless/ath/ath10k/wmi.c |6 ++
Add vht_supp_mcs argument to service ready structure and print
supported MCS rates in WMI service ready debug message.
Signed-off-by: Tomislav Požega
---
drivers/net/wireless/ath/ath10k/core.h|1 +
drivers/net/wireless/ath/ath10k/wmi-tlv.c |1 +
drivers/net/wireless/ath/ath10k/wmi.c
Displays lowest/highest supported channels for both 2ghz and 5ghz
bands as they're fetched within WMI service ready event.
These are shown in a frequency format.
Signed-off-by: Tomislav Požega
---
drivers/net/wireless/ath/ath10k/wmi.c |6 +-
1 files changed, 5 insertions(+), 1
Kalle Valo writes:
> Toke Høiland-Jørgensen writes:
>
>> Yibo Zhao writes:
>>
>>> On 2019-09-21 22:00, Toke Høiland-Jørgensen wrote:
Yibo Zhao writes:
> On 2019-09-21 21:02, Toke Høiland-Jørgensen wrote:
>> Yibo Zhao writes:
>>
>>> On 2019-09-21 19:27, Toke
When firmware assert, it need coredump to analyze, this patch will
collect the register and memory info for sdio chip.
The coredump configuration is different between PCIE and SDIO for
the same reversion, so this patch add bus type to distinguish PCIE
and SDIO chip for coredump.
It has 2 type to
add fw coredump for sdio when firmware assert
Wen Gong (2):
ath10k: add bus type for each layout of coredump
v2: change code style
v3: split bus type to another patch,
remove ATH10K_BUS_ANY,
add bus type for each layout
ath10k: add fw coredump for sdio when firmware assert
v2: change code
For some hw version, it has more than one bus type, it need to add bus
type to distinguish different chip.
Tested with QCA6174 SDIO with firmware
WLAN.RMH.4.4.1-00018-QCARMSWP-1.
Signed-off-by: Wen Gong
---
v2: change code style
v3: split bus type to another patch,
remove ATH10K_BUS_ANY,
add
On 2019-09-23 19:37, Kalle Valo wrote:
Wen Gong writes:
On 2019-09-21 19:38, Kalle Valo wrote:
What's wrong with ath10k_sdio_hif_diag_read()? AFAICS this whole
function duplicates just what it does.
ath10k_sdio_hif_diag_read's buffer size is limit,
and the dump memory/register's buffer
Toke Høiland-Jørgensen writes:
> Yibo Zhao writes:
>
>> On 2019-09-21 22:00, Toke Høiland-Jørgensen wrote:
>>> Yibo Zhao writes:
>>>
On 2019-09-21 21:02, Toke Høiland-Jørgensen wrote:
> Yibo Zhao writes:
>
>> On 2019-09-21 19:27, Toke Høiland-Jørgensen wrote:
>>> Yibo
Wen Gong writes:
> On 2019-09-21 19:38, Kalle Valo wrote:
>>
>> What's wrong with ath10k_sdio_hif_diag_read()? AFAICS this whole
>> function duplicates just what it does.
>
> ath10k_sdio_hif_diag_read's buffer size is limit,
> and the dump memory/register's buffer size is larger than the diag
>
On 2019-09-21 19:49, Kalle Valo wrote:
After looking more closely, the ar->bmi.done_set checks in bmi.c does
not look necessary to me, I have never seen that warning. I would
remove
those and the done_sent field altogether from ath10k to make the code
cleaner and I avoid hacks like above.
On 2019-09-21 19:38, Kalle Valo wrote:
What's wrong with ath10k_sdio_hif_diag_read()? AFAICS this whole
function duplicates just what it does.
ath10k_sdio_hif_diag_read's buffer size is limit,
and the dump memory/register's buffer size is larger than the diag
window's limit,
if use it
On 2019-09-21 19:35, Kalle Valo wrote:
The commit log tells nothing about fast, it should always document the
design decisions. Why this fast dump, what's the benefit? Why not
always
use the fast dump and forget the slow dump (or vice versa)? There needs
to be really good reasons to have all
Yibo Zhao writes:
> Global airtime weight sum is updated only when txq is added/removed
> from rbtree. If upper layer configures sta weight during high load,
> airtime weight sum will not be updated since txq is most likely on the
> tree. It could a little late for upper layer to reconfigure sta
Yibo Zhao writes:
> In a loop txqs dequeue scenario, if the first txq in the rbtree gets
> removed from rbtree immediately in the ieee80211_return_txq(), the
> loop will break soon in the ieee80211_next_txq() due to schedule_pos
> not leading to the second txq in the rbtree. Thus, defering the
>
Yibo Zhao writes:
> Not long after the start of multi-clients test, not a single station is
> an eligible candidate for transmission since global virtual time(g_vt) is
> smaller than the virtual airtime(s_vt) of all the stations. As a result,
> the Tx has been blocked and throughput is quite
Yibo Zhao writes:
> On 2019-09-21 22:00, Toke Høiland-Jørgensen wrote:
>> Yibo Zhao writes:
>>
>>> On 2019-09-21 21:02, Toke Høiland-Jørgensen wrote:
Yibo Zhao writes:
> On 2019-09-21 19:27, Toke Høiland-Jørgensen wrote:
>> Yibo Zhao writes:
>>
>>> On 2019-09-20
Wen Gong writes:
> The thread of read rx message by sdio bus from firmware is
> synchronous, it will cost much time for process the left part
> of rx message which includes indicate the rx packet to uppper
> net stack. It will reduce the time of read from sdio.
This paragraph is hard to read.
Hi,
I am currently working on the 8devices Habanero support for
OpenWrt. This
AP requires two special BDFs to get the Wi-Fi PHYs working (correctly). The
bmi-board-id='s would clash with one of the the IPQ401X AP-DK boards because
QCA doesn't provide special IDs for customers and seems to use the
Wen Gong writes:
> For tcp RX, the quantity of tcp acks to remote is 1/2 of the quantity
> of tcp data from remote, then it will have many small length packets
> on TX path of sdio bus, then it reduce the RX packets's bandwidth of
> tcp.
>
> This patch enable napi on RX path, then the RX packet
Wen Gong writes:
> The max bundle size support by firmware is 32, change it from 8 to 32
> will help performance. This results in significant performance
> improvement on RX path.
>
> Tested with QCA6174 SDIO with firmware
> WLAN.RMH.4.4.1-7-QCARMSWP-1.
>
> Signed-off-by: Wen Gong
[...]
>
Navid Emamdoost wrote:
> In ath10k_usb_hif_tx_sg the allocated urb should be released if
> usb_submit_urb fails.
>
> Signed-off-by: Navid Emamdoost
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
b8d17e7d93d2 ath10k: fix memory leak
--
Navid Emamdoost wrote:
> In ath10k_usb_hif_tx_sg the allocated urb should be released if
> usb_submit_urb fails.
>
> Signed-off-by: Navid Emamdoost
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
b8d17e7d93d2 ath10k: fix memory leak
--
Wen Gong wrote:
> Recently, it has the basic feature of sdio tested success, so remove
> it.
>
> Tested with QCA6174 SDIO with firmware
> WLAN.RMH.4.4.1-00017-QCARMSWP-1.
>
> Signed-off-by: Wen Gong
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
Wen Gong wrote:
> Recently, it has the basic feature of sdio tested success, so remove
> it.
>
> Tested with QCA6174 SDIO with firmware
> WLAN.RMH.4.4.1-00017-QCARMSWP-1.
>
> Signed-off-by: Wen Gong
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
Colin King wrote:
> There are a bunch of spelling mistakes in two ath drivers, fix
> these.
>
> Signed-off-by: Colin Ian King
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
80ce8ca7a647 ath: fix various spelling mistakes
--
Colin King wrote:
> There are a bunch of spelling mistakes in two ath drivers, fix
> these.
>
> Signed-off-by: Colin Ian King
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
80ce8ca7a647 ath: fix various spelling mistakes
--
Rakesh Pillai wrote:
> The index for updating rate table, which is displayed
> in the tx stats via debugfs, is calculated using the
> bandwidth value. The bandwidth values do not map
> correctly with the bandwidth values shown in the rate table.
>
> Correct the bandwidth value calculation which
Rakesh Pillai wrote:
> The index for updating rate table, which is displayed
> in the tx stats via debugfs, is calculated using the
> bandwidth value. The bandwidth values do not map
> correctly with the bandwidth values shown in the rate table.
>
> Correct the bandwidth value calculation which
Surabhi Vishnoi writes:
> WCN3990 firmware sends the HTT_TLV_T2H_MSG_TYPE_PEER_STATS in tlv
> format so the handling of this message has to be done in different
> manner.
>
> This patchset adds support to attach rx_ops based on htt version
> and adds the handling of
Kangjie Lu wrote:
> ath10k_bmi_write32 and ath10k_bmi_read32 can fail. The fix
> checks their statuses to avoid potential undefined behaviors.
>
> Signed-off-by: Kangjie Lu
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
8da96730331d ath10k: fix missing
Surabhi Vishnoi writes:
> The firmware sends peer stats to the host driver if the firmware
> advertises WMI_SERVICE_PEER_STATS service and the host driver
> indicates the WMI_RSRC_CFG_FLAG_TX_PEER_STATS capability in the
> host capab flag in wmi init cmd.
>
> When peer stats are enabled,
Surabhi Vishnoi writes:
> Refactor the code to add the support to attach htt_rx_ops
> based on HTT version.
>
> Tested HW: WCN3990
> Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1
>
> Signed-off-by: Surabhi Vishnoi
[...]
> @@ -3572,7 +3580,7 @@ int ath10k_htt_txrx_compl_task(struct ath10k *ar,
Surabhi Vishnoi wrote:
> With the current implementation of wmi init command,
> there is no provision for the host driver to provide mem
> chunks addresses with more than 32-bit, to the firmware.
> WCN3990 is a 35-bit target and can accept mem chunks addresses
> which are above 32-bit.
>
> If
Surabhi Vishnoi wrote:
> With the current implementation of wmi init command,
> there is no provision for the host driver to provide mem
> chunks addresses with more than 32-bit, to the firmware.
> WCN3990 is a 35-bit target and can accept mem chunks addresses
> which are above 32-bit.
>
> If
Kalle Valo writes:
> Abhishek Ambure wrote:
>
>> PKT log enable command expects pdev id in enable params which is missing
>> in current configuration. Fill pdev id in pkt log enable wmi command for
>> correct configuration.
>>
>> Fixes: ca996ec56608 ("ath10k: implement wmi-tlv backend")
>>
Rakesh Pillai wrote:
> The peer param id for PEER_PARAM_USE_FIXED_PWR
> is different for tlv and non-tlv firmware. This
> causes incorrect peer param to be set by the driver
> to the firmware(tlv/non-tlv).
>
> Create seperate peer param map for tlv and non-tlv
> firmware and attach the peer
Rakesh Pillai wrote:
> The peer param id for PEER_PARAM_USE_FIXED_PWR
> is different for tlv and non-tlv firmware. This
> causes incorrect peer param to be set by the driver
> to the firmware(tlv/non-tlv).
>
> Create seperate peer param map for tlv and non-tlv
> firmware and attach the peer
Global airtime weight sum is updated only when txq is added/removed
from rbtree. If upper layer configures sta weight during high load,
airtime weight sum will not be updated since txq is most likely on the
tree. It could a little late for upper layer to reconfigure sta weight
when txq is already
Not long after the start of multi-clients test, not a single station is
an eligible candidate for transmission since global virtual time(g_vt) is
smaller than the virtual airtime(s_vt) of all the stations. As a result,
the Tx has been blocked and throughput is quite low.
This may mainly due to
From: Toke Høiland-Jørgensen
This switches the airtime scheduler in mac80211 to use a virtual time-based
scheduler instead of the round-robin scheduler used before. This has a
couple of advantages:
- No need to sync up the round-robin scheduler in firmware/hardware with
the round-robin
This series fix some issues when enabling virtual time-based airtime scheduler
on ath10k.
Changes since v2:
Changes station airtime weight to be per-AC based to avoid sync issue
Remove Co-developed-by and Toke's sign-off as Toke suggested
Changes since v1:
Modify the author of
51 matches
Mail list logo
