Re: [PATCH v2 3/5] ath10k: sdio: read RX packets in bundles

2019-09-24 Thread Kalle Valo
Kalle Valo writes: > Erik Stromdahl wrote: > >> From: Alagu Sankar >> >> The existing implementation of initiating multiple sdio transfers for >> receive bundling is slowing down the receive speed. >> >> Instead of having one sdio transfer for each packet in the bundle, we >> read all

Re: [PATCH v2 3/5] ath10k: sdio: read RX packets in bundles

2019-09-24 Thread Kalle Valo
Erik Stromdahl wrote: > From: Alagu Sankar > > The existing implementation of initiating multiple sdio transfers for > receive bundling is slowing down the receive speed. > > Instead of having one sdio transfer for each packet in the bundle, we > read all packets in one sdio transfer. > >

Re: [PATCH] ath10k: remove iteration in wake_tx_queue

2019-09-24 Thread Kalle Valo
Erik Stromdahl wrote: > Iterating the TX queue and thereby dequeuing all available packets in the > queue could result in performance penalties on some SMP systems. > > The reason for this is most likely that the per-ac lock (active_txq_lock) > in mac80211 will be held by the CPU iterating the

Re: [PATCH] ath10k: remove iteration in wake_tx_queue

2019-09-24 Thread Kalle Valo
Erik Stromdahl wrote: > Iterating the TX queue and thereby dequeuing all available packets in the > queue could result in performance penalties on some SMP systems. > > The reason for this is most likely that the per-ac lock (active_txq_lock) > in mac80211 will be held by the CPU iterating the

Re: [PATCH v2] ath10k: Enable support for beacon interval per VAP

2019-09-24 Thread Kalle Valo
Dundi Raviteja writes: > Enable support to configure different beacon interval per VAP. > > To support this feature, map different beacon interval service bit > to wmi tlv service. > > Tested HW: WCN3990 > Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1 > > Signed-off-by: Dundi Raviteja [...] >

Re: [PATCH v5 0/8] ath10k: improve throughout of tcp/udp TX/RX of sdio

2019-09-24 Thread Wen Gong
On 2019-09-23 17:29, Kalle Valo wrote: Wen Gong writes: The bottleneck of throughout on sdio chip is the bus bandwidth, to the patches are all to increase the use ratio of sdio bus. udp-rxudp-txtcp-rxtcp-tx without patches(Mbps) 320180 170

Re: [PATCH v5 3/8] ath10k: change max RX bundle size from 8 to 32 for sdio

2019-09-24 Thread Wen Gong
On 2019-09-23 17:05, Kalle Valo wrote: +#define ATH10K_HTC_FLAG_BUNDLE_MASK 0xF0 +#define ATH10K_HTC_BUNDLE_EXTRA_MASK GENMASK(3, 2) + +#define ATH10K_HTC_GET_BUNDLE_COUNT(flags) \ + (FIELD_GET(ATH10K_HTC_FLAG_BUNDLE_MASK, (flags)) + \ +

Re: [PATCH V3 3/4] mac80211: fix low throughput in multi-clients situation

2019-09-24 Thread Yibo Zhao
On 2019-09-24 16:48, Toke Høiland-Jørgensen wrote: Yibo Zhao writes: I can see why we need the second part (basically, this happens because I forgot to add a check for "no eligible stations" in may_transmit(), like the one in next_txq()). And rounding up the division result doesn't hurt, I

Re: [PATCH V3 3/4] mac80211: fix low throughput in multi-clients situation

2019-09-24 Thread Toke Høiland-Jørgensen
Yibo Zhao writes: >> I can see why we need the second part (basically, this happens because >> I >> forgot to add a check for "no eligible stations" in may_transmit(), >> like >> the one in next_txq()). And rounding up the division result doesn't >> hurt, I guess. But why does it help to

Re: [PATCH 2/4] mac80211: defer txqs removal from rbtree

2019-09-24 Thread Toke Høiland-Jørgensen
Yibo Zhao writes: > On 2019-09-24 15:26, Toke Høiland-Jørgensen wrote: Hmm, yeah, I guess we could end up with a loop like that as well. Keeping the schedule_round would be a way to fix it, but I'm not sure we should just skip that station; maybe we should just end the round

Re: [PATCH 2/4] mac80211: defer txqs removal from rbtree

2019-09-24 Thread Yibo Zhao
On 2019-09-24 15:26, Toke Høiland-Jørgensen wrote: Hmm, yeah, I guess we could end up with a loop like that as well. Keeping the schedule_round would be a way to fix it, but I'm not sure we should just skip that station; maybe we should just end the round instead? I am not sure. I believe, in

Re: [PATCH V3 3/4] mac80211: fix low throughput in multi-clients situation

2019-09-24 Thread Yibo Zhao
On 2019-09-23 18:55, Toke Høiland-Jørgensen wrote: Yibo Zhao writes: Not long after the start of multi-clients test, not a single station is an eligible candidate for transmission since global virtual time(g_vt) is smaller than the virtual airtime(s_vt) of all the stations. As a result,

Re: [PATCH 5/5] ath10k: pull_svc_rdy code-style fix

2019-09-24 Thread Tom Psyborg
On 24/09/2019, Kalle Valo wrote: > Tomislav Požega writes: > >> Drop unneeded lines by moving skb data in both main and 10x WMI >> pull service ready event operations. >> >> Signed-off-by: Tomislav Požega >> --- >> drivers/net/wireless/ath/ath10k/wmi.c |6 ++ >> 1 files changed, 2

Re: [PATCH v3 0/2] add fw coredump for sdio when firmware assert

2019-09-24 Thread Wen Gong
On 2019-09-24 13:42, Kalle Valo wrote: patch v4 sent. So please rebase and resend.

[PATCH v4 1/2] ath10k: add bus type for each layout of coredump

2019-09-24 Thread Wen Gong
For some hw version, it has more than one bus type, it need to add bus type to distinguish different chip. Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00018-QCARMSWP-1. Signed-off-by: Wen Gong --- v2: change code style v3: split bus type to another patch, remove ATH10K_BUS_ANY, add

[PATCH v4 2/2] ath10k: add fw coredump for sdio when firmware assert

2019-09-24 Thread Wen Gong
When firmware assert, it need coredump to analyze, this patch will collect the register and memory info for sdio chip. The coredump configuration is different between PCIE and SDIO for the same reversion, so this patch add bus type to distinguish PCIE and SDIO chip for coredump. It has 2 type to

[PATCH v4 0/2] add fw coredump for sdio when firmware assert

2019-09-24 Thread Wen Gong
add fw coredump for sdio when firmware assert v2: change code style v3: split bus type to another patch, remove ATH10K_BUS_ANY, add bus type for each layout v4: rebase to latest commit Wen Gong (2): ath10k: add bus type for each layout of coredump ath10k: add fw coredump for sdio when

Re: [PATCH V3 4/4] mac80211: Sync airtime weight sum with per AC synced sta airtime weight together

2019-09-24 Thread Toke Høiland-Jørgensen
Yibo Zhao writes: > On 2019-09-23 19:00, Toke Høiland-Jørgensen wrote: > >>> - if (params->airtime_weight) >>> - sta->airtime_weight = params->airtime_weight; >>> + if (params->airtime_weight && >>> + params->airtime_weight != sta->airtime_weight) { >> >> This check doesn't

Re: [PATCH 2/4] mac80211: defer txqs removal from rbtree

2019-09-24 Thread Toke Høiland-Jørgensen
>> Hmm, yeah, I guess we could end up with a loop like that as well. >> Keeping the schedule_round would be a way to fix it, but I'm not sure >> we >> should just skip that station; maybe we should just end the round >> instead? > I am not sure. I believe, in some cases, the rest of the nodes

Re: [PATCH 2/4] mac80211: defer txqs removal from rbtree

2019-09-24 Thread Toke Høiland-Jørgensen
Kalle Valo writes: > Toke Høiland-Jørgensen writes: > >> Kalle Valo writes: >> >>> Toke Høiland-Jørgensen writes: >>> Yibo Zhao writes: > On 2019-09-21 22:00, Toke Høiland-Jørgensen wrote: >> Yibo Zhao writes: >> >>> On 2019-09-21 21:02, Toke Høiland-Jørgensen

ath10k-firmware: QCA9888 hw2.0: Add EnGenius EMR5000 specific BDFs

2019-09-24 Thread frank.shen
Hi, The support for this device was added a while ago to OpenWrt. This AP requires two special BDFs to get the Wi-Fi PHYs working (correctly). The bmi-board-id='s would clash with one of the the IPQ401X AP-DK boards because QCA doesn't provide special IDs for customers and seems to use the